Migrate script: Copy and wording updates#15
Merged
Merged
Conversation
no ref - 99% of users will want to import their configuration by default so just do it and let users know - We now just print the config we're importing then continue on
no ref - The thinking here is this allows users to more easily run multiple Ghost instances on the same server by templating the Ghost port - Majority wont need this but it also simplifies the message around having to forward traffic if you don't start Caddy
no ref - No reason beyond making things quieter
jloh
force-pushed
the
copy_and_other
branch
2 times, most recently
from
b9f9eaa to
4d52209
Compare
no ref - Using a passsord on the CLI causes MySQL to print 'mysql: [Warning] Using a password on the command line interface can be insecure.' which doing via environment variables prevents - This also fixes our other `cut` usages in the event the string has a `=` in it not printing the whole string
no ref - rsync will print us out a nice progress screen if we lower the verbosity which is nicer than outputting all of the files we're moving
no ref - Our docs suggest installation Ghost by default in `/var/www/` so search one level deep for Ghost installations - If we find any, prompt the user if any of these are the ones they want to migrate otherwise let users prompt for a custom dir
no ref - This should help users with the 'What next?' question at the end of their migration and gives them something to come back to once done
- The idea here is this can start up and do its thing in the background whilst we're rsync'ing content and saves us waiting longer later on
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.