TB: Remove requirement for UUID setting#9
Merged
Merged
Conversation
Closes https://linear.app/ghost/issue/ENG-2442/ ref TryGhost/Ghost@e97d6c0 - Ghost used to require this to set/manage a UUID in TB/clickhouse but we now use Ghost's generated one directly, instead of requiring it here - Cleaning this up because otherwise if they don't match the UI and the tracking events don't go to the same bucket
Member
Author
|
@cmraible are you able to review this and make sure my understanding is correct? I believe this isn't required anymore and from my testing it doesn't appear to be, but just want to make sure I'm on the right track. |
- TB can now be toggled via the UI and setting it via env variables means the setting can never be toggled on/off properly - Doing it this way lets users control things more
cmraible
approved these changes
Jul 3, 2025
Contributor
cmraible
left a comment
cmraible
left a comment
There was a problem hiding this comment.
LGTM — you are correct re: the uuid, sorry I forgot to update this here since we implemented it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/ghost/issue/ENG-2442/
ref TryGhost/Ghost@e97d6c0