Update to support member.status = gift#98
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
WalkthroughThis change adds support for a new 'gift' member status throughout the application. The Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Review rate limit: 3/5 reviews remaining, refill in 14 minutes and 7 seconds. Comment |
gift value to member.status (alongside free,gift
ref https://linear.app/ghost/issue/BER-3594 Ghost added a new `gift` value to `member.status` (alongside `free`, `paid`, and `comped`) to represent members with a gift subscription. This change extends the CLI to recognise it: - Allow `--status gift` on `ghst member list` (Zod schema + help text). - Sum `row.gift` in `normalizeMembersSeries`'s `total_members` fallback, so gift members aren't silently dropped from totals when Ghost's `/stats/member_count/` response omits a precomputed total. Verified against Ghost 6.36, which already emits a `gift` bucket in member count rows and `meta.totals`. Audience filtering (`stats --audience`) is intentionally unchanged: Ghost's Tinybird pipes only accept `undefined|free|paid` as inputs and fold gift sessions into `paid` server-side (per TryGhost/Ghost#27614), so no client change is needed there
c5146b7 to
b768e8c
Compare
ref https://linear.app/ghost/issue/BER-3594
Ghost added a new
giftvalue tomember.status(alongsidefree,paid, andcomped) to represent members with a gift subscription. This change extends the CLI to recognise it:--status giftonghst member list(Zod schema + help text).row.giftinnormalizeMembersSeries'stotal_membersfallback, so gift members aren't silently dropped from totals when Ghost's/stats/member_count/response omits a precomputed total. Verified against Ghost 6.36, which already emits agiftbucket in member count rows andmeta.totals.Audience filtering (
stats --audience) is intentionally unchanged: Ghost's Tinybird pipes only acceptundefined|free|paidas inputs and fold gift sessions intopaidserver-side (per TryGhost/Ghost#27614), so no client change is needed there