fix(predicate): glowing effect with infinite duration not getting recognized

Add an additional check to the predicates to detect the glowing effect even when its duration is infinite (closes #98)

Author: Tschipcraft

CHANGES.md

@@ -1,2 +1,3 @@
 - Fixed broken bubble column creation when holding a light source (closes [#105](https://github.com/Tschipcraft/dynamiclights/issues/105))
 - Fixed possibility to create a suspended water block when holding a light source (closes [#106](https://github.com/Tschipcraft/dynamiclights/issues/106))
+- Fixed glowing potion effect with infinite duration not getting recognized (closes [#98](https://github.com/Tschipcraft/dynamiclights/issues/98))

data/dynamiclights/predicate/entity/additional_effect_tests/glowing.json

@@ -0,0 +1,33 @@
+[
+  {
+    "//comment": "This predicate returns false, if the tested entity has the glowing effect",
+    "condition": "minecraft:inverted",
+    "term": {
+      "condition": "minecraft:entity_properties",
+      "entity": "this",
+      "predicate": {
+        "effects": {
+          "minecraft:glowing": {
+            "duration": {
+              "min": 1
+            }
+          }
+        }
+      }
+    }
+  },
+  {
+    "condition": "minecraft:inverted",
+    "term": {
+      "condition": "minecraft:entity_properties",
+      "entity": "this",
+      "predicate": {
+        "effects": {
+          "minecraft:glowing": {
+            "duration": -1
+          }
+        }
+      }
+    }
+  }
+]

data/dynamiclights/predicate/entity/is_glowing.json

@@ -16,16 +16,10 @@
     }
   },
   {
-    "condition": "minecraft:entity_properties",
-    "entity": "this",
-    "predicate": {
-      "effects": {
-        "minecraft:glowing": {
-          "duration": {
-            "min": 1
-          }
-        }
-      }
+    "condition": "minecraft:inverted",
+    "term": {
+      "condition": "minecraft:reference",
+      "name": "dynamiclights:entity/additional_effect_tests/glowing"
     }
   }
 ]

data/dynamiclights/predicates/entity/additional_effect_tests/glowing.json

@@ -0,0 +1,33 @@
+[
+  {
+    "//comment": "This predicate returns false, if the tested entity has the glowing effect",
+    "condition": "minecraft:inverted",
+    "term": {
+      "condition": "minecraft:entity_properties",
+      "entity": "this",
+      "predicate": {
+        "effects": {
+          "minecraft:glowing": {
+            "duration": {
+              "min": 1
+            }
+          }
+        }
+      }
+    }
+  },
+  {
+    "condition": "minecraft:inverted",
+    "term": {
+      "condition": "minecraft:entity_properties",
+      "entity": "this",
+      "predicate": {
+        "effects": {
+          "minecraft:glowing": {
+            "duration": -1
+          }
+        }
+      }
+    }
+  }
+]

data/dynamiclights/predicates/entity/is_glowing.json

@@ -16,16 +16,10 @@
     }
   },
   {
-    "condition": "minecraft:entity_properties",
-    "entity": "this",
-    "predicate": {
-      "effects": {
-        "minecraft:glowing": {
-          "duration": {
-            "min": 1
-          }
-        }
-      }
+    "condition": "minecraft:inverted",
+    "term": {
+      "condition": "minecraft:reference",
+      "name": "dynamiclights:entity/additional_effect_tests/glowing"
     }
   }
 ]