Skip to content

Commit 1fcba84

Browse files
committed
Bump mod version
- Bump mod version to 0.4.0-beta.1 - Apply non-functional cleanups: clarify wording in comments, normalize spacing in locale JSON files, and fix a malformed key in uk_ua.json - Add contributor names to credit fields
1 parent b566a70 commit 1fcba84

10 files changed

Lines changed: 20 additions & 15 deletions

File tree

common/src/main/java/net/tschipcraft/make_bubbles_pop/mixin/client/BarrelBlockEntityMixin.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
import org.spongepowered.asm.mixin.Unique;
77

88
/**
9-
* This mixin injects into the BarrelBlockEntity class to add a flag for tracking if a barrel was loaded.
10-
* Used to prevent bubbles from spawning when a chunk with an already open barrel is loaded.
9+
* This mixin injects into the BarrelBlockEntity class to add a flag that tracks whether a barrel has been loaded.
10+
* Used to prevent bubbles from spawning when a chunk containing an already open barrel is loaded.
1111
*/
1212
@Mixin(BarrelBlockEntity.class)
1313
public abstract class BarrelBlockEntityMixin implements BarrelBlockEntityInterface {

common/src/main/java/net/tschipcraft/make_bubbles_pop/mixin/client/BubblePop.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ protected BubblePop(ClientWorld clientWorld, double d, double e, double f) {
140140

141141
// Search way around blocks
142142
if (!this.world.isWater(BlockPos.ofFloored(this.x, this.y + 0.8D, this.z)) && !this.world.isAir(BlockPos.ofFloored(this.x, this.y + 0.8D, this.z))) {
143-
// Direct way upwards blocked -> search up different way to water surface
143+
// Direct way upwards blocked -> search for a different way to water surface
144144

145145
boolean escapePosX = this.world.isWater(BlockPos.ofFloored(this.x + 1D, this.y + 0.8D, this.z)) && this.world.isWater(BlockPos.ofFloored(this.x + 1D, this.y, this.z));
146146
boolean escapeNegX = this.world.isWater(BlockPos.ofFloored(this.x - 1D, this.y + 0.8D, this.z)) && this.world.isWater(BlockPos.ofFloored(this.x - 1D, this.y, this.z));
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
22
"modmenu.summaryTranslation.make_bubbles_pop": "Arrr matey, this here makes yer bubbles pop!",
3-
"modmenu.descriptionTranslation.make_bubbles_pop": "Arrr! This here client-side mod makes yer bubble particles pop an' lets them realistically rise to the water surface.\nIt also adds bubble particles to openin' chests, openin' barrels an' explosions underwater.\n",
4-
"fml.menu.mods.info.description.make_bubbles_pop": "Arrr matey! This here client-side mod makes yer bubble particles pop an' lets them realistically rise to the water surface.\n\nIt also adds bubble particles to openin' chests, openin' barrels an' explosions underwater.\n"
3+
"modmenu.descriptionTranslation.make_bubbles_pop": "Arrr! This here client-side mod makes yer bubble particles pop an' lets them realistically rise to the water surface. \nIt also adds bubble particles to openin' chests, openin' barrels an' explosions underwater. \n",
4+
"fml.menu.mods.info.description.make_bubbles_pop": "Arrr matey! This here client-side mod makes yer bubble particles pop an' lets them realistically rise to the water surface. \n\nIt also adds bubble particles to openin' chests, openin' barrels an' explosions underwater. \n"
55
}

common/src/main/resources/assets/make_bubbles_pop/lang/en_us.json

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
{
22
"modmenu.summaryTranslation.make_bubbles_pop": "Makes bubble particles pop and lets them rise to the water surface.",
3-
"modmenu.descriptionTranslation.make_bubbles_pop": "This client-side mod makes bubble particles pop and lets them realistically rise to the water surface.\nIt also adds bubble particles to opening chests, opening barrels and explosions underwater.",
4-
"fml.menu.mods.info.description.make_bubbles_pop": "This client-side mod makes bubble particles pop and lets them realistically rise to the water surface.\n\nIt also adds bubble particles to opening chests, opening barrels and explosions underwater.",
3+
"modmenu.descriptionTranslation.make_bubbles_pop": "This client-side mod makes bubble particles pop and lets them realistically rise to the water surface. \nIt also adds bubble particles to opening chests, opening barrels and explosions underwater.",
4+
"fml.menu.mods.info.description.make_bubbles_pop": "This client-side mod makes bubble particles pop and lets them realistically rise to the water surface. \n\nIt also adds bubble particles to opening chests, opening barrels and explosions underwater.",
55

66
"make_bubbles_pop.yacl.missing": "Yet Another Config Lib is not installed!",
7-
"make_bubbles_pop.yacl.missing.description": "Make Bubbles Pop for Fabric&Quilt requires Yet Another Config Lib to be installed for configuration. Would you like to download it now?",
7+
"make_bubbles_pop.yacl.missing.description": "Make Bubbles Pop for Fabric & Quilt requires Yet Another Config Lib to be installed for configuration. Would you like to download it now?",
88

99
"make_bubbles_pop.config.title": "Make Bubbles Pop Configuration",
1010
"make_bubbles_pop.config.empty": "",
@@ -33,5 +33,4 @@
3333
"make_bubbles_pop.config.CONTAINER_SOUND_ENABLED.tooltip": "Default: §aON§f",
3434
"make_bubbles_pop.config.EXPLOSION_BUBBLES_ENABLED": "Enable Explosion Bubbles",
3535
"make_bubbles_pop.config.EXPLOSION_BUBBLES_ENABLED.tooltip": "Default: §aON§f \n§dℹ Note:§f Make sure to disable this or Explosive Enhancement's implementation if Explosive Enhancement is installed."
36-
3736
}

common/src/main/resources/assets/make_bubbles_pop/lang/ko_kr.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"modmenu.summaryTranslation.make_bubbles_pop": "버블 입자가 터지게 하고 물 표면으로 올라오게 합니다.",
3-
"modmenu.descriptionTranslation.make_bubbles_pop": "이 클라이언트 사이드 모드는 거품 입자가 터지고 현실적으로 물 표면으로 떠오르게 만듭니다.\n또한, 이 모드는 상자를 열거나, 통을 열거나, 물속에서 폭발이 일어날 때 거품 입자를 추가합니다.",
4-
"fml.menu.mods.info.description.make_bubbles_pop": "이 클라이언트 사이드 모드는 거품 입자가 터지고 현실적으로 물 표면으로 떠오르게 만듭니다.\n\n또한, 이 모드는 상자를 열거나, 통을 열거나, 물속에서 폭발이 일어날 때 거품 입자를 추가합니다.",
3+
"modmenu.descriptionTranslation.make_bubbles_pop": "이 클라이언트 사이드 모드는 거품 입자가 터지고 현실적으로 물 표면으로 떠오르게 만듭니다. \n또한, 이 모드는 상자를 열거나, 통을 열거나, 물속에서 폭발이 일어날 때 거품 입자를 추가합니다.",
4+
"fml.menu.mods.info.description.make_bubbles_pop": "이 클라이언트 사이드 모드는 거품 입자가 터지고 현실적으로 물 표면으로 떠오르게 만듭니다. \n\n또한, 이 모드는 상자를 열거나, 통을 열거나, 물속에서 폭발이 일어날 때 거품 입자를 추가합니다.",
55

66
"make_bubbles_pop.yacl.missing": "Yet Another Config Lib 가 설치되지 않았습니다!",
77
"make_bubbles_pop.yacl.missing.description": "패브릭&퀼트를 위한 \"Make Bubbles Pop\"을(를) 사용하려면 설정을 위해 \"Yet Another Config Lib\"를 설치해야 합니다. 지금 다운로드하시겠습니까?",
@@ -33,5 +33,4 @@
3333
"make_bubbles_pop.config.CONTAINER_SOUND_ENABLED.tooltip": "기본값: §a예§f",
3434
"make_bubbles_pop.config.EXPLOSION_BUBBLES_ENABLED": "폭발 버블 활성화",
3535
"make_bubbles_pop.config.EXPLOSION_BUBBLES_ENABLED.tooltip": "기본값: §a예§f \n§dℹ 주의:§f Explosive Enhancement가 설치된 경우, 이 설정 또는 Explosive Enhancement의 구현을 비활성화해야 합니다."
36-
3736
}

common/src/main/resources/assets/make_bubbles_pop/lang/uk_ua.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"modmenu.descriptionTranslation.make_bubbles_pop": "Цей клієнтський мод дозволяє частинкам бульбашок лопатися та реалістично підійматися на поверхню води. \nВін також додає частинки бульбашок при відкритті скринь, діжок та вибухах під водою.",
44
"fml.menu.mods.info.description.make_bubbles_pop": "Цей клієнтський мод дозволяє частинкам бульбашок лопатися та реалістично підійматися на поверхню води. \n\nВін також додає частинки бульбашок при відкритті скринь, діжок та вибухах під водою.",
55

6-
"make_bubbles_pop.config.title",: "Налаштування Make Bubbles Pop",
6+
"make_bubbles_pop.config.title": "Налаштування Make Bubbles Pop",
77
"make_bubbles_pop.config.empty": "",
88
"make_bubbles_pop.config.additional_features": "Додаткові функції",
99

fabric/src/main/resources/fabric.mod.json

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,16 @@
1616
"version": "${version}-fabric",
1717
"name": "Make Bubbles Pop",
1818
"description": "This client-side mod makes bubble particles pop and lets them realistically rise to the water surface.\nIt also adds bubble particles to opening chests, opening barrels and explosions underwater.",
19-
"license": "Custom",
2019
"icon": "icon.png",
20+
"license": "Custom",
2121
"authors": [
2222
"Tschipcraft"
2323
],
24+
"contributors": [
25+
"AViewFromTheTop",
26+
"Merhaf",
27+
"Mykytius"
28+
],
2429
"contact": {
2530
"homepage": "https://tschipcraft.ddns.net/make_bubbles_pop.html",
2631
"sources": "https://github.com/Tschipcraft/make_bubbles_pop/tree/archloom",

forge/src/main/resources/META-INF/mods.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ This client-side mod makes bubble particles pop and completely overhauls their b
1515
It also adds bubble particles to opening chests, opening barrels and explosions underwater.
1616
'''
1717
authors="Tschipcraft"
18+
credits="AViewFromTheTop, Merhaf, Mykytius"
1819
logoFile= "icon.png"
1920
logoBlur=false
2021
displayURL="https://github.com/Tschipcraft/make_bubbles_pop/tree/archloom"

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ org.gradle.jvmargs=-Xmx3G
33
org.gradle.parallel=true
44

55
# Mod Properties
6-
mod_version = 0.3.2
6+
mod_version = 0.4.0-beta.1
77
maven_group = net.tschipcraft
88
archives_name = make_bubbles_pop
99
enabled_platforms = fabric,forge,neoforge

neoforge/src/main/resources/META-INF/neoforge.mods.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ This client-side mod makes bubble particles pop and completely overhauls their b
1313
It also adds bubble particles to opening chests, opening barrels and explosions underwater.
1414
'''
1515
authors="Tschipcraft"
16+
credits="AViewFromTheTop, Merhaf, Mykytius"
1617
logoFile="icon.png"
1718
logoBlur=false
1819
displayURL="https://github.com/Tschipcraft/make_bubbles_pop/tree/archloom"

0 commit comments

Comments
 (0)