feat: Add categories to fleet-plan diff output#36
Open
kc9wwh wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Parser (internal/parser/parser.go): Added Categories []string to parsed and raw software structs; wired through resolution functions with team-level override support (same pattern as self_service).
API client (internal/api/client.go): Added Categories []string to TeamSoftwarePackage, TeamFleetApp, TeamAppStoreApp.
Diff engine (internal/diff/differ.go): Added IsSlice/OldSlice/NewSlice fields to FieldDiff for structured JSON output. Added categoriesEqual (set comparison), formatCategories, sortedCategories helpers. Emit category diffs for
all software types in both ADDED and MODIFIED paths.
JSON renderer (internal/output/json.go): Changed JSONField.Old/New from string to any so slice fields render as arrays instead of stringified brackets.
Terminal/Markdown renderers: No code changes needed — formatCategories produces display strings like [Browsers, Communication] that the existing renderers handle naturally.
Validated output
Test plan
go test -race ./...— all passgo vet ./...— cleanTestDiffSoftwareCategories(8 cases),TestCategoriesEqual,TestFormatCategoriesTestRenderDiffJSONCategories,TestRenderDiffJSONStringFieldsUnchanged,TestRenderDiffTerminalCategories,TestRenderDiffMarkdownCategoriesTestDiffTestdataAgainstMockAPIcovers categories in mock state