Skip to content

Add IndexedDB Extension#1341

Closed
ffghdfh wants to merge 28 commits into
TurboWarp:masterfrom
ffghdfh:IndexedDB-Extension
Closed

Add IndexedDB Extension#1341
ffghdfh wants to merge 28 commits into
TurboWarp:masterfrom
ffghdfh:IndexedDB-Extension

Conversation

@ffghdfh

@ffghdfh ffghdfh commented Mar 2, 2024

Copy link
Copy Markdown
Contributor

lemme in please 🥺

@CubesterYT

Copy link
Copy Markdown
Member

Please don't close and open the PRs. Are you experiencing some kind of problem?

@ffghdfh

ffghdfh commented Mar 2, 2024

Copy link
Copy Markdown
Contributor Author

Please don't close and open the PRs. Are you experiencing some kind of problem?

Oh sh#t sorry, didn't know I shouldn't do that😅
i've just been trying to add my extension and there was always something that came up! But i guess i just gotta play the waiting game...

@CST1229

CST1229 commented Mar 2, 2024

Copy link
Copy Markdown
Collaborator

i've just been trying to add my extension and there was always something that came up! But i guess i just gotta play the waiting game...

Don't expect pull requests to be merged soon; GarboMuffin (TurboWarp's creator) has a job and mostly only is active here on weekends.

@ffghdfh

ffghdfh commented Mar 3, 2024

Copy link
Copy Markdown
Contributor Author

i've just been trying to add my extension and there was always something that came up! But i guess i just gotta play the waiting game...

Don't expect pull requests to be merged soon; GarboMuffin (TurboWarp's creator) has a job and mostly only is active here on weekends.

OHHH! I THOUGHT ALL OF Y'ALL WHO COMMENT COULD TOTALLY MERGE IT AND JUST DIDN'T WANT TO 😅
Okay that's good to know, thank you for letting me know about that too! :D

Comment thread extensions/ffghdfh/indexedDB.js Outdated
Comment thread extensions/ffghdfh/indexedDB.js

@ffghdfh ffghdfh left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed what y'all asked for!

LilyMakesThings
LilyMakesThings previously approved these changes Mar 3, 2024
@DNin01

DNin01 commented Mar 16, 2024

Copy link
Copy Markdown
Collaborator

I worry that projects might abuse this to take up lots of storage on users' devices, and local storage is fine for the most common use cases. Does IndexedDB have any limits?

@CST1229

CST1229 commented Mar 17, 2024

Copy link
Copy Markdown
Collaborator

I worry that projects might abuse this to take up lots of storage on users' devices, and local storage is fine for the most common use cases. Does IndexedDB have any limits?

https://developer.mozilla.org/en-US/docs/Web/API/Storage_API/Storage_quotas_and_eviction_criteria#other_web_technologies
there is a limit, but it's gigabytes in size (and also browser-dependent)

ffghdfh added 5 commits March 24, 2024 14:33
Updated IndexedDB extension with new features and improvements

- Renamed "get value for key ()" to "get key ()"
- Set all default block values to empty strings
- Added "export db" reporter block to export the entire database as a JSON string
- Added "import db from ()" command block to import and replace the database from a JSON string
- Added "merge db from ()" command block to merge data from a JSON string without overwriting existing keys
@Drago-Cuven

This comment was marked as spam.

@Thebloxers998

This comment was marked as spam.

@Thebloxers998

This comment was marked as spam.

Comment thread extensions/ffghdfh/indexedDB.js
Comment thread extensions/ffghdfh/indexedDB.js
Comment thread extensions/ffghdfh/indexedDB.js

@ffghdfh ffghdfh left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol this all makes sense and stuff thanks guys lol
btw i'm not even sure this is the version i use since i've been using the one I sumbitted here https://github.com/ffghdfh/lemons-gallery-ff/blob/main/extensions/golbo/IndexedDB.js

@CubesterYT

CubesterYT commented Dec 27, 2024

Copy link
Copy Markdown
Member

!format
seems to have failed
CC @GarboMuffin

@GarboMuffin

Copy link
Copy Markdown
Member

!format

@CubesterYT

Copy link
Copy Markdown
Member

It worked!

@Thebloxers998

Copy link
Copy Markdown

It worked!

Yep, it did

@GarboMuffin

GarboMuffin commented Jan 12, 2025

Copy link
Copy Markdown
Member

I have been stalling on this because the dream is that users don't need to worry about where the data is stored; we have one extension that transparently does the right thing.

Thebloxers998
Thebloxers998 previously approved these changes Jan 13, 2025
@GarboMuffin GarboMuffin dismissed stale reviews from Thebloxers998 and LilyMakesThings November 17, 2025 23:23

Dismissing old approvals so that moving forward everything follows #2327

@Brackets-Coder Brackets-Coder changed the title IndexedDB extension (omg this is like my 3rd try lol) Add IndexedDB Extension Feb 15, 2026
@Brackets-Coder

Copy link
Copy Markdown
Contributor

@ffghdfh is this still being worked on?

@ffghdfh

ffghdfh commented Feb 22, 2026

Copy link
Copy Markdown
Contributor Author

@ffghdfh is this still being worked on?

Nnnnope not really, it works fine enough I guess? feel free to poke at it if you'd like

@ffghdfh

ffghdfh commented Feb 22, 2026

Copy link
Copy Markdown
Contributor Author

i've just been trying to add my extension and there was always something that came up! But i guess i just gotta play the waiting game...

Don't expect pull requests to be merged soon; GarboMuffin (TurboWarp's creator) has a job and mostly only is active here on weekends.

Mind you this was in 2024 and it still has not been merged yet

@Brackets-Coder

Copy link
Copy Markdown
Contributor

Mind you this was in 2024 and it still has not been merged yet

Yes, I know this repository is notoriously slow. I'm doing my best to increase merge rates but to be honest we don't have the frameworks to keep the tap water flowing.

As garbomuffin mentioned, any kind of "storage" extension becomes complicated, so I'll see what I can do to review later (I'm busy right now). Hopefully we can get this merged soon but I really can't say for sure :/

@ffghdfh

ffghdfh commented Feb 22, 2026 via email

Copy link
Copy Markdown
Contributor Author

@Brackets-Coder

Brackets-Coder commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

@ffghdfh

One of the optimizations we've been trying to do is consolidating duplicate PRs (see #2271). Since #2087 has been closed, this is the main storage extension pull request open right now.

As mentioned before, I think persistent browser storage is a great idea (e.g., for save codes) but this has to be a seamless experience and have a standardized storage location to be a great user experience for projects. Also, some users may want "Secure" storage (as seen various closed pull requests), and although this extension probably isn't intended to store sensitive information, some people might expect that and attempt to store sensitive information anyway.

I have been stalling on this because the dream is that users don't need to worry about where the data is stored; we have one extension that transparently does the right thing.

@TurboWarp/extension-reviewers I may need some assistance evaluating the practicality of this extensions

Also, to get this merged, it would need to comply with the contributing guidelines. There's a few things we need to clean up before that can happen. Additionally, it would be nice if you could disclose the extent to which LLMs assisted the development of this extension (if at all)

@GarboMuffin

Copy link
Copy Markdown
Member

It would be better to teach the local storage extension to switch to better backends that allow more storage instead

@GarboMuffin GarboMuffin closed this Jul 4, 2026
@Brackets-Coder

Copy link
Copy Markdown
Contributor

You mean like do a IndexedDB API backend for Local Storage?

@DNin01

DNin01 commented Jul 4, 2026

Copy link
Copy Markdown
Collaborator

It would be better to teach the local storage extension to switch to better backends that allow more storage instead

Like, with limits per project? Or a permission prompt for using more than a small amount of storage?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: new extension Pull requests that add a new extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.