Add IndexedDB Extension#1341
Conversation
|
Please don't close and open the PRs. Are you experiencing some kind of problem? |
Oh sh#t sorry, didn't know I shouldn't do that😅 |
Don't expect pull requests to be merged soon; GarboMuffin (TurboWarp's creator) has a job and mostly only is active here on weekends. |
OHHH! I THOUGHT ALL OF Y'ALL WHO COMMENT COULD TOTALLY MERGE IT AND JUST DIDN'T WANT TO 😅 |
ffghdfh
left a comment
There was a problem hiding this comment.
Changed what y'all asked for!
|
I worry that projects might abuse this to take up lots of storage on users' devices, and local storage is fine for the most common use cases. Does IndexedDB have any limits? |
https://developer.mozilla.org/en-US/docs/Web/API/Storage_API/Storage_quotas_and_eviction_criteria#other_web_technologies |
Updated IndexedDB extension with new features and improvements - Renamed "get value for key ()" to "get key ()" - Set all default block values to empty strings - Added "export db" reporter block to export the entire database as a JSON string - Added "import db from ()" command block to import and replace the database from a JSON string - Added "merge db from ()" command block to merge data from a JSON string without overwriting existing keys
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
ffghdfh
left a comment
There was a problem hiding this comment.
Lol this all makes sense and stuff thanks guys lol
btw i'm not even sure this is the version i use since i've been using the one I sumbitted here https://github.com/ffghdfh/lemons-gallery-ff/blob/main/extensions/golbo/IndexedDB.js
|
!format |
|
!format |
|
It worked! |
Yep, it did |
|
I have been stalling on this because the dream is that users don't need to worry about where the data is stored; we have one extension that transparently does the right thing. |
Dismissing old approvals so that moving forward everything follows #2327
|
@ffghdfh is this still being worked on? |
Nnnnope not really, it works fine enough I guess? feel free to poke at it if you'd like |
Mind you this was in 2024 and it still has not been merged yet |
Yes, I know this repository is notoriously slow. I'm doing my best to increase merge rates but to be honest we don't have the frameworks to keep the tap water flowing. As garbomuffin mentioned, any kind of "storage" extension becomes complicated, so I'll see what I can do to review later (I'm busy right now). Hopefully we can get this merged soon but I really can't say for sure :/ |
|
That's alright, thank you for your help though :D
…On Sun, 22 Feb 2026 at 19:14, Brackets-Coder ***@***.***> wrote:
*Brackets-Coder* left a comment (TurboWarp/extensions#1341)
<#1341 (comment)>
Mind you this was in 2024 and it still has not been merged yet
Yes, I know this repository is notoriously slow. I'm doing my best to
increase merge rates but to be honest we don't have the frameworks to keep
the tap water flowing.
As garbomuffin mentioned, any kind of "storage" extension becomes
complicated, so I'll see what I can do to review later (I'm busy right
now). Hopefully we can get this merged soon but I really can't say for sure
:/
—
Reply to this email directly, view it on GitHub
<#1341 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AW7BSMRCVITIBP5452AB3MT4NHWZVAVCNFSM6AAAAACVG7CWUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSNBRGQ3TCNBVHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
One of the optimizations we've been trying to do is consolidating duplicate PRs (see #2271). Since #2087 has been closed, this is the main storage extension pull request open right now. As mentioned before, I think persistent browser storage is a great idea (e.g., for save codes) but this has to be a seamless experience and have a standardized storage location to be a great user experience for projects. Also, some users may want "Secure" storage (as seen various closed pull requests), and although this extension probably isn't intended to store sensitive information, some people might expect that and attempt to store sensitive information anyway.
@TurboWarp/extension-reviewers I may need some assistance evaluating the practicality of this extensions Also, to get this merged, it would need to comply with the contributing guidelines. There's a few things we need to clean up before that can happen. Additionally, it would be nice if you could disclose the extent to which LLMs assisted the development of this extension (if at all) |
|
It would be better to teach the local storage extension to switch to better backends that allow more storage instead |
|
You mean like do a IndexedDB API backend for Local Storage? |
Like, with limits per project? Or a permission prompt for using more than a small amount of storage? |
lemme in please 🥺