assets: Update getSpriteValue to include target selection in sprite export#2561
assets: Update getSpriteValue to include target selection in sprite export#2561kanecoded wants to merge 4 commits into
getSpriteValue to include target selection in sprite export#2561Conversation
kanecoded
changed the title
getSpriteValue to include target selection in sprite export
github-actions
Bot
added
the
pr: change existing extension
|
You have to hide the old block and add your changes as a separate new block. You have to do this since you're mutating the block arguments, which will result in broken blocks for old projects using this |
Whoops, sorry. I'm working on that now. |
|
Fixed in commit |
|
The old blocks behaviour can just call the new one for simplicity but with the sprite hardcoded |
…ment for blocks to align with others
Fixed in commit |
| disableMonitor: true, | ||
| opcode: "getSpriteValue2", | ||
| blockType: Scratch.BlockType.REPORTER, | ||
| text: Scratch.translate("sprite [TARGET] [EXPORT]"), |
There was a problem hiding this comment.
the old string probably need to give translator context but this one even more so needs to do that
There was a problem hiding this comment.
Do you want me to resolve this conversation?
There was a problem hiding this comment.
no, that wasn't really what i meant
today: translators just see this
what is [EXPORT]? they have no idea from here. we're adding another completely ambiguous input. you should tell them what [TARGET] and [EXPORT] are. are they an input? are they an image? are they a dropdown? what's in that dropdown? context matters
There was a problem hiding this comment.
for best results email thomas@turbowarp.org to get a quick review once you've addressed that
|
can you disclose to what extent you wrote anything here vs. claude writing everything here? you're not in trouble. it's actually pretty ok at it. but we would like to know |
These changes were made with Google Gemini 3.1 Pro, however all changes were manually tested by me, and I understand how the new code works. Some of the quick fixes were manually made by me. |
|
Just checking in to see if there is anything else I need to adjust here! |
3 participants
Adds a new target identifier in the "sprite [name/dataURI]" reporter block, to allow one sprite to query other sprites' names or data URIs.