turf.disolve crashes

[jim-greene-l2]

turftest2.zip

Please see the enclosed turftest2.js program that using turf 7.2 generates the following output when calling turf.dissolve. Since there is a crash and no error, we could really use a fix or work around to apply. Prior to the dissolve, I am already doing fc = turf.truncate(fc, {precision: 6, mutate:true});

BEFORE
<--- Last few GCs --->

[1540546:0x5560efef6a80] 501159 ms: Mark-Compact 4017.9 (4128.7) -> 4002.3 (4129.0) MB, 1085.24 / 0.00 ms (average mu = 0.099, current mu = 0.014) allocation failure; scavenge might not succeed
[1540546:0x5560efef6a80] 502118 ms: Mark-Compact 4018.2 (4129.0) -> 4002.4 (4129.0) MB, 938.41 / 0.00 ms (average mu = 0.063, current mu = 0.021) allocation failure; scavenge might not succeed

<--- JS stacktrace --->

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
----- Native stack trace -----

1: 0x5560ec6bd79a [node]
2: 0x5560eca8bda4 v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, v8::OOMDetails const&) [node]
3: 0x5560eca8c065 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, v8::OOMDetails const&) [node]
4: 0x5560ecc81fbb [node]
5: 0x5560ecc894fc [node]
6: 0x5560ecc9c480 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::internal::GarbageCollectionReason, char const*) [node]
7: 0x5560ecc9cfb5 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
8: 0x5560ecc78451 v8::internal::HeapAllocator::AllocateRawWithLightRetrySlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [node]
9: 0x5560ecc7954a v8::internal::HeapAllocator::AllocateRawWithRetryOrFailSlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [node]
10: 0x5560ecc5af72 v8::internal::Factory::NewFillerObject(int, v8::internal::AllocationAlignment, v8::internal::AllocationType, v8::internal::AllocationOrigin) [node]
11: 0x5560ed04fc79 v8::internal::Runtime_AllocateInYoungGeneration(int, unsigned long*, v8::internal::Isolate*) [node]
12: 0x55608d419ef6
Aborted (core dumped)

[jim-greene-l2]

I was able to workaround this by truncating to precision 5.

[jim-greene-l2]

turftest.zip

A new example where truncating to precision 5 does not help as the test runs out of memory.
So, now I'm stuck without a work-around on this one. Please help!

/usr/local/bin/node /Users/jimgreene/work/l2/vm/turftest.js
BEFORE 1
BEFORE 2

<--- Last few GCs --->

[26162:0x128008000] 366570 ms: Mark-Compact 4043.4 (4129.1) -> 4027.8 (4129.1) MB, 480.71 / 0.00 ms (average mu = 0.134, current mu = 0.014) allocation failure; scavenge might not succeed
[26162:0x128008000] 367345 ms: Mark-Compact 4043.5 (4129.1) -> 4027.9 (4129.3) MB, 766.33 / 0.00 ms (average mu = 0.061, current mu = 0.010) allocation failure; scavenge might not succeed

<--- JS stacktrace --->

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
----- Native stack trace -----

1: 0x104696c4c node::OOMErrorHandler(char const*, v8::OOMDetails const&) [/usr/local/bin/node]
2: 0x104856440 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, v8::OOMDetails const&) [/usr/local/bin/node]
3: 0x104a61e7c v8::internal::Heap::GarbageCollectionReasonToString(v8::internal::GarbageCollectionReason) [/usr/local/bin/node]
4: 0x104a65978 v8::internal::Heap::CollectGarbageShared(v8::internal::LocalHeap*, v8::internal::GarbageCollectionReason) [/usr/local/bin/node]
5: 0x104a627f4 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::internal::GarbageCollectionReason, char const*) [/usr/local/bin/node]
6: 0x104a60370 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [/usr/local/bin/node]
7: 0x104a56680 v8::internal::HeapAllocator::AllocateRawWithLightRetrySlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [/usr/local/bin/node]
8: 0x104a56ed8 v8::internal::HeapAllocator::AllocateRawWithRetryOrFailSlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [/usr/local/bin/node]
9: 0x104a3b3b4 v8::internal::Factory::NewFillerObject(int, v8::internal::AllocationAlignment, v8::internal::AllocationType, v8::internal::AllocationOrigin) [/usr/local/bin/node]
10: 0x104e476b8 v8::internal::Runtime_AllocateInYoungGeneration(int, unsigned long*, v8::internal::Isolate*) [/usr/local/bin/node]
11: 0x1051d8c44 Builtins_CEntry_Return1_ArgvOnStack_NoBuiltinExit [/usr/local/bin/node]
12: 0x1051528a8 Builtins_GrowFastSmiOrObjectElements [/usr/local/bin/node]
13: 0x109d4b3b8
14: 0x109d660d4
15: 0x109d69d3c
16: 0x1051503e4 Builtins_InterpreterEntryTrampoline [/usr/local/bin/node]
17: 0x1051503e4 Builtins_InterpreterEntryTrampoline [/usr/local/bin/node]
18: 0x1051503e4 Builtins_InterpreterEntryTrampoline [/usr/local/bin/node]
19: 0x1051503e4 Builtins_InterpreterEntryTrampoline [/usr/local/bin/node]
20: 0x1051503e4 Builtins_InterpreterEntryTrampoline [/usr/local/bin/node]
21: 0x1051503e4 Builtins_InterpreterEntryTrampoline [/usr/local/bin/node]
22: 0x1051503e4 Builtins_InterpreterEntryTrampoline [/usr/local/bin/node]
23: 0x1051503e4 Builtins_InterpreterEntryTrampoline [/usr/local/bin/node]
24: 0x1051503e4 Builtins_InterpreterEntryTrampoline [/usr/local/bin/node]
25: 0x10514e50c Builtins_JSEntryTrampoline [/usr/local/bin/node]
26: 0x10514e1f4 Builtins_JSEntry [/usr/local/bin/node]
27: 0x1049cd8d4 v8::internal::(anonymous namespace)::Invoke(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) [/usr/local/bin/node]
28: 0x1049cd168 v8::internal::Execution::Call(v8::internal::Isolate*, v8::internal::Handlev8::internal::Object, v8::internal::Handlev8::internal::Object, int, v8::internal::Handlev8::internal::Object) [/usr/local/bin/node]
29: 0x104872478 v8::Function::Call(v8::Localv8::Context, v8::Localv8::Value, int, v8::Localv8::Value) [/usr/local/bin/node]
30: 0x1046742b4 node::builtins::BuiltinLoader::CompileAndCall(v8::Localv8::Context, char const*, node::Realm*) [/usr/local/bin/node]
31: 0x104717d44 node::Realm::ExecuteBootstrapper(char const*) [/usr/local/bin/node]
32: 0x104654cd0 node::StartExecution(node::Environment*, char const*) [/usr/local/bin/node]
33: 0x104654be4 node::StartExecution(node::Environment*, std::__1::function<v8::MaybeLocalv8::Value (node::StartExecutionCallbackInfo const&)>) [/usr/local/bin/node]
34: 0x1045b1784 node::LoadEnvironment(node::Environment*, std::__1::function<v8::MaybeLocalv8::Value (node::StartExecutionCallbackInfo const&)>, std::__1::function<void (node::Environment*, v8::Localv8::Value, v8::Localv8::Value)>) [/usr/local/bin/node]
35: 0x1046da2d0 node::NodeMainInstance::Run(node::ExitCode*, node::Environment*) [/usr/local/bin/node]
36: 0x1046da040 node::NodeMainInstance::Run() [/usr/local/bin/node]
37: 0x104657c28 node::Start(int, char**) [/usr/local/bin/node]
38: 0x19b5fc274 start [/usr/lib/dyld]

Process finished with exit code 134 (interrupted by signal 6:SIGABRT)

[smallsaucepan]

Hi @jim-greene-l2. Took a look at this and it's probably very similar to your other dissolve issue #2832.

Had a thought about working around in a similar fashion, except adding precision instead of truncating it. I found by adding a tiny delta to each coord the loop doesn't get stuck:

  coordEach(fc, (curr) => {
    curr[0] = curr[0] + 0.000000000001;
    curr[1] = curr[1] + 0.000000000001;
  });

Your mileage may vary. It does change the output slightly compared to truncating. If a fixed value doesn't work for you, maybe add a tiny random amount, though that might unacceptably change your outputs.

Will try to get a minimal reproducible example and see if we can fix it upstream in polyclip-ts. Hopefully this technique (or a variation thereof) can keep you going for the time being.

[smallsaucepan]

Similarly to #2832, once #2997 is merged, we can see if using the @turf/union in @turf/dissolve fixes this problem as well.