Migrate @turf/buffer to TypeScript, ignoring errors

[mfedderly]

I'd like to do this more properly, but that will require a major version release.

In the meantime, we can do a low-effort job that gets us migrated away from Javascript-first packages and consolidate on TypeScript instead to simplify some of the build tooling.

[smallsaucepan]

Thanks @mfedderly. One more hurdle down.

[plymer]

Hey, this is a fantastic effort. I know the plan is to move away from jsts, but any chance that in the meantime #2937 could get rolled into this update? I'd be happy to re-do the PR in whatever typescript file comes out of your work 🙂

[mfedderly]

@plymer I'm trying to focus on #2991 instead of this, and I'm hesitating to expose these configurations until we know we're settled on a library that does provide this. But I am intending to add this eventually.

Unfortunately I'm less convinced that clipper2-ts is a library we want to depend on going forward, so I might go and port clipper2 from scratch myself before we can land that.

[plymer]

Cheers, I appreciate the update and the roadmap ❤️

[bratter]

Is your lack of desire to use clipper2 as-is an ergonomics/efficiency thing with all the transformation?

[mfedderly]

Sadly no, I have concerns about accuracy past Number.MAX_SAFE_INTEGER, and after some rounds of issues/pr's in that repo I'm not sure its reliable enough to bring on as a dependency for us.

[smallsaucepan]

Converting to draft as it's likely we'll favour #2991 instead

[mfedderly]

Going to officially close in favor of #2991

[mfedderly]

#2991 actually requires a breaking API change (steps -> arcTolerance), so for v7 we probably just need to do this to unblock some other infrastructure work we'd like to do (this is the last javascript-first package, everything else is TypeScript).

[plymer]

Hey there, is the feeling still that you want to hold off exposing the jsts endCapStyles? I recognize that you intend for breaking changes and might have a different API surface planned.

I'd still be happy to port my PR to your TypeScript implementation if you think it would be alright in the interim but totally understandable if you'd prefer not to go that route.

[mfedderly]

Unfortunately we can't merge #2991 because of the breaking api change involved with the exposed implementation detail of steps, which is not supported in geoclipper2 (it uses arcTolerance instead and there isn't a real way to map between the two as far as I know). So the new buffer implementation is stuck waiting for a major version (no ETA), and I'm reluctant to change the current version because I don't want to add another breaking change.

Sorry I know this is unfortunate @plymer

[plymer]

Ah no worries! I very much appreciate all the work going on here... it's made my job much simpler and I'm still rocking the patch I made for this niche case :)