Conversation
mfedderly
commented
Apr 21, 2026
mfedderly
commented
Apr 23, 2026
| pnpm --recursive exec npm version "$VERSION" --no-git-tag-version | ||
| git add . | ||
| git commit --no-verify -m "v$VERSION" | ||
| git tag -a "v$VERSION" -m "v$VERSION" |
Collaborator
Author
There was a problem hiding this comment.
We don't have any automation but this (entire file) also passes over at https://www.shellcheck.net/
mfedderly
commented
Apr 23, 2026
|
|
||
| - increment the version number of all packages, and create a local commit, without pushing to origin. This will also create a release tag. | ||
| - `pnpm lerna version --no-commit-hooks --no-push 7.0.0` | ||
| - `./scripts/version.sh 7.0.0` |
Collaborator
Author
There was a problem hiding this comment.
Perhaps it isn't too late to get pnpm@11 to implement some more changes to the version command, so I filed a ticket over there and maybe we can throw away this version script eventually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the Lerna dependency entirely.
This loses any benefit of Lerna's task caching, but it does drop a massive number of dependencies that have tended to pop up Dependabot warnings for us.
It required replacing the
lerna versionstep, which doesn't seem to have a proper replacement with thepnpm, so I just LLM'd a script to replace the package.json versions and do the git operations.The prerelease script was already not working (the new publish lockdowns), so instead of migrating its publish step I just got rid of it.