Migrate bench/test for area, bbox-clip, bezier-spline, and buffer#3059
Draft
Migrate bench/test for area, bbox-clip, bezier-spline, and buffer#3059
Conversation
mfedderly
commented
May 2, 2026
| !VALID_TYPES.has(result.type) | ||
| ) { | ||
| outputPath = outputPath.replace(/\.geojson$/, ".json"); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
area() actually just returns a number, so it makes sense to have test/out/*.json and not .geojson.
Collaborator
Author
|
The build is failing here because node@18 doesn't support working against TypeScript files directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues the path set forth in #3038 for a few more packages.
testFixturesis extended to handle non-geojson return values as wellnode --testexecution totest.tsonly, which avoid conflicts in packages with tstyche type testingSide notes that I discovered while working on this:
colorizegets implemented in many different test.ts files. Consolidating this is out of scope for this push because they're slightly differenttrueandfalsetest subdirectories. Perhaps this is just a different test runnerDepends on #3061