Fix boolean-disjoint missing overlapping collinear lines#3097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
boolean-disjoint leans on lineIntersect to decide whether two lines touch, but lineIntersect only returns points where segments actually cross, so two collinear lines lying on top of each other come back as disjoint when they aren't.
I added a check for whether a vertex of either line falls on the other line. That covers the overlap case, since an overlapping interval always has an endpoint that is a vertex of one of the lines, and it leaves genuinely parallel, non-touching lines disjoint as before.
Added a regression fixture under test/false for two overlapping collinear lines. No breaking change.
Resolves #1842