Make last-checks tests less strict about @turf/helpers devDependencies#3105
Merged
Conversation
It is possible to have a Turf module that only uses @turf/helpers in dev code (#3011). This loosens the check in last-checks to allow helpers to be a devDependency only if it is not used in code that winds up in the dist. The check itself is a little sloppy (we check cjs for import statements, and we check using just raw string operations instead of parsing). In v8 we will only be shipping esm code though, and this is just a CI-time issue so we can always re-work the check later if we really need to move to a proper parser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is possible to have a Turf module that only uses @turf/helpers in dev code (#3011). This loosens the check in last-checks to allow helpers to be a devDependency only if it is not used in code that winds up in the dist.
The check itself is a little sloppy (we check cjs for import statements, and we check using just raw string operations instead of parsing). In v8 we will only be shipping esm code though, and this is just a CI-time issue so we can always re-work the check later if we really need to move to a proper parser.