transform-scale, transform-translate, transform-rotate: Invalidate stale bboxes after coordinate transforms#3106
Merged
mfedderly merged 3 commits intoJul 24, 2026
Conversation
Collaborator
|
(👍 for the recursive approach here) |
mfedderly
reviewed
Jul 23, 2026
Contributor
Author
|
Thanks for the feedback. I moved |
khalilurrrahmanridoykhan
marked this pull request as ready for review
July 23, 2026 18:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
bboxvalues aftertransformTranslateandtransformRotatetransformScalemutate: trueWhy
Coordinate transforms mutate positions but previously retained cached bounding boxes at one or more levels of the GeoJSON hierarchy. A later bbox lookup could therefore return coordinates describing the pre-transform object. Invalidating those cached values lets callers explicitly recompute them when needed.
Validation
pnpm --filter @turf/transform-translate test— 29 passedpnpm --filter @turf/transform-rotate test— 25 passedpnpm --filter @turf/transform-scale test— 54 passedgit diff --checkCloses #2835