Skip to content

Commit e99816d

Browse files
committed
Cleanup target processing
1 parent 58e541e commit e99816d

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

src/TurnerSoftware.BuildVersioning.Tool/TurnerSoftware.BuildVersioning.Tool.csproj

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,8 @@
1010
</PropertyGroup>
1111

1212
<PropertyGroup>
13-
<BuildVersioningToolPath>bin/$(Configuration)/$(TargetFramework)/TurnerSoftware.BuildVersioning.Tool.dll</BuildVersioningToolPath>
13+
<BuildVersioningToolPath>$(MSBuildThisFileDirectory)bin/$(Configuration)/$(TargetFramework)/TurnerSoftware.BuildVersioning.Tool.dll</BuildVersioningToolPath>
1414
<SelfHostedBuildVersioning Condition="$(DesignTimeBuild) != 'true' AND $(SkipBuildVersioning) != 'true'">true</SelfHostedBuildVersioning>
15-
<BuildVersioningToolPath>../../TurnerSoftware.BuildVersioning.Tool/$(BuildVersioningToolPath)</BuildVersioningToolPath>
1615
</PropertyGroup>
1716

1817
<ItemGroup>

src/TurnerSoftware.BuildVersioning/TurnerSoftware.BuildVersioning.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
</PropertyGroup>
1212

1313
<PropertyGroup>
14-
<BuildVersioningToolPath>../../TurnerSoftware.BuildVersioning.Tool/bin/$(Configuration)/$(TargetFramework)/TurnerSoftware.BuildVersioning.Tool.dll</BuildVersioningToolPath>
14+
<BuildVersioningToolPath>$(MSBuildThisFileDirectory)../TurnerSoftware.BuildVersioning.Tool/bin/$(Configuration)/$(TargetFramework)/TurnerSoftware.BuildVersioning.Tool.dll</BuildVersioningToolPath>
1515
</PropertyGroup>
1616

1717
<Import Project="build/TurnerSoftware.BuildVersioning.targets" />

src/TurnerSoftware.BuildVersioning/build/TurnerSoftware.BuildVersioning.targets

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
</PropertyGroup>
1010

1111
<PropertyGroup>
12-
<BuildVersioningToolPath Condition="$(BuildVersioningToolPath) == ''">../Tools/TurnerSoftware.BuildVersioning.Tool.dll</BuildVersioningToolPath>
12+
<BuildVersioningToolPath Condition="$(BuildVersioningToolPath) == ''">$(MSBuildThisFileDirectory)../Tools/TurnerSoftware.BuildVersioning.Tool.dll</BuildVersioningToolPath>
1313
<BuildFullVersionFormat Condition="$(BuildFullVersionFormat) == ''">{Major}.{Minor}.{Patch}{PreRelease}{BuildMetadata}</BuildFullVersionFormat>
1414
<BuildFileVersionFormat Condition="$(BuildFileVersionFormat) == ''">{Major}.{Minor}.{Patch}.0</BuildFileVersionFormat>
1515
<BuildAssemblyVersionFormat Condition="$(BuildAssemblyVersionFormat) == ''">{Major}.0.0.0</BuildAssemblyVersionFormat>
@@ -21,11 +21,11 @@
2121
<Import Project="TurnerSoftware.BuildVersioning.Integrations.targets" />
2222

2323
<Target Name="BuildVersioning"
24-
BeforeTargets="BeforeCompile;CoreCompile;GenerateNuspec"
25-
DependsOnTargets="PrepareForBuild;CoreGenerateAssemblyInfo"
26-
Condition="'$(DesignTimeBuild)' != 'true' AND '$(SkipBuildVersioning)' != 'true'">
24+
BeforeTargets="BeforeCompile;GenerateNuspec"
25+
Condition="$(DesignTimeBuild) != 'true' AND $(SkipBuildVersioning) != 'true'">
2726
<Error Condition="'$(UsingMicrosoftNETSdk)' != 'true'" Code="BLDVER0001" Text="Build Versioning only works in SDK-style projects." />
2827
<Message Importance="$(BuildVersioningLogLevel)" Text="BuildVersioning: Project=$(MSBuildProjectFile)" />
28+
<Message Importance="$(BuildVersioningLogLevel)" Text="BuildVersioning: BuildVersioningToolPath=$(BuildVersioningToolPath)" />
2929
<Message Importance="$(BuildVersioningLogLevel)" Text="BuildVersioning: FullVersionFormat=$(BuildFullVersionFormat)" />
3030
<Message Importance="$(BuildVersioningLogLevel)" Text="BuildVersioning: FileVersionFormat=$(BuildFileVersionFormat)" />
3131
<Message Importance="$(BuildVersioningLogLevel)" Text="BuildVersioning: AssemblyVersionFormat=$(BuildAssemblyVersionFormat)" />
@@ -38,7 +38,7 @@
3838
<BuildVersioningInputs Condition="$(BuildPreReleaseFormat) != ''" Include="--prerelease-format &quot;$(BuildPreReleaseFormat)&quot;" />
3939
<BuildVersioningInputs Condition="$(BuildMetadataFormat) != ''" Include="--build-metadata-format &quot;$(BuildMetadataFormat)&quot;" />
4040
</ItemGroup>
41-
<Exec Command="dotnet &quot;$(MSBuildThisFileDirectory)$(BuildVersioningToolPath)&quot; @(BuildVersioningInputs->'%(Identity)', ' ')" ConsoleToMSBuild="true" StandardOutputImportance="Low" ContinueOnError="true">
41+
<Exec Command="dotnet &quot;$(BuildVersioningToolPath)&quot; @(BuildVersioningInputs->'%(Identity)', ' ')" ConsoleToMSBuild="true" StandardOutputImportance="Low" ContinueOnError="true">
4242
<Output TaskParameter="ConsoleOutput" PropertyName="BuildVersioningOutput" />
4343
<Output TaskParameter="ExitCode" PropertyName="BuildVersioningErrorCode"/>
4444
</Exec>

0 commit comments

Comments
 (0)