Additional error information from Redis for tests

Author: Turnerj

tests/CacheTower.Tests/Extensions/Redis/RedisLockExtensionTests.cs

@@ -41,7 +41,7 @@ public void ThrowForRegisteringTwoCacheStacks()
 		[TestMethod]
 		public async Task CustomLockTimeout()
 		{
-			RedisHelper.FlushDatabase();
+			RedisHelper.ResetState();
 
 			var extension = new RedisLockExtension(RedisHelper.GetConnection(), new RedisLockOptions(lockTimeout: TimeSpan.FromDays(1)));
 			var refreshWaiterTask = new TaskCompletionSource<bool>();
@@ -76,7 +76,7 @@ public async Task CustomLockTimeout()
 		[TestMethod]
 		public async Task RefreshValueNotifiesChannelSubscribers()
 		{
-			RedisHelper.FlushDatabase();
+			RedisHelper.ResetState();
 
 			var connection = RedisHelper.GetConnection();
 
@@ -117,7 +117,7 @@ await extension.WithRefreshAsync("TestKey",
 		[TestMethod]
 		public async Task ObservedLockSingle()
 		{
-			RedisHelper.FlushDatabase();
+			RedisHelper.ResetState();
 
 			var connection = RedisHelper.GetConnection();
 
@@ -160,7 +160,7 @@ public async Task ObservedLockSingle()
 		[TestMethod]
 		public async Task ObservedLockMultiple()
 		{
-			RedisHelper.FlushDatabase();
+			RedisHelper.ResetState();
 
 			var connection = RedisHelper.GetConnection();
 

tests/CacheTower.Tests/Extensions/Redis/RedisRemoteEvictionExtensionTests.cs

@@ -45,7 +45,7 @@ public void ThrowForRegisteringMoreThanOneCacheStack()
 		[TestMethod]
 		public async Task RemoteEvictionOccursOnRefresh()
 		{
-			RedisHelper.FlushDatabase();
+			RedisHelper.ResetState();
 
 			var connection = RedisHelper.GetConnection();
 
@@ -88,7 +88,7 @@ public async Task RemoteEvictionOccursOnRefresh()
 		[TestMethod]
 		public async Task RemoteEvictionOccursOnLocalEviction()
 		{
-			RedisHelper.FlushDatabase();
+			RedisHelper.ResetState();
 
 			var connection = RedisHelper.GetConnection();
 
@@ -135,7 +135,7 @@ public async Task RemoteEvictionOccursOnLocalEviction()
 		[TestMethod]
 		public async Task RemoteFlush()
 		{
-			RedisHelper.FlushDatabase();
+			RedisHelper.ResetState();
 
 			var connection = RedisHelper.GetConnection();
 
@@ -182,7 +182,7 @@ public async Task RemoteFlush()
 		[TestMethod]
 		public async Task NoEvictionOnNewEntries()
 		{
-			RedisHelper.FlushDatabase();
+			RedisHelper.ResetState();
 
 			var realConnection = RedisHelper.GetConnection();
 

tests/CacheTower.Tests/Providers/Redis/RedisCacheLayerTests.cs

@@ -17,7 +17,7 @@ public class RedisCacheLayerTests : BaseCacheLayerTests
 		[TestInitialize]
 		public void Setup()
 		{
-			RedisHelper.FlushDatabase();
+			RedisHelper.ResetState();
 		}
 
 		[TestMethod]

tests/CacheTower.Tests/Utils/RedisHelper.cs

@@ -1,8 +1,6 @@
 using System;
-using System.Collections.Generic;
+using System.Collections.Concurrent;
 using System.Diagnostics;
-using System.Text;
-using System.Threading.Tasks;
 using StackExchange.Redis;
 
 namespace CacheTower.Tests.Utils
@@ -11,6 +9,24 @@ public static class RedisHelper
 	{
 		public static string Endpoint => Environment.GetEnvironmentVariable("REDIS_ENDPOINT") ?? "localhost:6379";
 
+		private static readonly ConcurrentQueue<string> Errors = new();
+
+		static RedisHelper()
+		{
+			var connection = GetConnection();
+			connection.ErrorMessage += (sender, args) =>
+			{
+				Errors.Enqueue(args.Message);
+			};
+			connection.InternalError += (sender, args) =>
+			{
+				if (args.Exception is not null)
+				{
+					Errors.Enqueue(args.Exception.Message);
+				}
+			};
+		}
+
 		public static ConnectionMultiplexer GetConnection()
 		{
 			var config = new ConfigurationOptions
@@ -21,15 +37,33 @@ public static ConnectionMultiplexer GetConnection()
 			return ConnectionMultiplexer.Connect(config);
 		}
 
-		public static void FlushDatabase()
+		/// <summary>
+		/// Flushes Redis and resets the state of error logging
+		/// </summary>
+		public static void ResetState()
 		{
 			GetConnection().GetServer(Endpoint).FlushDatabase();
+			
+			//.NET Framework doesn't support `Clear()` on Errors so we do it manually
+			while (!Errors.IsEmpty)
+			{
+				Errors.TryDequeue(out _);
+			}
 		}
 
 		public static void DebugInfo(IConnectionMultiplexer connection)
 		{
+			Debug.WriteLine("== Redis Connection Status ==");
 			Debug.WriteLine(connection.GetStatus());
-			Debug.WriteLine(connection.GetCounters().ToString());
+
+			Debug.WriteLine("== Errors (Redis and Internal) ==");
+			while (!Errors.IsEmpty)
+			{
+				if (Errors.TryDequeue(out var message))
+				{
+					Debug.WriteLine(message);
+				}
+			}
 		}
 	}
 }