Skip to content

Commit 9a3187d

Browse files
authored
Merge pull request #3 from TurtIeSocks/reduce-state-complexity
refactor: reduce state complexity
2 parents d3956e5 + 97e4377 commit 9a3187d

3 files changed

Lines changed: 16 additions & 23 deletions

File tree

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-leaflet-supercluster",
3-
"version": "0.1.2",
3+
"version": "0.1.3",
44
"description": "React wrapper for the supercluster library",
55
"repository": "https://github.com/TurtIeSocks/react-leaflet-supercluster",
66
"author": "TurtIeSocks <58572875+TurtIeSocks@users.noreply.github.com>",

src/SuperClustering.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,5 @@ export function SuperClustering({
7777
disableZoomEvent,
7878
])
7979

80-
return superCluster
81-
? normalizedChildren.filter((x, i) => markerFilter(x, i, markers))
82-
: normalizedChildren
80+
return normalizedChildren.filter((x, i) => markerFilter(x, i, markers))
8381
}

src/useSuperClustering.ts

Lines changed: 14 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -16,19 +16,20 @@ export function useSuperClustering({
1616
}: Options<GeoJsonProperties, GeoJsonProperties>): InstanceType<
1717
typeof Supercluster
1818
> {
19-
const options = useMemo(
20-
() => ({
21-
minPoints,
22-
minZoom,
23-
maxZoom,
24-
extent,
25-
generateId,
26-
log,
27-
map,
28-
nodeSize,
29-
radius,
30-
reduce,
31-
}),
19+
const superCluster = useMemo(
20+
() =>
21+
new Supercluster({
22+
minPoints,
23+
minZoom,
24+
maxZoom,
25+
extent,
26+
generateId,
27+
log,
28+
map,
29+
nodeSize,
30+
radius,
31+
reduce,
32+
}),
3233
[
3334
minPoints,
3435
minZoom,
@@ -42,11 +43,5 @@ export function useSuperClustering({
4243
reduce,
4344
]
4445
)
45-
const [superCluster, setSuperCluster] = useState(new Supercluster(options))
46-
47-
useEffect(() => {
48-
setSuperCluster(new Supercluster(options))
49-
}, [options])
50-
5146
return superCluster
5247
}

0 commit comments

Comments
 (0)