Improve accessibility and security in project grid#2068
Open
PankajSingh34 wants to merge 1 commit into
Open
Conversation
Removed unused FontAwesome CDN from index.html. Enhanced script.js by adding lazy loading and descriptive alt text to project images, and improved accessibility and security for project and GitHub links with rel and aria-label attributes.
👷 Deploy Preview for frontendprojects processing.
|
There was a problem hiding this comment.
Pull request overview
This pull request enhances accessibility and security for the project grid display while removing an unused duplicate FontAwesome CDN link. The changes implement lazy loading for performance optimization and add proper ARIA labels and security attributes to external links.
Changes:
- Removed duplicate FontAwesome CDN script from index.html
- Added lazy loading and descriptive alt text to project images
- Enhanced link security with rel="noopener noreferrer" attributes
- Improved accessibility with aria-label attributes for icon-only links
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| index.html | Removed duplicate FontAwesome CDN script that was redundant with the existing CDN link in the head section |
| script.js | Added lazy loading and alt text to project images, implemented rel and aria-label attributes for project and GitHub links, and applied consistent code formatting throughout |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| let progressValue=document.getElementById('progress-value'); | ||
| function calculateScrollValue() { | ||
| let scrollProgress = document.getElementById("progress"); | ||
| let progressValue = document.getElementById("progress-value"); |
There was a problem hiding this comment.
Unused variable progressValue.
Suggested change
| let progressValue = document.getElementById("progress-value"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed unused FontAwesome CDN from index.html. Enhanced script.js by adding lazy loading and descriptive alt text to project images, and improved accessibility and security for project and GitHub links with rel and aria-label attributes.
🛠️ Issue (Number)
Closes #
Description
Please include a summary of the change. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Checklist:
ATTACH SCREEN-SHOTS / DEPLOYMENT LINK