fix: medium priority bug fixes

- Fix gorhom#2640: INITIAL_POSITION now uses Math.max(SCREEN_HEIGHT, WINDOW_HEIGHT) to handle web viewport resizing
- Fix gorhom#2533: Account for scrollableContentOffsetY when calculating destinationPoint to fix scroll jumpy issue; change map to forEach for biome compliance

Author: TwanLuttik

src/components/bottomSheet/constants.ts

@@ -3,6 +3,7 @@ import {
   KEYBOARD_BLUR_BEHAVIOR,
   KEYBOARD_INPUT_MODE,
   SCREEN_HEIGHT,
+  WINDOW_HEIGHT,
 } from '../../constants';
 
 // default values
@@ -31,7 +32,7 @@ const INITIAL_CONTAINER_OFFSET = {
   right: 0,
 };
 const INITIAL_HANDLE_HEIGHT = -999;
-const INITIAL_POSITION = SCREEN_HEIGHT;
+const INITIAL_POSITION = Math.max(SCREEN_HEIGHT, WINDOW_HEIGHT);
 
 // accessibility
 const DEFAULT_ACCESSIBLE = true;

src/hooks/useGestureEventsHandlersDefault.tsx

@@ -33,10 +33,9 @@ const INITIAL_CONTEXT: GestureEventContextType = {
 
 const dismissKeyboard = Keyboard.dismiss;
 
-// biome-ignore lint: to be addressed!
 const resetContext = (context: any) => {
   'worklet';
-  Object.keys(context).map(key => {
+  Object.keys(context).forEach(key => {
     context[key] = undefined;
   });
 };
@@ -341,11 +340,22 @@ export const useGestureEventsHandlersDefault: GestureEventsHandlersHookType =
           snapPoints.unshift(animatedClosedPosition.value);
         }
 
+        const wasGestureHandledByScrollView =
+          source === GESTURE_SOURCE.CONTENT &&
+          animatedScrollableContentOffsetY.value > 0;
+
+        let rawDestinationPosition =
+          translationY + context.value.initialPosition;
+
+        if (wasGestureHandledByScrollView) {
+          rawDestinationPosition -= animatedScrollableContentOffsetY.value;
+        }
+
         /**
          * calculate the destination point, using redash.
          */
         const destinationPoint = snapPoint(
-          translationY + context.value.initialPosition,
+          rawDestinationPosition,
           velocityY,
           snapPoints
         );
@@ -358,9 +368,6 @@ export const useGestureEventsHandlersDefault: GestureEventsHandlersHookType =
           return;
         }
 
-        const wasGestureHandledByScrollView =
-          source === GESTURE_SOURCE.CONTENT &&
-          animatedScrollableContentOffsetY.value > 0;
         /**
          * prevents snapping from top to middle / bottom with repeated interrupted scrolls
          */