Refactor SimpleEAFReasoners and Bugfixes

Author: sandra-hoffmann

org-tweetyproject-arg-eaf/src/main/java/org/tweetyproject/arg/eaf/examples/EAFAgreementReasonerExample.java

@@ -49,8 +49,11 @@ public static void main(String[] args) throws Exception {
 
 		String constEAF1 = "[](in(a))";
 		String constEAF2 = "[](und(a))";
+	
+		
 		EpistemicArgumentationFramework eaf1 = new EpistemicArgumentationFramework(af, constEAF1);
-		EpistemicArgumentationFramework eaf2 = new EpistemicArgumentationFramework(af, constEAF2);	
+		EpistemicArgumentationFramework eaf2 = new EpistemicArgumentationFramework(af, constEAF2);
+
 
 		EAFAgreementReasoner agreementReasoner = new EAFAgreementReasoner(eaf1);
 

org-tweetyproject-arg-eaf/src/main/java/org/tweetyproject/arg/eaf/examples/EafReasonerExample.java

@@ -112,6 +112,8 @@ public static void main(String[] args) throws ParserException, IOException {
 
 		System.out.println("\n\nSimple Reasoners for different semantics can be used to find extensions, that satisfy the underlying constraint of an EAF.");
 		System.out.println("Note that Reasoners do not return epistemic labelling sets.");
+		
+
 		//Reasoners can be created using the abstract superclass
 		AbstractEAFReasoner eafReasoner = AbstractEAFReasoner.getSimpleReasonerForSemantics(EAFSemantics.EAF_PR);
 		//Or by instantiating a reasoner for the required semantics

org-tweetyproject-arg-eaf/src/main/java/org/tweetyproject/arg/eaf/reasoner/AbstractEAFReasoner.java

@@ -19,9 +19,13 @@
 package org.tweetyproject.arg.eaf.reasoner;
 
 import java.util.Collection;
+import java.util.HashSet;
 
+import org.tweetyproject.arg.dung.reasoner.AbstractExtensionReasoner;
 import org.tweetyproject.arg.dung.semantics.Extension;
+import org.tweetyproject.arg.dung.semantics.Semantics;
 import org.tweetyproject.arg.dung.syntax.Argument;
+import org.tweetyproject.arg.dung.syntax.DungTheory;
 import org.tweetyproject.arg.eaf.semantics.EAFSemantics;
 import org.tweetyproject.arg.eaf.syntax.EpistemicArgumentationFramework;
 import org.tweetyproject.commons.InferenceMode;
@@ -85,6 +89,51 @@ public static AbstractEAFReasoner getSimpleReasonerForSemantics(EAFSemantics sem
             default -> throw new IllegalArgumentException("Unknown semantics.");
         };
     }
+    
+	/**
+	 * Computes all admissible extensions that satisfy the epistemic constraint of the EAF for the specified semantics.
+	 * 
+	 * @param bbase the epistemic argumentation framework
+	 * @param semantics the desired semantics
+	 * @return A collection of all admissible extensions that satisfy the constraint.
+	 */
+	public Collection<Extension<EpistemicArgumentationFramework>> getModels(EpistemicArgumentationFramework bbase, Semantics semantics) {
+		//get all admissible Sets of the underlying DungTheory
+		AbstractExtensionReasoner dungReasoner = AbstractExtensionReasoner.getSimpleReasonerForSemantics(semantics);
+		Collection<Extension<DungTheory>> semExtensions = dungReasoner.getModels(bbase);
+		Collection<Extension<EpistemicArgumentationFramework>> eafSemExtensions = new HashSet<>();
+		
+		//find sets that satisfy the constraint
+		for (Extension<DungTheory> semSet : semExtensions) {
+			 Extension<EpistemicArgumentationFramework> eafExtension = new Extension<>();
+			 eafExtension.addAll(semSet);
+			 if (bbase.satisfiesConstraint(semSet)) eafSemExtensions.add(eafExtension);
+		}
+		return eafSemExtensions;
+	}
+
+	/**
+	 * Computes one extension that satisfies the epistemic constraint of the EAF for the specified semantics.
+	 * 
+	 * @param bbase the constrained argumentation framework
+	 * @param semantics the desired semantics
+	 * @return An admissible extension that satisfies the constraint.
+	 */
+	public Extension<EpistemicArgumentationFramework> getModel(EpistemicArgumentationFramework bbase, Semantics semantics) {
+		// return the first C-Admissible Set
+		//get all extensions of the underlying DungTheory based on semantics
+		AbstractExtensionReasoner dungReasoner = AbstractExtensionReasoner.getSimpleReasonerForSemantics(semantics);
+		Collection<Extension<DungTheory>> semExtensions = dungReasoner.getModels(bbase);
+		
+		//find sets that are also C-Admissible
+		for (Extension<DungTheory> semSet : semExtensions) {
+			 Extension<EpistemicArgumentationFramework> cafExtension = new Extension<>();
+			 cafExtension.addAll(semSet);
+			 if (bbase.satisfiesConstraint(semSet)) return cafExtension;
+			
+		}
+		throw new RuntimeException("No Extension found that satisfies constraint.");
+	}
 
 
 

org-tweetyproject-arg-eaf/src/main/java/org/tweetyproject/arg/eaf/reasoner/EAFAgreementReasoner.java

@@ -60,7 +60,7 @@ public EAFAgreementReasoner(EpistemicArgumentationFramework eaf) {
     public boolean addEAF(EpistemicArgumentationFramework eaf) throws Exception {
         // Check whether underlying AFs are the same
         DungTheory underlyingAF = new DungTheory(eaf);
-        if (!this.af.getSignature().equals(underlyingAF.getSignature())) 
+        if (!this.af.equals(underlyingAF))
             throw new Exception("underlying AF does not match AF for this Agreement Reasoner");
         this.eafs.add(eaf);
         return true;

org-tweetyproject-arg-eaf/src/main/java/org/tweetyproject/arg/eaf/reasoner/SimpleEAFAdmissibleReasoner.java

@@ -23,6 +23,7 @@
 
 import org.tweetyproject.arg.dung.reasoner.SimpleAdmissibleReasoner;
 import org.tweetyproject.arg.dung.semantics.Extension;
+import org.tweetyproject.arg.dung.semantics.Semantics;
 import org.tweetyproject.arg.dung.syntax.DungTheory;
 import org.tweetyproject.arg.eaf.syntax.EpistemicArgumentationFramework;
 
@@ -37,46 +38,23 @@
 public class SimpleEAFAdmissibleReasoner extends AbstractEAFReasoner{
 
 	/**
-	 * Computes all admissible extensions that satify the epistemic constraint of the EAF.
+	 * Computes all admissible extensions that satisfy the epistemic constraint of the EAF.
 	 * 
 	 * @param bbase the epistemic argumentation framework
-	 * @return A collection of all admissible extensions that satify the constraint.
+	 * @return A collection of all admissible extensions that satisfy the constraint.
 	 */
 	public Collection<Extension<EpistemicArgumentationFramework>> getModels(EpistemicArgumentationFramework bbase) {
-		//get all admissible Sets of the underlying DungTheory
-		SimpleAdmissibleReasoner dungReasoner = new SimpleAdmissibleReasoner();
-		Collection<Extension<DungTheory>> admExtensions = dungReasoner.getModels(bbase);
-		Collection<Extension<EpistemicArgumentationFramework>> eafAdmExtensions = new HashSet<>();
-		
-		//find sets that satify the constraint
-		for (Extension<DungTheory> admSet : admExtensions) {
-			 Extension<EpistemicArgumentationFramework> eafExtension = new Extension<>();
-			 eafExtension.addAll(admSet);
-			 if (bbase.satisfiesConstraint(admSet)) eafAdmExtensions.add(eafExtension);
-		}
-		return eafAdmExtensions;
+		return super.getModels(bbase, Semantics.ADM);
 	}
 
 	/**
-	 * Computes one admissible extension that satifies the epistemic constraint of the EAF.
+	 * Computes one admissible extension that satisfies the epistemic constraint of the EAF.
 	 * 
 	 * @param bbase the constrained argumentation framework
-	 * @return An admissible extension that satifies the constraint.
+	 * @return An admissible extension that satisfies the constraint.
 	 */
 	public Extension<EpistemicArgumentationFramework> getModel(EpistemicArgumentationFramework bbase) {
-		// return the first C-Admissible Set
-		//get all admissible Sets of the underlying DungTheory
-		SimpleAdmissibleReasoner dungReasoner = new SimpleAdmissibleReasoner();
-		Collection<Extension<DungTheory>> admExtensions = dungReasoner.getModels(bbase);
-		
-		//find sets that are also C-Admissible
-		for (Extension<DungTheory> admSet : admExtensions) {
-			 Extension<EpistemicArgumentationFramework> cafExtension = new Extension<>();
-			 cafExtension.addAll(admSet);
-			 if (bbase.satisfiesConstraint(admSet)) return cafExtension;
-			
-		}
-		throw new RuntimeException("No Admissible Extension found that satisfies constraint.");
+		return super.getModel(bbase, Semantics.ADM);
 	}
 
 }

org-tweetyproject-arg-eaf/src/main/java/org/tweetyproject/arg/eaf/reasoner/SimpleEAFCompleteReasoner.java

@@ -23,6 +23,7 @@
 
 import org.tweetyproject.arg.dung.reasoner.SimpleCompleteReasoner;
 import org.tweetyproject.arg.dung.semantics.Extension;
+import org.tweetyproject.arg.dung.semantics.Semantics;
 import org.tweetyproject.arg.dung.syntax.DungTheory;
 import org.tweetyproject.arg.eaf.syntax.EpistemicArgumentationFramework;
 
@@ -37,45 +38,23 @@
 public class SimpleEAFCompleteReasoner extends AbstractEAFReasoner{
 
 	/**
-	 * Computes all complete extensions that satify the epistemic constraint of the EAF.
+	 * Computes all complete extensions that satisfy the epistemic constraint of the EAF.
 	 * 
 	 * @param bbase the epistemic argumentation framework
-	 * @return A collection of all complete extensions that satify the constraint.
+	 * @return A collection of all complete extensions that satisfy the constraint.
 	 */
 	public Collection<Extension<EpistemicArgumentationFramework>> getModels(EpistemicArgumentationFramework bbase) {
-		//get all complete Sets of the underlying DungTheory
-		SimpleCompleteReasoner dungReasoner = new SimpleCompleteReasoner();
-		Collection<Extension<DungTheory>> comExtensions = dungReasoner.getModels(bbase);
-		Collection<Extension<EpistemicArgumentationFramework>> eafComExtensions = new HashSet<>();
-		
-		//find sets that satify the constraint
-		for (Extension<DungTheory> comSet : comExtensions) {
-			 Extension<EpistemicArgumentationFramework> eafExtension = new Extension<>();
-			 eafExtension.addAll(comSet);
-			 if (bbase.satisfiesConstraint(comSet)) eafComExtensions.add(eafExtension);
-		}
-		return eafComExtensions;
+		return super.getModels(bbase, Semantics.CO);
 	}
 
 	/**
-	 * Computes one complete extension that satifies the epistemic constraint of the EAF.
+	 * Computes one complete extension that satisfies the epistemic constraint of the EAF.
 	 * 
 	 * @param bbase the constrained argumentation framework
-	 * @return A complete extension that satifies the constraint.
+	 * @return A complete extension that satisfies the constraint.
 	 */
 	public Extension<EpistemicArgumentationFramework> getModel(EpistemicArgumentationFramework bbase) {
-		//get all complete Sets of the underlying DungTheory
-		SimpleCompleteReasoner dungReasoner = new SimpleCompleteReasoner();
-		Collection<Extension<DungTheory>> comExtensions = dungReasoner.getModels(bbase);
-		
-		//find a sets that satifies the constraint
-		for (Extension<DungTheory> comSet : comExtensions) {
-			 Extension<EpistemicArgumentationFramework> eafExtension = new Extension<>();
-			 eafExtension.addAll(comSet);
-			 if (bbase.satisfiesConstraint(comSet)) return eafExtension;
-			
-		}
-		throw new RuntimeException("No Complete Extension found that satisfies constraint.");
+		return super.getModel(bbase, Semantics.CO);
 	}
 
 }

org-tweetyproject-arg-eaf/src/main/java/org/tweetyproject/arg/eaf/reasoner/SimpleEAFGroundedReasoner.java

@@ -23,6 +23,7 @@
 
 import org.tweetyproject.arg.dung.reasoner.SimpleGroundedReasoner;
 import org.tweetyproject.arg.dung.semantics.Extension;
+import org.tweetyproject.arg.dung.semantics.Semantics;
 import org.tweetyproject.arg.dung.syntax.DungTheory;
 import org.tweetyproject.arg.eaf.syntax.EpistemicArgumentationFramework;
 
@@ -37,43 +38,23 @@
 public class SimpleEAFGroundedReasoner extends AbstractEAFReasoner{
 
 	/**
-	 * Computes all grounded extensions that satify the epistemic constraint of the EAF.
+	 * Computes all grounded extensions that satisfy the epistemic constraint of the EAF.
 	 * 
 	 * @param bbase the epistemic argumentation framework
-	 * @return A collection of all grounded extensions that satify the constraint.
+	 * @return A collection of all grounded extensions that satisfy the constraint.
 	 */
 	public Collection<Extension<EpistemicArgumentationFramework>> getModels(EpistemicArgumentationFramework bbase) {
-		//get all grounded Sets of the underlying DungTheory
-		SimpleGroundedReasoner dungReasoner = new SimpleGroundedReasoner();
-		Collection<Extension<DungTheory>> grExtensions = dungReasoner.getModels(bbase);
-		Collection<Extension<EpistemicArgumentationFramework>> eafGrExtensions = new HashSet<>();
-		
-		//find sets that satify the constraint
-		for (Extension<DungTheory> grSet : grExtensions) {
-			 Extension<EpistemicArgumentationFramework> eafExtension = new Extension<>();
-			 eafExtension.addAll(grSet);
-			 if (bbase.satisfiesConstraint(grSet)) eafGrExtensions.add(eafExtension);
-		}
-		return eafGrExtensions;
+		return super.getModels(bbase, Semantics.GR);
 	}
 
 	/**
-	 * Computes one grounded extension that satifies the epistemic constraint of the EAF.
+	 * Computes one grounded extension that satisfies the epistemic constraint of the EAF.
 	 * 
 	 * @param bbase the constrained argumentation framework
-	 * @return A grounded extension that satifies the constraint.
+	 * @return A grounded extension that satisfies the constraint.
 	 */
 	public Extension<EpistemicArgumentationFramework> getModel(EpistemicArgumentationFramework bbase) {
-		//get all grounded Sets of the underlying DungTheory
-		SimpleGroundedReasoner dungReasoner = new SimpleGroundedReasoner();
-		Extension<DungTheory> grExtension = dungReasoner.getModel(bbase);
-		
-		//check if grounded extension satisfies constraint
-		Extension<EpistemicArgumentationFramework> eafExtension = new Extension<>();
-		eafExtension.addAll(grExtension);
-		if (bbase.satisfiesConstraint(grExtension)) return eafExtension;
-		
-		throw new RuntimeException("No Grounded Extension found that satisfies constraint.");
+		return super.getModel(bbase, Semantics.GR);
 	}
 
 }

org-tweetyproject-arg-eaf/src/main/java/org/tweetyproject/arg/eaf/reasoner/SimpleEAFPreferredReasoner.java

@@ -23,6 +23,7 @@
 
 import org.tweetyproject.arg.dung.reasoner.SimplePreferredReasoner;
 import org.tweetyproject.arg.dung.semantics.Extension;
+import org.tweetyproject.arg.dung.semantics.Semantics;
 import org.tweetyproject.arg.dung.syntax.DungTheory;
 import org.tweetyproject.arg.eaf.syntax.EpistemicArgumentationFramework;
 
@@ -37,44 +38,22 @@
 public class SimpleEAFPreferredReasoner extends AbstractEAFReasoner{
 
 	/**
-	 * Computes all preferred extensions that satify the epistemic constraint of the EAF.
+	 * Computes all preferred extensions that satisfy the epistemic constraint of the EAF.
 	 * 
 	 * @param bbase the epistemic argumentation framework
-	 * @return A collection of all preferred extensions that satify the constraint.
+	 * @return A collection of all preferred extensions that satisfy the constraint.
 	 */
 	public Collection<Extension<EpistemicArgumentationFramework>> getModels(EpistemicArgumentationFramework bbase) {
-		//get all preferred Sets of the underlying DungTheory
-		SimplePreferredReasoner dungReasoner = new SimplePreferredReasoner();
-		Collection<Extension<DungTheory>> prExtensions = dungReasoner.getModels(bbase);
-		Collection<Extension<EpistemicArgumentationFramework>> eafPrExtensions = new HashSet<>();
-		
-		//find sets that satify the constraint
-		for (Extension<DungTheory> prSet : prExtensions) {
-			 Extension<EpistemicArgumentationFramework> eafExtension = new Extension<>();
-			 eafExtension.addAll(prSet);
-			 if (bbase.satisfiesConstraint(prSet)) eafPrExtensions.add(eafExtension);
-		}
-		return eafPrExtensions;
+		return super.getModels(bbase, Semantics.PR);
 	}
 
 	/**
-	 * Computes one preferred extension that satifies the epistemic constraint of the EAF.
+	 * Computes one preferred extension that satisfies the epistemic constraint of the EAF.
 	 * 
 	 * @param bbase the constrained argumentation framework
-	 * @return A preferred extension that satifies the constraint.
+	 * @return A preferred extension that satisfies the constraint.
 	 */
 	public Extension<EpistemicArgumentationFramework> getModel(EpistemicArgumentationFramework bbase) {
-		//get all preferred Sets of the underlying DungTheory
-		SimplePreferredReasoner dungReasoner = new SimplePreferredReasoner();
-		Collection<Extension<DungTheory>> prExtensions = dungReasoner.getModels(bbase);
-		
-		//find a sets that satifies the constraint
-		for (Extension<DungTheory> prSet : prExtensions) {
-			 Extension<EpistemicArgumentationFramework> eafExtension = new Extension<>();
-			 eafExtension.addAll(prSet);
-			 if (bbase.satisfiesConstraint(prSet)) return eafExtension;
-			
-		}
-		throw new RuntimeException("No Preferred Extension found that satisfies constraint.");
+		return super.getModel(bbase, Semantics.PR);
 	}
 }

org-tweetyproject-arg-eaf/src/main/java/org/tweetyproject/arg/eaf/reasoner/SimpleEAFStableReasoner.java

@@ -23,6 +23,7 @@
 
 import org.tweetyproject.arg.dung.reasoner.SimpleStableReasoner;
 import org.tweetyproject.arg.dung.semantics.Extension;
+import org.tweetyproject.arg.dung.semantics.Semantics;
 import org.tweetyproject.arg.dung.syntax.DungTheory;
 import org.tweetyproject.arg.eaf.syntax.EpistemicArgumentationFramework;
 
@@ -37,44 +38,22 @@
 public class SimpleEAFStableReasoner extends AbstractEAFReasoner{
 
 	/**
-	 * Computes all stable extensions that satify the epistemic constraint of the EAF.
+	 * Computes all stable extensions that satisfy the epistemic constraint of the EAF.
 	 * 
 	 * @param bbase the epistemic argumentation framework
-	 * @return A collection of all stable extensions that satify the constraint.
+	 * @return A collection of all stable extensions that satisfy the constraint.
 	 */
 	public Collection<Extension<EpistemicArgumentationFramework>> getModels(EpistemicArgumentationFramework bbase) {
-		//get all stable Sets of the underlying DungTheory
-		SimpleStableReasoner dungReasoner = new SimpleStableReasoner();
-		Collection<Extension<DungTheory>> stExtensions = dungReasoner.getModels(bbase);
-		Collection<Extension<EpistemicArgumentationFramework>> eafStExtensions = new HashSet<>();
-		
-		//find sets that satify the constraint
-		for (Extension<DungTheory> stSet : stExtensions) {
-			 Extension<EpistemicArgumentationFramework> eafExtension = new Extension<>();
-			 eafExtension.addAll(stSet);
-			 if (bbase.satisfiesConstraint(stSet)) eafStExtensions.add(eafExtension);
-		}
-		return eafStExtensions;
+		return super.getModels(bbase, Semantics.ST);
 	}
 
 	/**
-	 * Computes one stable extension that satifies the epistemic constraint of the EAF.
+	 * Computes one stable extension that satisfies the epistemic constraint of the EAF.
 	 * 
 	 * @param bbase the constrained argumentation framework
-	 * @return An stable extension that satifies the constraint.
+	 * @return An stable extension that satisfies the constraint.
 	 */
 	public Extension<EpistemicArgumentationFramework> getModel(EpistemicArgumentationFramework bbase) {
-		//get all stable Sets of the underlying DungTheory
-		SimpleStableReasoner dungReasoner = new SimpleStableReasoner();
-		Collection<Extension<DungTheory>> stExtensions = dungReasoner.getModels(bbase);
-		
-		//find a sets that satifies the constraint
-		for (Extension<DungTheory> stSet : stExtensions) {
-			 Extension<EpistemicArgumentationFramework> eafExtension = new Extension<>();
-			 eafExtension.addAll(stSet);
-			 if (bbase.satisfiesConstraint(stSet)) return eafExtension;
-			
-		}
-		throw new RuntimeException("No Stable Extension found that satisfies constraint.");
+		return super.getModel(bbase, Semantics.ST);
 	}
 }