Skip to content

Commit 5451e94

Browse files
committed
Fix: Process configs for replace dataRefs and textures
Update Github actions to latest versions and with debug info
1 parent 067af81 commit 5451e94

7 files changed

Lines changed: 46 additions & 10 deletions

File tree

.github/actions/build-lin/action.yml

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,9 @@ outputs:
1818
xpl-file-name:
1919
description: Path to the resulting xpl file
2020
value: ${{ steps.return.outputs.xpl-file-name }}
21+
pdb-file-name:
22+
description: Path to the resulting .debug.zip file (debug symbol info)
23+
value: ${{ steps.return.outputs.pdb-file-name }}
2124

2225
runs:
2326
using: "composite"
@@ -52,9 +55,23 @@ runs:
5255
echo Expected target build not found: "$TARGET_XPL"
5356
exit 1
5457
fi
58+
- name: Extract symbol info
59+
shell: bash
60+
env:
61+
TARGET_XPL: build-lin/${{ inputs.archFolder }}/${{ inputs.pluginName }}.xpl
62+
TARGET_DBG: build-lin/${{ inputs.archFolder }}/${{ inputs.pluginName }}.xpl.debug
63+
TARGET_PDB: build-lin/${{ inputs.archFolder }}/${{ inputs.pluginName }}.xpl.debug.zip
64+
run: |
65+
objcopy --only-keep-debug "$TARGET_XPL" "$TARGET_DBG"
66+
strip --strip-debug --strip-unneeded "$TARGET_XPL"
67+
objcopy --add-gnu-debuglink="$TARGET_DBG" "$TARGET_XPL"
68+
zip -9 "$TARGET_PDB" "$TARGET_DBG"
5569
- name: Return Value
5670
id: return
5771
shell: bash
5872
env:
5973
TARGET_XPL: build-lin/${{ inputs.archFolder }}/${{ inputs.pluginName }}.xpl
60-
run: echo "xpl-file-name=$(echo $TARGET_XPL)" >> $GITHUB_OUTPUT
74+
TARGET_PDB: build-lin/${{ inputs.archFolder }}/${{ inputs.pluginName }}.xpl.debug.zip
75+
run: |
76+
echo "xpl-file-name=$(echo $TARGET_XPL)" >> $GITHUB_OUTPUT
77+
echo "pdb-file-name=$(echo $TARGET_PDB)" >> $GITHUB_OUTPUT

.github/actions/build-mac/action.yml

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,9 @@ outputs:
1818
xpl-file-name:
1919
description: Path to the resulting xpl file
2020
value: ${{ steps.return.outputs.xpl-file-name }}
21+
pdb-file-name:
22+
description: Path to the resulting .dSYM.zip file (debug symbol info)
23+
value: ${{ steps.return.outputs.pdb-file-name }}
2124

2225
runs:
2326
using: "composite"
@@ -51,9 +54,23 @@ runs:
5154
echo Expected target build not found: "$TARGET_XPL"
5255
exit 1
5356
fi
57+
- name: Extract symbol info
58+
shell: bash
59+
env:
60+
TARGET_XPL: build-mac/${{ inputs.archFolder }}/${{ inputs.pluginName }}.xpl
61+
TARGET_DSYM: build-mac/${{ inputs.archFolder }}/${{ inputs.pluginName }}.xpl.dSYM
62+
TARGET_PDB: build-mac/${{ inputs.archFolder }}/${{ inputs.pluginName }}.xpl.dSYM.zip
63+
run: |
64+
dsymutil "$TARGET_XPL"
65+
zip -9r "$TARGET_PDB" "$TARGET_DSYM"
66+
rm -rf "$TARGET_DSYM"
67+
strip -S "$TARGET_XPL"
5468
- name: Return Value
5569
id: return
5670
shell: bash
5771
env:
5872
TARGET_XPL: build-mac/${{ inputs.archFolder }}/${{ inputs.pluginName }}.xpl
59-
run: echo "xpl-file-name=$(echo $TARGET_XPL)" >> $GITHUB_OUTPUT
73+
TARGET_PDB: build-mac/${{ inputs.archFolder }}/${{ inputs.pluginName }}.xpl.dSYM.zip
74+
run: |
75+
echo "xpl-file-name=$(echo $TARGET_XPL)" >> $GITHUB_OUTPUT
76+
echo "pdb-file-name=$(echo $TARGET_PDB)" >> $GITHUB_OUTPUT

.github/workflows/build.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
#####################################
2121
# Linux with GCC
2222
build-lin:
23-
runs-on: ubuntu-20.04
23+
runs-on: ubuntu-22.04
2424
env:
2525
platform: lin
2626
steps:
@@ -40,11 +40,12 @@ jobs:
4040
pluginName: ${{ env.PRJ_NAME }}
4141
archFolder: lin_x64
4242
xplFileName: "${{ steps.build.outputs.xpl-file-name }}"
43+
pdbFileName: "${{ steps.build.outputs.pdb-file-name }}"
4344

4445
#####################################
4546
# MacOS with CMake/clang and sign/notarize in self-written script
4647
build-mac:
47-
runs-on: macos-12
48+
runs-on: macos-14
4849
env:
4950
platform: mac
5051
steps:
@@ -85,6 +86,7 @@ jobs:
8586
pluginName: ${{ env.PRJ_NAME }}
8687
archFolder: mac_x64
8788
xplFileName: ${{ steps.build.outputs.xpl-file-name }}
89+
pdbFileName: "${{ steps.build.outputs.pdb-file-name }}"
8890

8991
#####################################
9092
# Windows with MS Visual Studio

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ else()
2424
endif()
2525

2626
project(XPMP2RemoteClient
27-
VERSION 3.4.0
27+
VERSION 3.4.1
2828
DESCRIPTION "XPMP2-Remote client plugin for X-Plane")
2929

3030
# Provide compile macros from the above project version definition

XPMP2-Remote.xcodeproj/project.pbxproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,7 @@
364364
XPLANE11_ROOT = "$(USER_APPS_DIR)/X-Plane/11";
365365
XPMP2_RC_VER_MAJOR = 3;
366366
XPMP2_RC_VER_MINOR = 4;
367-
XPMP2_RC_VER_PATCH = 0;
367+
XPMP2_RC_VER_PATCH = 1;
368368
XPSDK_ROOT = lib/XPMP2/lib/SDK;
369369
};
370370
name = Debug;
@@ -473,7 +473,7 @@
473473
XPLANE11_ROOT = "$(USER_APPS_DIR)/X-Plane/11";
474474
XPMP2_RC_VER_MAJOR = 3;
475475
XPMP2_RC_VER_MINOR = 4;
476-
XPMP2_RC_VER_PATCH = 0;
476+
XPMP2_RC_VER_PATCH = 1;
477477
XPSDK_ROOT = lib/XPMP2/lib/SDK;
478478
};
479479
name = Release;

src/Client.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -386,8 +386,8 @@ void ClientProcSettings (const std::uint32_t from[4],
386386
const XPMP2::RemoteMsgSettingsTy& otherS = itSender->second.settings;
387387
if (otherS.logLvl < rcGlob.mergedS.logLvl) rcGlob.mergedS.logLvl = otherS.logLvl;
388388
if ( otherS.bLogMdlMatch) rcGlob.mergedS.bLogMdlMatch = true;
389-
if ( otherS.bObjReplDataRefs) rcGlob.mergedS.bLogMdlMatch = true;
390-
if ( otherS.bObjReplTextures) rcGlob.mergedS.bLogMdlMatch = true;
389+
if ( otherS.bObjReplDataRefs) rcGlob.mergedS.bObjReplDataRefs = true;
390+
if ( otherS.bObjReplTextures) rcGlob.mergedS.bObjReplTextures = true;
391391
if (!otherS.bLabelCutOffAtVisibility) rcGlob.mergedS.bLabelCutOffAtVisibility = false;
392392
if ( otherS.bMapEnabled) rcGlob.mergedS.bMapEnabled = true;
393393
if ( otherS.bMapLabels) rcGlob.mergedS.bMapLabels = true;

0 commit comments

Comments
 (0)