[codex] Fix retrieval semantics and prepared search caching#17
Draft
brodieacc wants to merge 1 commit into
Draft
[codex] Fix retrieval semantics and prepared search caching#17brodieacc wants to merge 1 commit into
brodieacc wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
fast=Trueretrieval semantics across discrete, sparse, segmented, and matrix-style spacesItemStoreandAssocStorequeries, with invalidation when the shared codebook changesAttentionResonatorCleanupWhy
The previous fast retrieval path could return the wrong neighbors for several non-cosine models, and it rebuilt static search state on every query. This PR makes the fast path exact again and removes the repeated setup overhead without introducing any native code.
Validation
uv run --extra dev pytest tests/test_attention_resonator.py tests/test_decode_and_retrieval.py -quv run --extra dev pytest --no-covuv run --extra dev mypy holovecuv run --extra dev ruff check holovec tests