Skip to content

Commit 65dd898

Browse files
sgwannabeclaude
andcommitted
fix(graduate): align Dockerfile + workflow to Node 22 (PR #13 codex P2)
PR #13 codex review (P2): the new `engines.node: ">={{NODE_VERSION}}"` in package.json.standard.template renders as ">=22", but the graduated deployment artifacts (Dockerfile multi-stage + GitHub Actions workflow in graduate.sh.template) still pinned Node 20. In environments with `engine-strict=true` (common org default), graduated projects' npm ci or pnpm install would fail purely due to the Node 20 < 22 mismatch. - Dockerfile FROM lines 53/58/64: node:20-alpine → node:22-alpine - Deploy workflow line 134: setup-node node-version '20' → '22' Both numbers are now consistent with the engine floor and with package.json.standard.template's {{NODE_VERSION}} = 22 placeholder default. Refs: PR #13 review by chatgpt-codex-connector (P2) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 0fa83a5 commit 65dd898

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

plugins/preview-forge/assets/graduate.sh.template

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,18 +50,18 @@ fi
5050
if [[ ! -f Dockerfile ]]; then
5151
cat > Dockerfile <<'DOCKERFILE'
5252
# Preview Forge — generated on graduate to pro/max
53-
FROM node:20-alpine AS deps
53+
FROM node:22-alpine AS deps
5454
WORKDIR /app
5555
COPY package*.json ./
5656
RUN npm ci --omit=dev
5757
58-
FROM node:20-alpine AS builder
58+
FROM node:22-alpine AS builder
5959
WORKDIR /app
6060
COPY --from=deps /app/node_modules ./node_modules
6161
COPY . .
6262
RUN npm run build
6363
64-
FROM node:20-alpine
64+
FROM node:22-alpine
6565
WORKDIR /app
6666
ENV NODE_ENV=production
6767
COPY --from=builder /app/.next ./.next
@@ -131,7 +131,7 @@ jobs:
131131
steps:
132132
- uses: actions/checkout@v6
133133
- uses: actions/setup-node@v6
134-
with: { node-version: '20' }
134+
with: { node-version: '22' }
135135
- run: npm ci
136136
- run: npm run build
137137
- run: docker build -t $IMAGE .

0 commit comments

Comments
 (0)