Commit b115847
fix(tests): apply PR #54 R2 (CodeRabbit minor) — set -euo pipefail in 3 new fixtures
CodeRabbit caught: verify-lesson07.sh has `set -u` only at top + later
`set +e` / `set -e` wrapping around the hook call. Without errexit on
from the start, the wrapping is asymmetric — first iteration silently
continues past mktemp/python failures, second iteration onwards has
errexit ON. Iteration-dependent behavior.
Fix: standardize all 3 new fixture scripts to `set -euo pipefail`.
This makes the `set +e` / `set -e` pattern in verify-lesson07.sh
behave as intended (suppress errexit only for the hook call). Also
catches unset-variable bugs and pipe-failure shadowing in the other
two scripts.
All 3 still green locally after the change.
Refs PR #54 review #3141500203.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 477ef54 commit b115847
3 files changed
Lines changed: 3 additions & 3 deletions
File tree
- tests/fixtures
- filled-ratio
- lesson07-regression
- normalize-constraints
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
0 commit comments