Skip to content

Commit eeba3c5

Browse files
sgwannabeclaude
andcommitted
chore(pr-template): commit-prefix + dual-changelog checklist (#71)
- Drops the hardcoded 34/34 verify-plugin.sh count (current pass count is 56+; bare 'passes' avoids future bit-rot) - New checkbox flagging the semantic-scope-not-version-prefix rule with cross-ref to CONTRIBUTING.md - Disambiguates which CHANGELOG to edit: plugins/preview-forge/CHANGELOG.md is hand-maintained; the root CHANGELOG.md is regenerated by release-please and must not be hand-edited (avoids release-PR conflicts) - Reminds authors not to hand-bump version — release-please owns marketplace.json + plugin.json sync Closes #71 part 2 (PR template). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 5be96b8 commit eeba3c5

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,14 @@
1515

1616
## Checklist
1717

18-
- [ ] `bash scripts/verify-plugin.sh` passes (34/34 checks)
18+
- [ ] `bash scripts/verify-plugin.sh` passes
1919
- [ ] Agent count still 143 (or I've updated the proposal + CHANGELOG explicitly)
2020
- [ ] All agents still use `model: opus` (no Sonnet/Haiku)
2121
- [ ] No third-party service dependencies (no Figma / Google / external CDN)
2222
- [ ] Layer-0 rules respected (`methodology/global.md`)
23-
- [ ] `version` bumped in both `.claude-plugin/marketplace.json` and `plugins/preview-forge/.claude-plugin/plugin.json` if this is a release
24-
- [ ] `CHANGELOG.md` entry added
23+
- [ ] Commit prefix uses **semantic scope** (e.g. `fix(cache):`, `feat(security):`), **not** a version prefix (`fix(v1.X.Y):`) — release-please autobumps semver from Conventional Commits, so version scopes are redundant. See `CONTRIBUTING.md → Commit message convention`.
24+
- [ ] `plugins/preview-forge/CHANGELOG.md` (hand-maintained) updated if user-visible plugin behavior changed. **Do not** edit the root `CHANGELOG.md` — it is regenerated by release-please from Conventional Commits. `memory/PROGRESS.md` / `memory/LESSONS.md` updated if applicable.
25+
- [ ] `version` is **not** hand-bumped — release-please owns `.claude-plugin/marketplace.json` + `plugins/preview-forge/.claude-plugin/plugin.json` version sync
2526

2627
## Related
2728

0 commit comments

Comments
 (0)