fix: handle pasting into table cells better, by collapsing their content to inline #2410 #6931
nperez0111Annotations
3 errors and 4 notices
|
[chromium] › src/end-to-end/keyboardhandlers/keyboardhandlers.test.ts:76:7 › Check Keyboard Handlers' Behaviour › Check Enter preserves nested blocks for empty block:
tests/src/utils/editor.ts#L47
1) [chromium] › src/end-to-end/keyboardhandlers/keyboardhandlers.test.ts:76:7 › Check Keyboard Handlers' Behaviour › Check Enter preserves nested blocks for empty block
Error: expect(string).toMatchSnapshot(expected)
@@ -23,91 +23,22 @@
]
},
{
"type": "blockContainer",
"attrs": {
- "id": "4"
+ "id": "1"
},
"content": [
{
"type": "paragraph",
"attrs": {
"backgroundColor": "default",
"textColor": "default",
"textAlignment": "left"
}
- },
- {
- "type": "blockGroup",
- "content": [
- {
- "type": "blockContainer",
- "attrs": {
- "id": "1"
- },
- "content": [
- {
- "type": "heading",
- "attrs": {
- "backgroundColor": "default",
- "textColor": "default",
- "textAlignment": "left",
- "level": 2,
- "isToggleable": false
- },
- "content": [
- {
- "type": "text",
- "text": "Heading"
- }
- ]
- }
- ]
- },
- {
- "type": "blockContainer",
- "attrs": {
- "id": "2"
- },
- "content": [
- {
- "type": "heading",
- "attrs": {
- "backgroundColor": "default",
- "textColor": "default",
- "textAlignment": "left",
- "level": 3,
- "isToggleable": false
- },
- "content": [
- {
- "type": "text",
- "text": "Heading"
- }
- ]
- }
- ]
- }
- ]
}
]
- },
- {
- "type": "blockContainer",
- "attrs": {
- "id": "3"
- },
- "content": [
- {
- "type": "paragraph",
- "attrs": {
- "backgroundColor": "default",
- "textColor": "default",
- "textAlignment": "left"
- }
- }
- ]
}
]
}
]
}
Expected: /__w/BlockNote/BlockNote/tests/src/end-to-end/keyboardhandlers/keyboardhandlers.test.ts-snapshots/enterPreservesNestedBlocksEmpty-json-chromium-linux.json
Received: /__w/BlockNote/BlockNote/tests/test-results/keyboardhandlers-keyboardh-5461c-sted-blocks-for-empty-block-chromium/enterPreservesNestedBlocksEmpty-json-actual.json
at ../utils/editor.ts:47
45 | // Remove id from docs
46 | const doc = JSON.stringify(await getDoc(page), null, 2);
> 47 | expect(doc).toMatchSnapshot(`${name}.json`);
| ^
48 | }
49 |
at compareDocToSnapshot (/__w/BlockNote/BlockNote/tests/src/utils/editor.ts:47:15)
a
|
|
[webkit] › src/end-to-end/basics/basicblocks.test.ts:11:7 › Check basic text block appearance › Check basic text block appearance:
tests/src/end-to-end/basics/basicblocks.test.ts#L19
1) [webkit] › src/end-to-end/basics/basicblocks.test.ts:11:7 › Check basic text block appearance › Check basic text block appearance
Error: locator.click: Test timeout of 30000ms exceeded.
Call log:
- waiting for locator('[data-content-type="video"] .bn-file-caption')
17 | await page.waitForTimeout(500);
18 |
> 19 | await page.locator(`[data-content-type="video"] .bn-file-caption`).click();
| ^
20 | await page.keyboard.press("Backspace");
21 | await page.waitForTimeout(500);
22 |
at /__w/BlockNote/BlockNote/tests/src/end-to-end/basics/basicblocks.test.ts:19:72
|
|
[webkit] › src/end-to-end/basics/basicblocks.test.ts:11:7 › Check basic text block appearance › Check basic text block appearance:
tests/src/end-to-end/basics/basicblocks.test.ts#L0
1) [webkit] › src/end-to-end/basics/basicblocks.test.ts:11:7 › Check basic text block appearance › Check basic text block appearance
Test timeout of 30000ms exceeded.
|
|
Build
{
"workflowData": {
"owner": "TypeCellOS",
"repo": "BlockNote",
"sha": "b50e9d5db791b2a5fa504fe86f11bdb605a715f9",
"ref": "2449"
},
"key": "2xq3ewGqW4",
"runId": 22225909468,
"webhookDebug": {
"action": "requested",
"head_branch": "fix/2410",
"head_repository_full_name": "TypeCellOS/BlockNote",
"full_name": "TypeCellOS/BlockNote",
"isPullRequest": true,
"prNumber": 2449,
"prNumberType": "number",
"isNewPullRequest": true,
"isOldPullRequest": false,
"prKey": "TypeCellOS/BlockNote:fix/2410",
"oldPrDataHash": "cA6xlldOQm",
"lookupKey": "TypeCellOS/BlockNote:fix/2410",
"data": {
"owner": "TypeCellOS",
"repo": "BlockNote",
"sha": "b50e9d5db791b2a5fa504fe86f11bdb605a715f9",
"ref": "2449"
}
}
}
|
|
🎭 Playwright Run Summary
1 flaky
[chromium] › src/end-to-end/keyboardhandlers/keyboardhandlers.test.ts:76:7 › Check Keyboard Handlers' Behaviour › Check Enter preserves nested blocks for empty block
1 skipped
102 passed (2.5m)
|
|
🎭 Playwright Run Summary
11 skipped
93 passed (2.9m)
|
|
🎭 Playwright Run Summary
1 flaky
[webkit] › src/end-to-end/basics/basicblocks.test.ts:11:7 › Check basic text block appearance › Check basic text block appearance
9 skipped
94 passed (4.0m)
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
playwright-report-chromium
Expired
|
3.36 MB |
sha256:b3fdae32b215695921994cc342c5ab833a4f02a584f6549d78a8e745d082da73
|
|
|
playwright-report-firefox
Expired
|
261 KB |
sha256:a9ec700afa6afc6e731b5f7b8e0c35ae4d87921766c65ba2c02c995c7b5141f9
|
|
|
playwright-report-webkit
Expired
|
2.26 MB |
sha256:6a85ee78f2b955fc7d520425b15c88ae10a6eeeb50e444d1725afe3337d91b36
|
|
|
relative-ci-artifacts-editor
Expired
|
46.6 KB |
sha256:d9c42584effe29e2e275141061b078c461391bab7a88f643be1712ddf27805af
|
|