fix: Clicking comment overlapping link opens link (BLO-1091) #7600
coderabbitai[bot]build.yml
on: pull_request
Playwright Build
1m 5s
Build
2m 28s
Matrix: playwright
Merge Playwright Reports
48s
Annotations
4 errors and 6 notices
|
Build
Process completed with exit code 1.
|
|
src/prosemirror/agent.test.ts > agentStepToTr > Update > drop mark and link and change text within mark:
packages/xl-ai/src/prosemirror/agent.test.ts#L260
Error: Snapshot `agentStepToTr > Update > drop mark and link and change text within mark 1` mismatched
- Expected
+ Received
@@ -10,7 +10,7 @@
"I {"type":"doc","content":[{"type":"blockGroup","content":[{"type":"blockContainer","attrs":{"id":"ref1"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, world!"}]}]},{"type":"blockContainer","attrs":{"id":"ref2"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, "},{"type":"mention","attrs":{"user":"John Doe"}},{"type":"text","text":"! "},{"type":"text","marks":[{"type":"bold"}],"text":"How are you doing?"},{"type":"text","text":" "},{"type":"text","marks":[{"type":"textColor","attrs":{"stringValue":"blue"}}],"text":"This text is blue!"}]}]},{"type":"blockContainer","attrs":{"id":"ref3"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","marks":[{"type":"deletion","attrs":{"id":null}}],"text":"Hello"},{"type":"text","marks":[{"type":"insertion","attrs":{"id":null}}],"text":"Hi"},{"type":"text","text":", world! "},{"type":"text","marks":[{"type":"bold"},{"type":"deletion","attrs":{"id":null}}],"text":"Bold"},{"type":"text","marks":[{"type":"insertion","attrs":{"id":null}}],"text":"Bold th"},{"type":"text","marks":[{"type":"bold"}],"text":" text. "},{"type":"text","marks":[{"type":"link","attrs":{"href":"https://www.google.com"}}],"text":"Link."}]}]}]}]}",
"I {"type":"doc","content":[{"type":"blockGroup","content":[{"type":"blockContainer","attrs":{"id":"ref1"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, world!"}]}]},{"type":"blockContainer","attrs":{"id":"ref2"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, "},{"type":"mention","attrs":{"user":"John Doe"}},{"type":"text","text":"! "},{"type":"text","marks":[{"type":"bold"}],"text":"How are you doing?"},{"type":"text","text":" "},{"type":"text","marks":[{"type":"textColor","attrs":{"stringValue":"blue"}}],"text":"This text is blue!"}]}]},{"type":"blockContainer","attrs":{"id":"ref3"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","marks":[{"type":"deletion","attrs":{"id":null}}],"text":"Hello"},{"type":"text","marks":[{"type":"insertion","attrs":{"id":null}}],"text":"Hi"},{"type":"text","text":", world! "},{"type":"text","marks":[{"type":"bold"},{"type":"deletion","attrs":{"id":null}}],"text":"Bold"},{"type":"text","marks":[{"type":"insertion","attrs":{"id":null}}],"text":"Bold the"},{"type":"text","marks":[{"type":"bold"}],"text":" text. "},{"type":"text","marks":[{"type":"link","attrs":{"href":"https://www.google.com"}}],"text":"Link."}]}]}]}]}",
"S {"type":"doc","content":[{"type":"blockGroup","content":[{"type":"blockContainer","attrs":{"id":"ref1"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, world!"}]}]},{"type":"blockContainer","attrs":{"id":"ref2"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, "},{"type":"mention","attrs":{"user":"John Doe"}},{"type":"text","text":"! "},{"type":"text","marks":[{"type":"bold"}],"text":"How are you doing?"},{"type":"text","text":" "},{"type":"text","marks":[{"type":"textColor","attrs":{"stringValue":"blue"}}],"text":"This text is blue!"}]}]},{"type":"blockContainer","attrs":{"id":"ref3"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","marks":[{"type":"deletion","attrs"
|
|
src/prosemirror/agent.test.ts > agentStepToTr > Update > drop mark and link:
packages/xl-ai/src/prosemirror/agent.test.ts#L260
Error: Snapshot `agentStepToTr > Update > drop mark and link 1` mismatched
- Expected
+ Received
[
"S {"type":"doc","content":[{"type":"blockGroup","content":[{"type":"blockContainer","attrs":{"id":"ref1"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, world!"}]}]},{"type":"blockContainer","attrs":{"id":"ref2"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, "},{"type":"mention","attrs":{"user":"John Doe"}},{"type":"text","text":"! "},{"type":"text","marks":[{"type":"bold"}],"text":"How are you doing?"},{"type":"text","text":" "},{"type":"text","marks":[{"type":"textColor","attrs":{"stringValue":"blue"}}],"text":"This text is blue!"}]}]},{"type":"blockContainer","attrs":{"id":"ref3"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, world! "},{"type":"text","marks":[{"type":"bold"}],"text":"Bold text. "},{"type":"text","marks":[{"type":"link","attrs":{"href":"https://www.google.com"}}],"text":"Link."}]}]}]}]}",
"R {"type":"doc","content":[{"type":"blockGroup","content":[{"type":"blockContainer","attrs":{"id":"ref1"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, world!"}]}]},{"type":"blockContainer","attrs":{"id":"ref2"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, "},{"type":"mention","attrs":{"user":"John Doe"}},{"type":"text","text":"! "},{"type":"text","marks":[{"type":"bold"}],"text":"How are you doing?"},{"type":"text","text":" "},{"type":"text","marks":[{"type":"textColor","attrs":{"stringValue":"blue"}}],"text":"This text is blue!"}]}]},{"type":"blockContainer","attrs":{"id":"ref3"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, world! "},{"type":"text","marks":[{"type":"bold"},{"type":"deletion","attrs":{"id":null}}],"text":"Bold text. "},{"type":"text","marks":[{"type":"insertion","attrs":{"id":null}}],"text":"Bold text. "},{"type":"text","marks":[{"type":"link","attrs":{"href":"https://www.google.com"}}],"text":"Link."}]}]}]}]}",
"S {"type":"doc","content":[{"type":"blockGroup","content":[{"type":"blockContainer","attrs":{"id":"ref1"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, world!"}]}]},{"type":"blockContainer","attrs":{"id":"ref2"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, "},{"type":"mention","attrs":{"user":"John Doe"}},{"type":"text","text":"! "},{"type":"text","marks":[{"type":"bold"}],"text":"How are you doing?"},{"type":"text","text":" "},{"type":"text","marks":[{"type":"textColor","attrs":{"stringValue":"blue"}}],"text":"This text is blue!"}]}]},{"type":"blockContainer","attrs":{"id":"ref3"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, world! "},{"type":"text","marks":[{"type":"bold"},{"type":"deletion","attrs":{"id":null}}],"text":"Bold text. "},{"type":"text","marks":[{"type":"insertion","attrs":{"id":null}}],"text":"Bold text. "},{"type":"text","marks":[{"type":"link","attrs":{"href":"https://www.google.com"}}],"text":"Link."}]}]}]}]}",
- "R {"type":"doc","content":[{"type":"blockGroup","content":[{"type":"blockContainer","attrs":{"id":"ref1"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, world!"}]}]},{"type":
|
|
[webkit] › src/end-to-end/keyboardhandlers/keyboardhandlers.test.ts:97:7 › Check Keyboard Handlers' Behaviour › Check Backspace at the start of a block:
tests/src/utils/editor.ts#L47
1) [webkit] › src/end-to-end/keyboardhandlers/keyboardhandlers.test.ts:97:7 › Check Keyboard Handlers' Behaviour › Check Backspace at the start of a block
Error: expect(string).toMatchSnapshot(expected)
@@ -9,15 +9,17 @@
"attrs": {
"id": "0"
},
"content": [
{
- "type": "paragraph",
+ "type": "heading",
"attrs": {
"backgroundColor": "default",
"textColor": "default",
- "textAlignment": "left"
+ "textAlignment": "left",
+ "level": 1,
+ "isToggleable": false
},
"content": [
{
"type": "text",
"text": "Heading"
Expected: /__w/BlockNote/BlockNote/tests/src/end-to-end/keyboardhandlers/keyboardhandlers.test.ts-snapshots/backspaceStartOfBlock-json-webkit-linux.json
Received: /__w/BlockNote/BlockNote/tests/test-results/keyboardhandlers-keyboardh-54c1c-ace-at-the-start-of-a-block-webkit/backspaceStartOfBlock-json-actual.json
at ../utils/editor.ts:47
45 | // Remove id from docs
46 | const doc = JSON.stringify(await getDoc(page), null, 2);
> 47 | expect(doc).toMatchSnapshot(`${name}.json`);
| ^
48 | }
49 |
at compareDocToSnapshot (/__w/BlockNote/BlockNote/tests/src/utils/editor.ts:47:15)
at /__w/BlockNote/BlockNote/tests/src/end-to-end/keyboardhandlers/keyboardhandlers.test.ts:105:5
|
|
🎭 Playwright Run Summary
42 passed (37.0s)
|
|
🎭 Playwright Run Summary
42 passed (46.3s)
|
|
🎭 Playwright Run Summary
42 passed (1.0m)
|
|
🎭 Playwright Run Summary
15 skipped
77 passed (1.5m)
|
|
🎭 Playwright Run Summary
2 skipped
90 passed (1.3m)
|
|
🎭 Playwright Run Summary
1 flaky
[webkit] › src/end-to-end/keyboardhandlers/keyboardhandlers.test.ts:97:7 › Check Keyboard Handlers' Behaviour › Check Backspace at the start of a block
12 skipped
79 passed (2.4m)
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
blob-report-chromium-1
Expired
|
127 KB |
sha256:7291230910d95f5a28ec56f6e2fcb3fdedf6279bfd6d1850405bd48130645fcb
|
|
|
blob-report-chromium-2
Expired
|
50.8 KB |
sha256:545f7a87ee937e360cd9dbb5159533b3d76ae0dac0445ae99970fcbd98c25bea
|
|
|
blob-report-firefox-1
Expired
|
115 KB |
sha256:5e2d90016ef44338bf7b5c3bdad194c1c8838f0acc87a803faf1032f7fa14923
|
|
|
blob-report-firefox-2
Expired
|
51.5 KB |
sha256:f3b4d0208b17adbeac99de82e57ed057782f6c20302048bd38a1bb8eb1269f07
|
|
|
blob-report-webkit-1
Expired
|
5.25 MB |
sha256:8b048813f740580676e5aa11be67d4f9a08071188bfd7783957ac1d2ea307625
|
|
|
blob-report-webkit-2
Expired
|
51.9 KB |
sha256:3c58e58e4985780d31efbeddb9605495cd1843da87d35b41cf10b4e2909f8f04
|
|
|
playwright-build
Expired
|
21.5 MB |
sha256:8eead36e69767f1b82ff2c249846be7eea989247f88fbd734c99c1d813b037e2
|
|
|
playwright-report-chromium-1
Expired
|
260 KB |
sha256:01629deaabfc9d0517b2f9a78c8ace398bc993d8006aac0f906a6c305c5be480
|
|
|
playwright-report-chromium-2
Expired
|
208 KB |
sha256:c6db19fa98c58f1d66c1f9d39ccf69b8b7543aa2e89c01f2251ff08b062afc43
|
|
|
playwright-report-firefox-1
Expired
|
250 KB |
sha256:3d3f992d289e615f2ab434c13279c48180207588d322712fd4b3709acb7344da
|
|
|
playwright-report-firefox-2
Expired
|
209 KB |
sha256:bfdda8a9346add3968abf81974843e08de2f0bbed7cf738618068a637f19197e
|
|
|
playwright-report-merged
Expired
|
5.83 MB |
sha256:47b5cf918d121113cbd6ee6735c02379ca113f2c2c79c37553a81dfc98a9c033
|
|
|
playwright-report-webkit-1
Expired
|
5.75 MB |
sha256:2c65e17ccd88684372f77dc20c7eebd2fb83245925933467de8461b93dc925fd
|
|
|
playwright-report-webkit-2
Expired
|
209 KB |
sha256:006b7787ff7874996189388b5bb04d7e8ffba27ce857f04c09483ac303091121
|
|