fix: Clicking comment overlapping link opens link (BLO-1091) #7602
coderabbitai[bot]build.yml
on: pull_request
Playwright Build
1m 25s
Build
2m 32s
Matrix: playwright
Merge Playwright Reports
1m 8s
Annotations
4 errors and 6 notices
|
Build
Process completed with exit code 1.
|
|
src/prosemirror/agent.test.ts > agentStepToTr > Update > drop mark and link and change text within mark:
packages/xl-ai/src/prosemirror/agent.test.ts#L260
Error: Snapshot `agentStepToTr > Update > drop mark and link and change text within mark 1` mismatched
- Expected
+ Received
@@ -10,7 +10,7 @@
"I {"type":"doc","content":[{"type":"blockGroup","content":[{"type":"blockContainer","attrs":{"id":"ref1"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, world!"}]}]},{"type":"blockContainer","attrs":{"id":"ref2"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, "},{"type":"mention","attrs":{"user":"John Doe"}},{"type":"text","text":"! "},{"type":"text","marks":[{"type":"bold"}],"text":"How are you doing?"},{"type":"text","text":" "},{"type":"text","marks":[{"type":"textColor","attrs":{"stringValue":"blue"}}],"text":"This text is blue!"}]}]},{"type":"blockContainer","attrs":{"id":"ref3"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","marks":[{"type":"deletion","attrs":{"id":null}}],"text":"Hello"},{"type":"text","marks":[{"type":"insertion","attrs":{"id":null}}],"text":"Hi"},{"type":"text","text":", world! "},{"type":"text","marks":[{"type":"bold"},{"type":"deletion","attrs":{"id":null}}],"text":"Bold"},{"type":"text","marks":[{"type":"insertion","attrs":{"id":null}}],"text":"Bold th"},{"type":"text","marks":[{"type":"bold"}],"text":" text. "},{"type":"text","marks":[{"type":"link","attrs":{"href":"https://www.google.com"}}],"text":"Link."}]}]}]}]}",
"I {"type":"doc","content":[{"type":"blockGroup","content":[{"type":"blockContainer","attrs":{"id":"ref1"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, world!"}]}]},{"type":"blockContainer","attrs":{"id":"ref2"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, "},{"type":"mention","attrs":{"user":"John Doe"}},{"type":"text","text":"! "},{"type":"text","marks":[{"type":"bold"}],"text":"How are you doing?"},{"type":"text","text":" "},{"type":"text","marks":[{"type":"textColor","attrs":{"stringValue":"blue"}}],"text":"This text is blue!"}]}]},{"type":"blockContainer","attrs":{"id":"ref3"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","marks":[{"type":"deletion","attrs":{"id":null}}],"text":"Hello"},{"type":"text","marks":[{"type":"insertion","attrs":{"id":null}}],"text":"Hi"},{"type":"text","text":", world! "},{"type":"text","marks":[{"type":"bold"},{"type":"deletion","attrs":{"id":null}}],"text":"Bold"},{"type":"text","marks":[{"type":"insertion","attrs":{"id":null}}],"text":"Bold the"},{"type":"text","marks":[{"type":"bold"}],"text":" text. "},{"type":"text","marks":[{"type":"link","attrs":{"href":"https://www.google.com"}}],"text":"Link."}]}]}]}]}",
"S {"type":"doc","content":[{"type":"blockGroup","content":[{"type":"blockContainer","attrs":{"id":"ref1"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, world!"}]}]},{"type":"blockContainer","attrs":{"id":"ref2"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, "},{"type":"mention","attrs":{"user":"John Doe"}},{"type":"text","text":"! "},{"type":"text","marks":[{"type":"bold"}],"text":"How are you doing?"},{"type":"text","text":" "},{"type":"text","marks":[{"type":"textColor","attrs":{"stringValue":"blue"}}],"text":"This text is blue!"}]}]},{"type":"blockContainer","attrs":{"id":"ref3"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","marks":[{"type":"deletion","attrs"
|
|
src/prosemirror/agent.test.ts > agentStepToTr > Update > drop mark and link:
packages/xl-ai/src/prosemirror/agent.test.ts#L260
Error: Snapshot `agentStepToTr > Update > drop mark and link 1` mismatched
- Expected
+ Received
[
"S {"type":"doc","content":[{"type":"blockGroup","content":[{"type":"blockContainer","attrs":{"id":"ref1"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, world!"}]}]},{"type":"blockContainer","attrs":{"id":"ref2"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, "},{"type":"mention","attrs":{"user":"John Doe"}},{"type":"text","text":"! "},{"type":"text","marks":[{"type":"bold"}],"text":"How are you doing?"},{"type":"text","text":" "},{"type":"text","marks":[{"type":"textColor","attrs":{"stringValue":"blue"}}],"text":"This text is blue!"}]}]},{"type":"blockContainer","attrs":{"id":"ref3"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, world! "},{"type":"text","marks":[{"type":"bold"}],"text":"Bold text. "},{"type":"text","marks":[{"type":"link","attrs":{"href":"https://www.google.com"}}],"text":"Link."}]}]}]}]}",
"R {"type":"doc","content":[{"type":"blockGroup","content":[{"type":"blockContainer","attrs":{"id":"ref1"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, world!"}]}]},{"type":"blockContainer","attrs":{"id":"ref2"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, "},{"type":"mention","attrs":{"user":"John Doe"}},{"type":"text","text":"! "},{"type":"text","marks":[{"type":"bold"}],"text":"How are you doing?"},{"type":"text","text":" "},{"type":"text","marks":[{"type":"textColor","attrs":{"stringValue":"blue"}}],"text":"This text is blue!"}]}]},{"type":"blockContainer","attrs":{"id":"ref3"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, world! "},{"type":"text","marks":[{"type":"bold"},{"type":"deletion","attrs":{"id":null}}],"text":"Bold text. "},{"type":"text","marks":[{"type":"insertion","attrs":{"id":null}}],"text":"Bold text. "},{"type":"text","marks":[{"type":"link","attrs":{"href":"https://www.google.com"}}],"text":"Link."}]}]}]}]}",
"S {"type":"doc","content":[{"type":"blockGroup","content":[{"type":"blockContainer","attrs":{"id":"ref1"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, world!"}]}]},{"type":"blockContainer","attrs":{"id":"ref2"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, "},{"type":"mention","attrs":{"user":"John Doe"}},{"type":"text","text":"! "},{"type":"text","marks":[{"type":"bold"}],"text":"How are you doing?"},{"type":"text","text":" "},{"type":"text","marks":[{"type":"textColor","attrs":{"stringValue":"blue"}}],"text":"This text is blue!"}]}]},{"type":"blockContainer","attrs":{"id":"ref3"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, world! "},{"type":"text","marks":[{"type":"bold"},{"type":"deletion","attrs":{"id":null}}],"text":"Bold text. "},{"type":"text","marks":[{"type":"insertion","attrs":{"id":null}}],"text":"Bold text. "},{"type":"text","marks":[{"type":"link","attrs":{"href":"https://www.google.com"}}],"text":"Link."}]}]}]}]}",
- "R {"type":"doc","content":[{"type":"blockGroup","content":[{"type":"blockContainer","attrs":{"id":"ref1"},"content":[{"type":"paragraph","attrs":{"backgroundColor":"default","textColor":"default","textAlignment":"left"},"content":[{"type":"text","text":"Hello, world!"}]}]},{"type":
|
|
[webkit] › src/end-to-end/keyboardhandlers/keyboardhandlers.test.ts:59:7 › Check Keyboard Handlers' Behaviour › Check Enter preserves nested blocks:
tests/src/utils/editor.ts#L47
1) [webkit] › src/end-to-end/keyboardhandlers/keyboardhandlers.test.ts:59:7 › Check Keyboard Handlers' Behaviour › Check Enter preserves nested blocks
Error: expect(string).toMatchSnapshot(expected)
@@ -16,37 +16,33 @@
"backgroundColor": "default",
"textColor": "default",
"textAlignment": "left",
"level": 1,
"isToggleable": false
- },
- "content": [
- {
- "type": "text",
- "text": "H"
- }
- ]
+ }
}
]
},
{
"type": "blockContainer",
"attrs": {
"id": "4"
},
"content": [
{
- "type": "paragraph",
+ "type": "heading",
"attrs": {
"backgroundColor": "default",
"textColor": "default",
- "textAlignment": "left"
+ "textAlignment": "left",
+ "level": 1,
+ "isToggleable": false
},
"content": [
{
"type": "text",
- "text": "eading"
+ "text": "Heading"
}
]
},
{
"type": "blockGroup",
Expected: /__w/BlockNote/BlockNote/tests/src/end-to-end/keyboardhandlers/keyboardhandlers.test.ts-snapshots/enterPreservesNestedBlocks-json-webkit-linux.json
Received: /__w/BlockNote/BlockNote/tests/test-results/keyboardhandlers-keyboardh-351fd-ter-preserves-nested-blocks-webkit/enterPreservesNestedBlocks-json-actual.json
at ../utils/editor.ts:47
45 | // Remove id from docs
46 | const doc = JSON.stringify(await getDoc(page), null, 2);
> 47 | expect(doc).toMatchSnapshot(`${name}.json`);
| ^
48 | }
49 |
at compareDocToSnapshot (/__w/BlockNote/BlockNote/tests/src/utils/editor.ts:47:15)
at /__w/BlockNote/BlockNote/tests/src/end-to-end/keyboardhandlers/keyboardhandlers.test.ts:75:5
|
|
🎭 Playwright Run Summary
42 passed (35.7s)
|
|
🎭 Playwright Run Summary
42 passed (47.8s)
|
|
🎭 Playwright Run Summary
42 passed (1.0m)
|
|
🎭 Playwright Run Summary
15 skipped
77 passed (1.6m)
|
|
🎭 Playwright Run Summary
2 skipped
90 passed (1.2m)
|
|
🎭 Playwright Run Summary
1 flaky
[webkit] › src/end-to-end/keyboardhandlers/keyboardhandlers.test.ts:59:7 › Check Keyboard Handlers' Behaviour › Check Enter preserves nested blocks
12 skipped
79 passed (2.3m)
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
blob-report-chromium-1
Expired
|
126 KB |
sha256:934039d0039572d419e5b84859fff98dde505b9ec012dde5b483e77d975f4a7b
|
|
|
blob-report-chromium-2
Expired
|
50.7 KB |
sha256:b60a8f588c13904a277a3cdc3090dad77c315a72cf3fa43652add26292d5ab81
|
|
|
blob-report-firefox-1
Expired
|
115 KB |
sha256:0499759f8f0f6f10d440d8cb2df3d2cd6689fdca4eb8642fa513fc626644fd02
|
|
|
blob-report-firefox-2
Expired
|
51.6 KB |
sha256:db53b65e7eb64c91c3ae601dff2c859aa14d2a57b7e3b4c33567065b121d0deb
|
|
|
blob-report-webkit-1
Expired
|
5.35 MB |
sha256:43b657528efa2a36bf32fa822f1ad47d140087c024c4298f7e3a2e7e762f0856
|
|
|
blob-report-webkit-2
Expired
|
51.8 KB |
sha256:30aaac0568f628ac79cf78995f4e799afebd24827fab9f9c186c0b88b67a3291
|
|
|
playwright-build
Expired
|
21.5 MB |
sha256:96cf6c666a107b6c17c736eb8d4ef47663e95ada75cbbe44c3d288e28f0dc7a6
|
|
|
playwright-report-chromium-1
Expired
|
259 KB |
sha256:3d5cf5ba7e77d571b8fe74e507713bf8256ca0e721619dfe327a1dc39ae475f4
|
|
|
playwright-report-chromium-2
Expired
|
208 KB |
sha256:8d26d8651351ee0424fb0a61a64ec77e3ac5eb0a4f6b83003db314419b3e411e
|
|
|
playwright-report-firefox-1
Expired
|
250 KB |
sha256:7d61a236af99170f16a9807aa18a6e9e3337df4649e394164bcbba53c6666749
|
|
|
playwright-report-firefox-2
Expired
|
209 KB |
sha256:21872329d89cf5fe2df6b9e540e401641c4bce73fec64bbc04ea0b73f2878a02
|
|
|
playwright-report-merged
Expired
|
5.92 MB |
sha256:bc359da86e3125968333a6c396c2b25c1c048e4aefb7cf775883759ccd547351
|
|
|
playwright-report-webkit-1
Expired
|
5.85 MB |
sha256:e93c57c78441982c4f442cd4e7eceeea6e4707071c5151c3929d1ec85b306247
|
|
|
playwright-report-webkit-2
Expired
|
209 KB |
sha256:f66d822b6544a3253cdd231807654f627bda059e427124e87d5ae22754aefdef
|
|