fix: set width attribute on image and video elements in editor render #7798
coderabbitai[bot]build.yml
on: pull_request
Playwright Build
46s
Build
1m 17s
Matrix: playwright
Merge Playwright Reports
58s
Annotations
13 errors and 6 notices
|
Build
Process completed with exit code 1.
|
|
src/unit/react/formatConversion/export/runTests.test.ts > React export tests (BlockNote HTML) > reactImage/nested:
tests/src/unit/shared/formatConversion/export/exportTestExecutors.ts#L26
Error: Snapshot `React export tests (BlockNote HTML) > reactImage/nested 1` mismatched
- Expected
+ Received
@@ -13,11 +13,17 @@
<figure
class="bn-file-block-content-wrapper"
style="position: relative; width: 256px;"
>
<div class="bn-visual-media-wrapper">
- <img class="bn-visual-media" src="exampleURL" alt="example" draggable="false" />
+ <img
+ class="bn-visual-media"
+ src="exampleURL"
+ alt="example"
+ draggable="false"
+ width="256"
+ />
<div class="bn-resize-handle" style="left: 4px; display: none;"></div>
<div class="bn-resize-handle" style="right: 4px; display: none;"></div>
</div>
<figcaption class="bn-file-caption">Caption</figcaption>
</figure>
@@ -37,11 +43,17 @@
<figure
class="bn-file-block-content-wrapper"
style="position: relative; width: 256px;"
>
<div class="bn-visual-media-wrapper">
- <img class="bn-visual-media" src="exampleURL" alt="example" draggable="false" />
+ <img
+ class="bn-visual-media"
+ src="exampleURL"
+ alt="example"
+ draggable="false"
+ width="256"
+ />
<div class="bn-resize-handle" style="left: 4px; display: none;"></div>
<div class="bn-resize-handle" style="right: 4px; display: none;"></div>
</div>
<figcaption class="bn-file-caption">Caption</figcaption>
</figure>
❯ testExportBlockNoteHTML src/unit/shared/formatConversion/export/exportTestExecutors.ts:26:3
❯ src/unit/react/formatConversion/export/runTests.test.ts:15:7
|
|
src/unit/react/formatConversion/export/runTests.test.ts > React export tests (BlockNote HTML) > reactImage/noCaption:
tests/src/unit/shared/formatConversion/export/exportTestExecutors.ts#L26
Error: Snapshot `React export tests (BlockNote HTML) > reactImage/noCaption 1` mismatched
- Expected
+ Received
@@ -12,11 +12,17 @@
<div
class="bn-file-block-content-wrapper"
style="position: relative; width: 256px;"
>
<div class="bn-visual-media-wrapper">
- <img class="bn-visual-media" src="exampleURL" alt="example" draggable="false" />
+ <img
+ class="bn-visual-media"
+ src="exampleURL"
+ alt="example"
+ draggable="false"
+ width="256"
+ />
<div class="bn-resize-handle" style="left: 4px; display: none;"></div>
<div class="bn-resize-handle" style="right: 4px; display: none;"></div>
</div>
</div>
</div>
❯ testExportBlockNoteHTML src/unit/shared/formatConversion/export/exportTestExecutors.ts:26:3
❯ src/unit/react/formatConversion/export/runTests.test.ts:15:7
|
|
src/unit/react/formatConversion/export/runTests.test.ts > React export tests (BlockNote HTML) > reactImage/noName:
tests/src/unit/shared/formatConversion/export/exportTestExecutors.ts#L26
Error: Snapshot `React export tests (BlockNote HTML) > reactImage/noName 1` mismatched
- Expected
+ Received
@@ -12,11 +12,17 @@
<figure
class="bn-file-block-content-wrapper"
style="position: relative; width: 256px;"
>
<div class="bn-visual-media-wrapper">
- <img class="bn-visual-media" src="exampleURL" alt="" draggable="false" />
+ <img
+ class="bn-visual-media"
+ src="exampleURL"
+ alt=""
+ draggable="false"
+ width="256"
+ />
<div class="bn-resize-handle" style="left: 4px; display: none;"></div>
<div class="bn-resize-handle" style="right: 4px; display: none;"></div>
</div>
<figcaption class="bn-file-caption">Caption</figcaption>
</figure>
❯ testExportBlockNoteHTML src/unit/shared/formatConversion/export/exportTestExecutors.ts:26:3
❯ src/unit/react/formatConversion/export/runTests.test.ts:15:7
|
|
src/unit/react/formatConversion/export/runTests.test.ts > React export tests (BlockNote HTML) > reactImage/basic:
tests/src/unit/shared/formatConversion/export/exportTestExecutors.ts#L26
Error: Snapshot `React export tests (BlockNote HTML) > reactImage/basic 1` mismatched
- Expected
+ Received
@@ -13,11 +13,17 @@
<figure
class="bn-file-block-content-wrapper"
style="position: relative; width: 256px;"
>
<div class="bn-visual-media-wrapper">
- <img class="bn-visual-media" src="exampleURL" alt="example" draggable="false" />
+ <img
+ class="bn-visual-media"
+ src="exampleURL"
+ alt="example"
+ draggable="false"
+ width="256"
+ />
<div class="bn-resize-handle" style="left: 4px; display: none;"></div>
<div class="bn-resize-handle" style="right: 4px; display: none;"></div>
</div>
<figcaption class="bn-file-caption">Caption</figcaption>
</figure>
❯ testExportBlockNoteHTML src/unit/shared/formatConversion/export/exportTestExecutors.ts:26:3
❯ src/unit/react/formatConversion/export/runTests.test.ts:15:7
|
|
src/unit/core/formatConversion/export/runTests.test.ts > Export tests (BlockNote HTML) > image/nested:
tests/src/unit/shared/formatConversion/export/exportTestExecutors.ts#L26
Error: Snapshot `Export tests (BlockNote HTML) > image/nested 1` mismatched
- Expected
+ Received
@@ -12,11 +12,17 @@
<figure
class="bn-file-block-content-wrapper"
style="position: relative; width: 256px;"
>
<div class="bn-visual-media-wrapper">
- <img class="bn-visual-media" src="exampleURL" alt="" draggable="false" />
+ <img
+ class="bn-visual-media"
+ src="exampleURL"
+ alt=""
+ draggable="false"
+ width="256"
+ />
<div class="bn-resize-handle" style="left: 4px; display: none;"></div>
<div class="bn-resize-handle" style="right: 4px; display: none;"></div>
</div>
<figcaption class="bn-file-caption">Caption</figcaption>
</figure>
@@ -35,11 +41,17 @@
<figure
class="bn-file-block-content-wrapper"
style="position: relative; width: 256px;"
>
<div class="bn-visual-media-wrapper">
- <img class="bn-visual-media" src="exampleURL" alt="" draggable="false" />
+ <img
+ class="bn-visual-media"
+ src="exampleURL"
+ alt=""
+ draggable="false"
+ width="256"
+ />
<div class="bn-resize-handle" style="left: 4px; display: none;"></div>
<div class="bn-resize-handle" style="right: 4px; display: none;"></div>
</div>
<figcaption class="bn-file-caption">Caption</figcaption>
</figure>
❯ testExportBlockNoteHTML src/unit/shared/formatConversion/export/exportTestExecutors.ts:26:3
❯ src/unit/core/formatConversion/export/runTests.test.ts:20:7
|
|
src/unit/core/formatConversion/export/runTests.test.ts > Export tests (BlockNote HTML) > image/noCaption:
tests/src/unit/shared/formatConversion/export/exportTestExecutors.ts#L26
Error: Snapshot `Export tests (BlockNote HTML) > image/noCaption 1` mismatched
- Expected
+ Received
@@ -12,11 +12,17 @@
<div
class="bn-file-block-content-wrapper"
style="position: relative; width: 256px;"
>
<div class="bn-visual-media-wrapper">
- <img class="bn-visual-media" src="exampleURL" alt="example" draggable="false" />
+ <img
+ class="bn-visual-media"
+ src="exampleURL"
+ alt="example"
+ draggable="false"
+ width="256"
+ />
<div class="bn-resize-handle" style="left: 4px; display: none;"></div>
<div class="bn-resize-handle" style="right: 4px; display: none;"></div>
</div>
</div>
</div>
❯ testExportBlockNoteHTML src/unit/shared/formatConversion/export/exportTestExecutors.ts:26:3
❯ src/unit/core/formatConversion/export/runTests.test.ts:20:7
|
|
src/unit/core/formatConversion/export/runTests.test.ts > Export tests (BlockNote HTML) > image/noName:
tests/src/unit/shared/formatConversion/export/exportTestExecutors.ts#L26
Error: Snapshot `Export tests (BlockNote HTML) > image/noName 1` mismatched
- Expected
+ Received
@@ -12,11 +12,17 @@
<figure
class="bn-file-block-content-wrapper"
style="position: relative; width: 256px;"
>
<div class="bn-visual-media-wrapper">
- <img class="bn-visual-media" src="exampleURL" alt="" draggable="false" />
+ <img
+ class="bn-visual-media"
+ src="exampleURL"
+ alt=""
+ draggable="false"
+ width="256"
+ />
<div class="bn-resize-handle" style="left: 4px; display: none;"></div>
<div class="bn-resize-handle" style="right: 4px; display: none;"></div>
</div>
<figcaption class="bn-file-caption">Caption</figcaption>
</figure>
❯ testExportBlockNoteHTML src/unit/shared/formatConversion/export/exportTestExecutors.ts:26:3
❯ src/unit/core/formatConversion/export/runTests.test.ts:20:7
|
|
src/unit/core/formatConversion/export/runTests.test.ts > Export tests (BlockNote HTML) > image/basic:
tests/src/unit/shared/formatConversion/export/exportTestExecutors.ts#L26
Error: Snapshot `Export tests (BlockNote HTML) > image/basic 1` mismatched
- Expected
+ Received
@@ -13,11 +13,17 @@
<figure
class="bn-file-block-content-wrapper"
style="position: relative; width: 256px;"
>
<div class="bn-visual-media-wrapper">
- <img class="bn-visual-media" src="exampleURL" alt="example" draggable="false" />
+ <img
+ class="bn-visual-media"
+ src="exampleURL"
+ alt="example"
+ draggable="false"
+ width="256"
+ />
<div class="bn-resize-handle" style="left: 4px; display: none;"></div>
<div class="bn-resize-handle" style="right: 4px; display: none;"></div>
</div>
<figcaption class="bn-file-caption">Caption</figcaption>
</figure>
❯ testExportBlockNoteHTML src/unit/shared/formatConversion/export/exportTestExecutors.ts:26:3
❯ src/unit/core/formatConversion/export/runTests.test.ts:20:7
|
|
Playwright Tests - webkit (1/2)
Process completed with exit code 1.
|
|
[webkit] › src/end-to-end/keyboardhandlers/keyboardhandlers.test.ts:306:7 › Check Keyboard Handlers' Behaviour › Check Delete before shallower block:
tests/src/utils/editor.ts#L47
1) [webkit] › src/end-to-end/keyboardhandlers/keyboardhandlers.test.ts:306:7 › Check Keyboard Handlers' Behaviour › Check Delete before shallower block
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Error: expect(string).toMatchSnapshot(expected)
@@ -41,19 +41,41 @@
"textAlignment": "left"
},
"content": [
{
"type": "text",
- "text": "ParagraphParagraph"
+ "text": "Paragrap"
}
]
}
]
}
]
}
]
+ },
+ {
+ "type": "blockContainer",
+ "attrs": {
+ "id": "2"
+ },
+ "content": [
+ {
+ "type": "paragraph",
+ "attrs": {
+ "backgroundColor": "default",
+ "textColor": "default",
+ "textAlignment": "left"
+ },
+ "content": [
+ {
+ "type": "text",
+ "text": "Paragraph"
+ }
+ ]
+ }
+ ]
}
]
}
]
}
Expected: /__w/BlockNote/BlockNote/tests/src/end-to-end/keyboardhandlers/keyboardhandlers.test.ts-snapshots/deleteShallowerBlock-json-webkit-linux.json
Received: /__w/BlockNote/BlockNote/tests/test-results/keyboardhandlers-keyboardh-9a661-lete-before-shallower-block-webkit-retry2/deleteShallowerBlock-json-actual.json
at ../utils/editor.ts:47
45 | // Remove id from docs
46 | const doc = JSON.stringify(await getDoc(page), null, 2);
> 47 | expect(doc).toMatchSnapshot(`${name}.json`);
| ^
48 | }
49 |
at compareDocToSnapshot (/__w/BlockNote/BlockNote/tests/src/utils/editor.ts:47:15)
at /__w/BlockNote/BlockNote/tests/src/end-to-end/keyboardhandlers/keyboardhandlers.test.ts:319:5
|
|
[webkit] › src/end-to-end/keyboardhandlers/keyboardhandlers.test.ts:306:7 › Check Keyboard Handlers' Behaviour › Check Delete before shallower block:
tests/src/utils/editor.ts#L47
1) [webkit] › src/end-to-end/keyboardhandlers/keyboardhandlers.test.ts:306:7 › Check Keyboard Handlers' Behaviour › Check Delete before shallower block
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: expect(string).toMatchSnapshot(expected)
@@ -41,19 +41,41 @@
"textAlignment": "left"
},
"content": [
{
"type": "text",
- "text": "ParagraphParagraph"
+ "text": "Paragrah"
}
]
}
]
}
]
}
]
+ },
+ {
+ "type": "blockContainer",
+ "attrs": {
+ "id": "2"
+ },
+ "content": [
+ {
+ "type": "paragraph",
+ "attrs": {
+ "backgroundColor": "default",
+ "textColor": "default",
+ "textAlignment": "left"
+ },
+ "content": [
+ {
+ "type": "text",
+ "text": "Paragraph"
+ }
+ ]
+ }
+ ]
}
]
}
]
}
Expected: /__w/BlockNote/BlockNote/tests/src/end-to-end/keyboardhandlers/keyboardhandlers.test.ts-snapshots/deleteShallowerBlock-json-webkit-linux.json
Received: /__w/BlockNote/BlockNote/tests/test-results/keyboardhandlers-keyboardh-9a661-lete-before-shallower-block-webkit-retry1/deleteShallowerBlock-json-actual.json
at ../utils/editor.ts:47
45 | // Remove id from docs
46 | const doc = JSON.stringify(await getDoc(page), null, 2);
> 47 | expect(doc).toMatchSnapshot(`${name}.json`);
| ^
48 | }
49 |
at compareDocToSnapshot (/__w/BlockNote/BlockNote/tests/src/utils/editor.ts:47:15)
at /__w/BlockNote/BlockNote/tests/src/end-to-end/keyboardhandlers/keyboardhandlers.test.ts:319:5
|
|
[webkit] › src/end-to-end/keyboardhandlers/keyboardhandlers.test.ts:306:7 › Check Keyboard Handlers' Behaviour › Check Delete before shallower block:
tests/src/utils/editor.ts#L47
1) [webkit] › src/end-to-end/keyboardhandlers/keyboardhandlers.test.ts:306:7 › Check Keyboard Handlers' Behaviour › Check Delete before shallower block
Error: expect(string).toMatchSnapshot(expected)
@@ -41,19 +41,41 @@
"textAlignment": "left"
},
"content": [
{
"type": "text",
- "text": "ParagraphParagraph"
+ "text": "Paragrap"
}
]
}
]
}
]
}
]
+ },
+ {
+ "type": "blockContainer",
+ "attrs": {
+ "id": "2"
+ },
+ "content": [
+ {
+ "type": "paragraph",
+ "attrs": {
+ "backgroundColor": "default",
+ "textColor": "default",
+ "textAlignment": "left"
+ },
+ "content": [
+ {
+ "type": "text",
+ "text": "Paragraph"
+ }
+ ]
+ }
+ ]
}
]
}
]
}
Expected: /__w/BlockNote/BlockNote/tests/src/end-to-end/keyboardhandlers/keyboardhandlers.test.ts-snapshots/deleteShallowerBlock-json-webkit-linux.json
Received: /__w/BlockNote/BlockNote/tests/test-results/keyboardhandlers-keyboardh-9a661-lete-before-shallower-block-webkit/deleteShallowerBlock-json-actual.json
at ../utils/editor.ts:47
45 | // Remove id from docs
46 | const doc = JSON.stringify(await getDoc(page), null, 2);
> 47 | expect(doc).toMatchSnapshot(`${name}.json`);
| ^
48 | }
49 |
at compareDocToSnapshot (/__w/BlockNote/BlockNote/tests/src/utils/editor.ts:47:15)
at /__w/BlockNote/BlockNote/tests/src/end-to-end/keyboardhandlers/keyboardhandlers.test.ts:319:5
|
|
🎭 Playwright Run Summary
43 passed (36.5s)
|
|
🎭 Playwright Run Summary
43 passed (1.0m)
|
|
🎭 Playwright Run Summary
2 skipped
92 passed (1.3m)
|
|
🎭 Playwright Run Summary
16 skipped
78 passed (1.6m)
|
|
🎭 Playwright Run Summary
1 skipped
42 passed (2.0m)
|
|
🎭 Playwright Run Summary
1 failed
[webkit] › src/end-to-end/keyboardhandlers/keyboardhandlers.test.ts:306:7 › Check Keyboard Handlers' Behaviour › Check Delete before shallower block
12 skipped
12 did not run
69 passed (3.0m)
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
blob-report-chromium-1
Expired
|
127 KB |
sha256:a4c08cf189e111431672f58d734bf8d82bb2b4ec546960b19830043af687539d
|
|
|
blob-report-chromium-2
Expired
|
52.5 KB |
sha256:8ea96651b876e7fa6e095c999df77cc1f1161dc463cae40cede5d95865149e8f
|
|
|
blob-report-firefox-1
Expired
|
113 KB |
sha256:e417505957a1e5a60b9fe3f9c9eecc7a496947a7e643a2563c7ba5b03f37c1bc
|
|
|
blob-report-firefox-2
Expired
|
53.8 KB |
sha256:95debc43c39a1850d750577abb21d4c0fda34661ebe8f75575c68d459d304ff4
|
|
|
blob-report-webkit-1
Expired
|
3.91 MB |
sha256:4bcddf45b8343c8b68221d41a971fdea74232e9beb080008b4b0dc7172160442
|
|
|
blob-report-webkit-2
Expired
|
53.1 KB |
sha256:fd3dd302ff9c68b454e7a3a1577a007946be6d033d17be1f887fde26c3902924
|
|
|
playwright-build
Expired
|
21.2 MB |
sha256:4c1bb8b25944561973fd9762b55d89290d03a37a7ceb08c928825e42f986d513
|
|
|
playwright-report-chromium-1
Expired
|
260 KB |
sha256:47674141f9837cd5797567cc42131416e457e4a7fad7fe72f2487e3fad16d076
|
|
|
playwright-report-chromium-2
Expired
|
210 KB |
sha256:0028c30d962abb8030166a317d87182c4fc3ce1822f320061a26caf3a6f53bc1
|
|
|
playwright-report-firefox-1
Expired
|
250 KB |
sha256:8c61591aa3cca96462120af21b80b4ccbcd706e1c3c4538836ab5234b464ad87
|
|
|
playwright-report-firefox-2
Expired
|
210 KB |
sha256:94d712c88cab5fb91e952b635c3015a015b2397e2b5a1564f1d0ab4c7d2a2e81
|
|
|
playwright-report-merged
Expired
|
4.45 MB |
sha256:18015b9fae517db32353be16ef41e1b63b1771c9c30a4c6110daa7b5bde9f8a3
|
|
|
playwright-report-webkit-1
Expired
|
4.38 MB |
sha256:5affe4395315b22cb0f7f9f19b7d26725109c8716d315e60d19196a19a874c6a
|
|
|
playwright-report-webkit-2
Expired
|
210 KB |
sha256:ab244d4b7a76ff502b99a82c8452f4d8c748cc9a5bbc4131629dece7144791b3
|
|