Commit 27f156a
committed
fix(dev-scripts): make gen:docs writes to docs/package.json atomic; run unit tests once in CI
Two concurrent gen:docs processes were racing on the non-atomic
read-modify-write of the shared, tracked docs/package.json in
addDependenciesToExample, so one process truncated the file to 0 bytes
while another read it -> JSON.parse('') 'Unexpected end of JSON input'
(crashed on the backend/s3 example).
Two changes:
- writeFileAtomic(): write to a unique temp file then rename() (atomic on
POSIX), and skip the write entirely when content is unchanged. Readers
now always observe complete content, never an empty file, so a plain
read+JSON.parse is safe. Used for the docs/package.json write in
addDependenciesToExample.
- CI 'Run unit tests' now calls 'vp run test' (the root test script, run
once) instead of 'vp run -r test'. The recursive form ran every
package's test AND re-spawned the root test script's filtered graph
concurrently, launching gen:docs twice. 'vp run test' runs it once and
also preserves the intended !@blocknote/xl-ai exclusion.1 parent 41df112 commit 27f156a
4 files changed
Lines changed: 35 additions & 9 deletions
File tree
- .github/workflows
- packages/dev-scripts/examples
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
| 41 | + | |
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
87 | | - | |
| 87 | + | |
88 | 88 | | |
89 | 89 | | |
90 | 90 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
| |||
165 | 166 | | |
166 | 167 | | |
167 | 168 | | |
168 | | - | |
169 | | - | |
| 169 | + | |
170 | 170 | | |
171 | 171 | | |
172 | 172 | | |
| |||
186 | 186 | | |
187 | 187 | | |
188 | 188 | | |
189 | | - | |
190 | | - | |
191 | | - | |
192 | | - | |
193 | | - | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
194 | 196 | | |
195 | 197 | | |
196 | 198 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
25 | 49 | | |
26 | 50 | | |
27 | 51 | | |
| |||
0 commit comments