Skip to content

Commit 57c459a

Browse files
committed
Implemented PR feedback
1 parent f2bfe62 commit 57c459a

4 files changed

Lines changed: 15 additions & 3 deletions

File tree

packages/core/src/blocks/Code/block.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@ export const createCodeBlockSpec = createBlockSpec(
4040
options.supportedLanguages && {
4141
selectedLanguage: block.props.language,
4242
supportedLanguages: options.supportedLanguages,
43-
createPreview:
44-
options.supportedLanguages[block.props.language].createPreview,
4543
},
4644
),
4745
toExternalHTML: (block) => createPreCode(block),

packages/core/src/blocks/Code/helpers/render/createSourceBlock.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,10 @@ export const createLanguageSelect = (
2727
select.value = selectedLanguage;
2828

2929
const handleLanguageChange = (event: Event) => {
30+
if (!editor.isEditable) {
31+
return;
32+
}
33+
3034
editor.updateBlock(block.id, {
3135
props: { language: (event.target as HTMLSelectElement).value },
3236
});

packages/core/src/blocks/Code/helpers/render/createSourceBlockWithPreview.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -252,6 +252,14 @@ export const createSourceBlockWithPreview = (
252252
createPreview: CodeBlockPreview;
253253
},
254254
) => {
255+
if (
256+
options &&
257+
"selectedLanguage" in options &&
258+
!(options.selectedLanguage in options.supportedLanguages)
259+
) {
260+
throw new Error(`Language ${options.selectedLanguage} is not supported.`);
261+
}
262+
255263
const sourceBlock = createSourceBlock(
256264
block,
257265
editor,

packages/math-block/src/helpers/getMathSource.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@ export const getMathSource = (block: { content: unknown }): string => {
77
}
88
if (Array.isArray(block.content)) {
99
return block.content
10-
.map((node) => ("text" in node ? node.text : ""))
10+
.map((node) =>
11+
node && typeof node === "object" && "text" in node ? node.text : "",
12+
)
1113
.join("");
1214
}
1315
return "";

0 commit comments

Comments
 (0)