Skip to content

Commit 5faa903

Browse files
committed
feat: update suggestion menu component
1 parent 1defbc6 commit 5faa903

4 files changed

Lines changed: 11 additions & 16 deletions

File tree

packages/ariakit/src/suggestionMenu/SuggestionMenuItem.tsx

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,9 @@ export const SuggestionMenuItem = forwardRef<
2222
document.querySelector(".bn-suggestion-menu, #ai-suggestion-menu")!, // TODO
2323
);
2424

25-
if (overflow === "top") {
26-
itemRef.current.scrollIntoView(true);
27-
} else if (overflow === "bottom") {
28-
itemRef.current.scrollIntoView(false);
25+
26+
if (overflow !== "none") {
27+
itemRef.current.scrollIntoView({ block: "nearest" });
2928
}
3029
}, [isSelected]);
3130

packages/ariakit/src/suggestionMenu/gridSuggestionMenu/GridSuggestionMenuItem.tsx

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,9 @@ export const GridSuggestionMenuItem = forwardRef<
2222
document.querySelector(".bn-grid-suggestion-menu")!,
2323
);
2424

25-
if (overflow === "top") {
26-
itemRef.current.scrollIntoView(true);
27-
} else if (overflow === "bottom") {
28-
itemRef.current.scrollIntoView(false);
25+
26+
if (overflow !== "none") {
27+
itemRef.current.scrollIntoView({ block: "nearest" });
2928
}
3029
}, [isSelected]);
3130

packages/mantine/src/suggestionMenu/SuggestionMenuItem.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,8 @@ export const SuggestionMenuItem = forwardRef<
3030
document.querySelector(".bn-suggestion-menu, #ai-suggestion-menu")!, // TODO
3131
);
3232

33-
if (overflow === "top") {
34-
itemRef.current.scrollIntoView(true);
35-
} else if (overflow === "bottom") {
36-
itemRef.current.scrollIntoView(false);
33+
if (overflow !== "none") {
34+
itemRef.current.scrollIntoView({ block: "nearest" });
3735
}
3836
}, [isSelected]);
3937

packages/mantine/src/suggestionMenu/gridSuggestionMenu/GridSuggestionMenuItem.tsx

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,9 @@ export const GridSuggestionMenuItem = forwardRef<
2424
document.querySelector(".bn-grid-suggestion-menu")!,
2525
);
2626

27-
if (overflow === "top") {
28-
itemRef.current.scrollIntoView(true);
29-
} else if (overflow === "bottom") {
30-
itemRef.current.scrollIntoView(false);
27+
28+
if (overflow !== "none") {
29+
itemRef.current.scrollIntoView({ block: "nearest" });
3130
}
3231
}, [isSelected]);
3332

0 commit comments

Comments
 (0)