Skip to content

Commit e9497e3

Browse files
authored
fix: guard hideMenuIfNotFrozen against undefined view state (#2694) (#2699)
When the EditorView is re-created (e.g. toggling editable) while the side menu is visible, a queued floating-ui scroll callback can fire after view.state has been cleared, causing a TypeError. Use optional chaining so the early return covers that case.
1 parent 15eab07 commit e9497e3

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

packages/core/src/extensions/SideMenu/SideMenu.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -785,8 +785,8 @@ export const SideMenuExtension = createExtension(({ editor }) => {
785785
* interfering with open submenus.
786786
*/
787787
hideMenuIfNotFrozen() {
788-
if (!view!.menuFrozen && view!.state!.show) {
789-
view!.state!.show = false;
788+
if (!view!.menuFrozen && view!.state?.show) {
789+
view!.state.show = false;
790790
view!.emitUpdate(view!.state!);
791791
}
792792
},

0 commit comments

Comments
 (0)