chore: comment some stuff

Author: johnnyreilly

AGENTS.md

@@ -8,6 +8,8 @@ Use `yarn` (not npm).
 
 ## Key commands
 
+Note: test scripts clean test directories first using `git clean -xfd`.
+
 ```bash
 yarn build              # compile src/ → dist/ (tsc --project "./src")
 yarn lint               # type-check + ESLint (no separate typecheck script)
@@ -43,7 +45,7 @@ yarn comparison-tests -- --save-output --single-test <name>       # regenerate o
 
 ## Execution tests (`test/execution-tests/`)
 
-Each sub-directory is a mini webpack project with a Karma/Jasmine test suite. The harness compiles the project and **runs the compiled code** — useful for asserting correct runtime behaviour. These are matrix-tested in CI across Node 20/22 and TypeScript 5.x versions.
+Each sub-directory is a mini webpack project with a Karma/Jasmine test suite. The harness compiles the project and **runs the compiled code** — useful for asserting correct runtime behaviour. These are matrix-tested in CI across multiple Node and TypeScript versions (see `.github/workflows/push.yml` for the current matrix).
 
 Full docs: [`test/execution-tests/README.md`](test/execution-tests/README.md)
 

package.json

@@ -40,7 +40,7 @@
     "ts"
   ],
   "engines": {
-    "node": ">=18.18.0"
+    "node": ">=12.0.0"
   },
   "author": "John Reilly <johnny_reilly@hotmail.com> (https://johnnyreilly.com)",
   "contributors": [

src/after-compile.ts

@@ -266,15 +266,15 @@ function provideErrorsToWebpack(
           compilation.compiler.context
         );
 
-        if (!moduleHasErrors(module, instance.isWebpack5)) {
+        // if (!moduleHasErrors(module, instance.isWebpack5)) {
           formattedErrors.forEach(error => {
             if (module.addError) {
               module.addError(error);
             } else {
               module.errors.push(error);
             }
           });
-        }
+        // }
 
         compilation.errors.push(...formattedErrors);
       });
@@ -336,15 +336,15 @@ function provideSolutionErrorsToWebpack(
           compilation.compiler.context
         );
 
-        if (!moduleHasErrors(module, instance.isWebpack5)) {
+        // if (!moduleHasErrors(module, instance.isWebpack5)) {
           formattedErrors.forEach(error => {
             if (module.addError) {
               module.addError(error);
             } else {
               module.errors.push(error);
             }
           });
-        }
+        // }
 
         compilation.errors.push(...formattedErrors);
       });
@@ -577,9 +577,9 @@ function isTSLoaderModuleError(error: any, loaderOptions: LoaderOptions) {
   );
 }
 
-function moduleHasErrors(module: webpack.Module, isWebpack5: boolean) {
-  return isWebpack5
-    ? Array.from(module.getErrors!() || []).length > 0
-    : (((module as any).errors as webpack.WebpackError[] | undefined) || [])
-        .length > 0;
-}
+// function moduleHasErrors(module: webpack.Module, isWebpack5: boolean) {
+//   return isWebpack5
+//     ? Array.from(module.getErrors!() || []).length > 0
+//     : (((module as any).errors as webpack.WebpackError[] | undefined) || [])
+//         .length > 0;
+// }

src/index.ts

@@ -1,7 +1,7 @@
 import * as crypto from 'crypto';
 import * as path from 'path';
 import type * as typescript from 'typescript';
-import type * as webpack from 'webpack';
+import * as webpack from 'webpack';
 
 import * as constants from './constants';
 import {
@@ -32,6 +32,8 @@ import { SourceMapConsumer, SourceMapGenerator } from 'source-map';
 
 const loaderOptionsCache: LoaderOptionsCache = {};
 
+const isWebpack5 = webpack.version.startsWith('5.');
+
 /**
  * The entry point for ts-loader
  */
@@ -43,7 +45,6 @@ function loader(
   // eslint-disable-next-line @typescript-eslint/no-unused-expressions
   this.cacheable && this.cacheable();
   const callback = this.async();
-  const isWebpack5 = typeof this.getOptions === 'function';
   const options = getLoaderOptions(this, isWebpack5);
   const instanceOrError = getTypeScriptInstance(options, this, isWebpack5);