Experiment with adding webpack 4 support back by Copilot · Pull Request #1697 · TypeStrong/ts-loader

Copilot · 2026-05-21T17:11:42Z

Identify actionable new @copilot comments
Enumerate src/**/*.ts files changed in this PR
Review changed TypeScript code for potential performance regressions
Summarize findings (including if none) with concrete file references
Reply on PR comment with review results

Agent-Logs-Url: https://github.com/TypeStrong/ts-loader/sessions/74b74f2d-76ad-4022-9635-77d0c5acce76 Co-authored-by: johnnyreilly <1010525+johnnyreilly@users.noreply.github.com>

Agent-Logs-Url: https://github.com/TypeStrong/ts-loader/sessions/e322b7ed-e010-4d60-9a2d-3672c9d55324 Co-authored-by: johnnyreilly <1010525+johnnyreilly@users.noreply.github.com>

Agent-Logs-Url: https://github.com/TypeStrong/ts-loader/sessions/55527c90-acbb-42e1-b384-95f6fdfe9283 Co-authored-by: johnnyreilly <1010525+johnnyreilly@users.noreply.github.com>

johnnyreilly · 2026-05-21T19:20:12Z

@copilot please consistently use instance.isWebpack5 to decide strategy

Agent-Logs-Url: https://github.com/TypeStrong/ts-loader/sessions/84c8d79e-30f1-46f5-baf3-bc669466d3ba Co-authored-by: johnnyreilly <1010525+johnnyreilly@users.noreply.github.com>

Copilot · 2026-05-21T19:23:59Z

@copilot please consistently use instance.isWebpack5 to decide strategy

Done in 5d7ab2f. I updated the remaining strategy checks to consistently branch on instance.isWebpack5 (including cached/reused instance paths and build-dependency registration) rather than using direct feature detection at those decision points.

johnnyreilly · 2026-05-21T19:44:31Z

 } from './interfaces';
 import { getInputFileNameFromOutput } from './instances';
+
+export const isWebpack5 = !!(webpack as any).sources;


Is this necessary @copilot?

Good catch — no, it wasn’t necessary there. I removed isWebpack5 from utils.ts and localized detection to instance setup in instances.ts in 78fa91f, so strategy still flows through instance.isWebpack5 without the extra utils export.

Agent-Logs-Url: https://github.com/TypeStrong/ts-loader/sessions/faa27c75-efcd-4e5a-8062-443dce3bf610 Co-authored-by: johnnyreilly <1010525+johnnyreilly@users.noreply.github.com>

johnnyreilly · 2026-05-21T20:05:52Z

-      (error: any) => error.loaderSource !== tsLoaderSource(loaderOptions)
-    )
-    .forEach(error => module.addError(error));
+  const webpackModule = module as any;


@copilot I don't think the webpack5 code needs to use webpackModule it can use module

Updated in 7b3cd3e — webpack 5 path now uses module directly (getWarnings/getErrors/clearWarningsAndErrors) and keeps webpackModule only for the webpack 4 branch.

Agent-Logs-Url: https://github.com/TypeStrong/ts-loader/sessions/5d863b98-4c30-478e-8205-7c3a7387b0f1 Co-authored-by: johnnyreilly <1010525+johnnyreilly@users.noreply.github.com>

Copilot · 2026-05-21T20:12:17Z

@copilot please consistently use instance.isWebpack5 to decide strategy

Handled in 5d7ab2f and retained in follow-ups: strategy decisions branch on instance.isWebpack5 consistently.

johnnyreilly · 2026-05-24T09:08:18Z

@copilot yarn comparison-tests --single-test nodeModulesMeaningfulErrorWhenImportingTs succeeds on my machine but fails in CI - please investigate

…utput Agent-Logs-Url: https://github.com/TypeStrong/ts-loader/sessions/df34fd80-1718-4769-8f01-fbc15f96c807 Co-authored-by: johnnyreilly <1010525+johnnyreilly@users.noreply.github.com>

Copilot · 2026-05-24T09:20:31Z

@copilot yarn comparison-tests --single-test nodeModulesMeaningfulErrorWhenImportingTs succeeds on my machine but fails in CI - please investigate

Investigated and fixed in 7e6d119. CI logs showed nodeModulesMeaningfulErrorWhenImportingTs failing on output normalization around module error attribution. I updated after-compile to use runtime module capabilities when determining module resource/error paths (instead of assuming a single webpack API shape), and tagged the no-output loader error in index.ts so ts-loader-owned module errors are consistently filtered/re-added. I re-ran yarn build, yarn lint, and yarn comparison-tests -- --single-test nodeModulesMeaningfulErrorWhenImportingTs (plus errors) successfully.

johnnyreilly · 2026-05-24T13:58:31Z

@copilot after the last commit all yarn comparison-tests are failing

Agent-Logs-Url: https://github.com/TypeStrong/ts-loader/sessions/22ab19a4-eb4b-4cf6-8efc-423776e48f2d Co-authored-by: johnnyreilly <1010525+johnnyreilly@users.noreply.github.com>

Copilot · 2026-05-24T14:04:13Z

@copilot after the last commit all yarn comparison-tests are failing

Fixed in 90b2860. I checked the failing CI jobs and they were failing before test execution with TS2416 type errors from @types/eslint-scope after the last lockfile change. I restored the prior lockfile resolution (the last commit had collapsed @types/eslint@*), which unblocked comparison test compilation. I then re-ran yarn build, yarn lint, yarn comparison-tests -- --single-test errors, and yarn comparison-tests -- --single-test nodeModulesMeaningfulErrorWhenImportingTs successfully.

johnnyreilly · 2026-05-25T09:24:18Z

Starting to write this up here: johnnyreilly/blog.johnnyreilly.com#1109

johnnyreilly · 2026-05-25T09:33:44Z

@copilot review the src/**.*ts files in this PR with an eye to identifying any potential performance issues this PR could introduce. There may be none. Tell me what issues might exist. Make no changes - let me decide.

Copilot · 2026-05-25T09:37:56Z

@copilot review the src/**.*ts files in this PR with an eye to identifying any potential performance issues this PR could introduce. There may be none. Tell me what issues might exist. Make no ch...

Reviewed at 06def35 with a performance-focused pass over src/**/*.ts changes in this PR. I don’t see any high-confidence new perf regressions.

Possible low-risk hotspots to keep an eye on:

src/after-compile.ts:131-146 (determineModules): now also checks resourceResolveData?.path; this may increase modules considered in the map in some builds.
src/watch-run.ts:42-49 (timestamp normalization): extra per-file branching on each watch cycle; likely negligible, but it is new work on very large file sets.

Everything else I reviewed looks neutral or slightly better for runtime cost (no obvious new heavy loops/allocations in hot paths). No code changes made.

feat: widen webpack peer support

8465fa4

Agent-Logs-Url: https://github.com/TypeStrong/ts-loader/sessions/74b74f2d-76ad-4022-9635-77d0c5acce76 Co-authored-by: johnnyreilly <1010525+johnnyreilly@users.noreply.github.com>

Copilot AI assigned Copilot and johnnyreilly May 21, 2026

Copilot created this pull request from a session on behalf of johnnyreilly May 21, 2026 17:11 View session

Copilot started work on behalf of johnnyreilly May 21, 2026 17:13 View session

chore: plan isWebpack5 refactor

a896f16

Agent-Logs-Url: https://github.com/TypeStrong/ts-loader/sessions/e322b7ed-e010-4d60-9a2d-3672c9d55324 Co-authored-by: johnnyreilly <1010525+johnnyreilly@users.noreply.github.com>

Copilot finished work on behalf of johnnyreilly May 21, 2026 18:12

Copilot AI requested a review from johnnyreilly May 21, 2026 18:12

Copilot started work on behalf of johnnyreilly May 21, 2026 18:18 View session

Copilot finished work on behalf of johnnyreilly May 21, 2026 18:21

Copilot started work on behalf of johnnyreilly May 21, 2026 18:26 View session

refactor: propagate webpack major version through instance flow

cf368a5

Agent-Logs-Url: https://github.com/TypeStrong/ts-loader/sessions/55527c90-acbb-42e1-b384-95f6fdfe9283 Co-authored-by: johnnyreilly <1010525+johnnyreilly@users.noreply.github.com>

Copilot finished work on behalf of johnnyreilly May 21, 2026 18:45

Copilot started work on behalf of johnnyreilly May 21, 2026 19:20 View session

johnnyreilly changed the title ~~Align webpack support metadata with current CI coverage~~ Experiment with adding webpack 4 support back May 21, 2026

refactor: use instance.isWebpack5 consistently for strategy decisions

5d7ab2f

Agent-Logs-Url: https://github.com/TypeStrong/ts-loader/sessions/84c8d79e-30f1-46f5-baf3-bc669466d3ba Co-authored-by: johnnyreilly <1010525+johnnyreilly@users.noreply.github.com>

Copilot finished work on behalf of johnnyreilly May 21, 2026 19:24

johnnyreilly reviewed May 21, 2026

View reviewed changes

Copilot started work on behalf of johnnyreilly May 21, 2026 19:44 View session

refactor: localize webpack5 detection to instance setup

78fa91f

Agent-Logs-Url: https://github.com/TypeStrong/ts-loader/sessions/faa27c75-efcd-4e5a-8062-443dce3bf610 Co-authored-by: johnnyreilly <1010525+johnnyreilly@users.noreply.github.com>

Copilot AI requested a review from johnnyreilly May 21, 2026 19:51

Copilot finished work on behalf of johnnyreilly May 21, 2026 19:51

johnnyreilly reviewed May 21, 2026

View reviewed changes

Copilot started work on behalf of johnnyreilly May 21, 2026 20:06 View session

refactor: use module methods directly in webpack5 error cleanup

7b3cd3e

Agent-Logs-Url: https://github.com/TypeStrong/ts-loader/sessions/5d863b98-4c30-478e-8205-7c3a7387b0f1 Co-authored-by: johnnyreilly <1010525+johnnyreilly@users.noreply.github.com>

Copilot AI requested a review from johnnyreilly May 21, 2026 20:12

Copilot finished work on behalf of johnnyreilly May 21, 2026 20:12

Copilot started work on behalf of johnnyreilly May 24, 2026 09:08 View session

fix: stabilize nodeModulesMeaningfulErrorWhenImportingTs comparison o…

7e6d119

…utput Agent-Logs-Url: https://github.com/TypeStrong/ts-loader/sessions/df34fd80-1718-4769-8f01-fbc15f96c807 Co-authored-by: johnnyreilly <1010525+johnnyreilly@users.noreply.github.com>

Copilot finished work on behalf of johnnyreilly May 24, 2026 09:21

Copilot started work on behalf of johnnyreilly May 24, 2026 13:58 View session

fix: restore lockfile resolution to unblock comparison tests

90b2860

Agent-Logs-Url: https://github.com/TypeStrong/ts-loader/sessions/22ab19a4-eb4b-4cf6-8efc-423776e48f2d Co-authored-by: johnnyreilly <1010525+johnnyreilly@users.noreply.github.com>

Copilot finished work on behalf of johnnyreilly May 24, 2026 14:04

johnnyreilly added 7 commits May 24, 2026 18:12

fix: do not use feature detection

d66fb20

fix: invalid output for test

d7b3285

fix: remove hallucinations

11ed78d

chore: update eslint

bd3037c

fix: remove more hallucinations / add min ts version to matrix

5c7376d

fix: webpack 4

d65fd4f

chore: drop old

06def35

Copilot started work on behalf of johnnyreilly May 25, 2026 09:33 View session

Copilot finished work on behalf of johnnyreilly May 25, 2026 09:38

johnnyreilly added 8 commits May 25, 2026 10:39

fix: make loader-utils * as a peerDependencies

d74e919

fix: watchRun should cater for webpack 4 dates

351a12e

fix: webpack 4 errors

811d8e5

fix: lint

8e001a6

fix: loaderSource -> details

05d766d

fix: WebpackError wouldn't work for webpack 4

e1fe960

fix: nits

30b3597

fix: whoops

c4fb493

Uh oh!

Conversation

Copilot AI commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

johnnyreilly commented May 21, 2026

Uh oh!

Copilot AI commented May 21, 2026

Uh oh!

johnnyreilly May 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 21, 2026

Choose a reason for hiding this comment

Uh oh!

johnnyreilly May 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented May 21, 2026

Uh oh!

johnnyreilly commented May 24, 2026

Uh oh!

Copilot AI commented May 24, 2026

Uh oh!

johnnyreilly commented May 24, 2026

Uh oh!

Copilot AI commented May 24, 2026

Uh oh!

johnnyreilly commented May 25, 2026

Uh oh!

johnnyreilly commented May 25, 2026

Uh oh!

Copilot AI commented May 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented May 21, 2026 •

edited

Loading