refactor(runner): tighten assertion output filtering

Author: Chemaclass

src/runner.sh

@@ -984,36 +984,6 @@ function bashunit::runner::is_simple_progress_output() {
   return 0
 }
 
-function bashunit::runner::line_starts_with_result_marker() {
-  local line="$1"
-  local marker
-  local -a result_markers
-  result_markers=(
-    "${_BASHUNIT_COLOR_PASSED}✓ Passed"
-    "${_BASHUNIT_COLOR_FAILED}✗ Failed"
-    "${_BASHUNIT_COLOR_FAILED}✗ Error"
-    "${_BASHUNIT_COLOR_SKIPPED}↷ Skipped"
-    "${_BASHUNIT_COLOR_INCOMPLETE}✒ Incomplete"
-    "${_BASHUNIT_COLOR_SNAPSHOT}✎ Snapshot"
-    "${_BASHUNIT_COLOR_RISKY}⚠ Risky"
-    "✓ Passed"
-    "✗ Failed"
-    "✗ Error"
-    "↷ Skipped"
-    "✒ Incomplete"
-    "✎ Snapshot"
-    "⚠ Risky"
-  )
-
-  for marker in "${result_markers[@]}"; do
-    case "$line" in
-    "$marker"*) return 0 ;;
-    esac
-  done
-
-  return 1
-}
-
 function bashunit::runner::line_exists_in_output() {
   local needle="$1"
   local haystack="$2"
@@ -1039,9 +1009,6 @@ function bashunit::runner::extract_assertion_runtime_output() {
     if bashunit::runner::is_simple_progress_output "$line"; then
       continue
     fi
-    if bashunit::runner::line_starts_with_result_marker "$line"; then
-      continue
-    fi
 
     [ -n "$filtered_output" ] && filtered_output="$filtered_output"$'\n'
     filtered_output="$filtered_output$line"

tests/unit/runner_test.sh

@@ -35,3 +35,15 @@ function test_extract_assertion_runtime_output_keeps_user_output_after_status_ou
 
   assert_same "diagnostic after pass" "$actual"
 }
+
+function test_extract_assertion_runtime_output_keeps_user_output_that_looks_like_status_output() {
+  local runtime_output
+  runtime_output=$'✗ Failed: emitted by the code under test\n✗ Failed: Example'
+  local rendered_assertion_output
+  rendered_assertion_output="✗ Failed: Example"
+
+  local actual
+  actual="$(bashunit::runner::extract_assertion_runtime_output "$runtime_output" "$rendered_assertion_output")"
+
+  assert_same "✗ Failed: emitted by the code under test" "$actual"
+}