refactor(runner): extract login profile sourcing and verbose summary (#653)

Author: Chemaclass

CHANGELOG.md

@@ -11,6 +11,7 @@
 - Split documentation into its own npm workspace under `docs/`: VitePress dependencies and `docs:*` scripts moved out of the root `package.json` so the published npm package stays slim. CI workflows, release script and contributing docs updated for the new `cd docs && npm ci` workflow; `make docs/{install,dev,build,preview}` shortcuts added
 - Guard root `package.json` against accidental regression of the docs-split: assert no `dependencies`/`devDependencies`/`peerDependencies`/`scripts` blocks ever return to the published manifest
 - `release.sh` now treats `docs/package.json` as a first-class `RELEASE_FILES` entry, so the release flow backs it up, restores it on rollback, and stages it without inline duplication. Backup/restore preserves nested directory paths
+- Extract `bashunit::runner::source_login_shell_profiles` and `bashunit::runner::print_verbose_test_summary` from the 320-line `run_test` body so the hot path reads top-down without inline `~/.profile` sourcing or printf scaffolding
 - Centralize all ANSI escape emission through the existing `_BASHUNIT_COLOR_*` constants. `src/coverage.sh` and the `--watch` screen-clear in `src/main.sh` no longer hardcode escape sequences (#247)
 - Speed up coverage report generation by collapsing the per-line non-executable pattern checks in `bashunit::coverage::is_executable_line` into a single combined `grep` invocation (#636)
 - Speed up coverage report generation further by combining executable + hit counting into a single source-file pass (`bashunit::coverage::compute_file_coverage`) shared across text/lcov/html reporters, removing per-line `get_line_hits` scans of the coverage data file (#636)

src/runner.sh

@@ -12,6 +12,37 @@ function bashunit::runner::restore_workdir() {
   cd "$BASHUNIT_WORKING_DIR" 2>/dev/null || true
 }
 
+function bashunit::runner::source_login_shell_profiles() {
+  # shellcheck disable=SC1091
+  [ -f /etc/profile ] && source /etc/profile 2>/dev/null || true
+  # shellcheck disable=SC1090
+  [ -f ~/.bash_profile ] && source ~/.bash_profile 2>/dev/null || true
+  # shellcheck disable=SC1090
+  [ -f ~/.bash_login ] && source ~/.bash_login 2>/dev/null || true
+  # shellcheck disable=SC1090
+  [ -f ~/.profile ] && source ~/.profile 2>/dev/null || true
+}
+
+function bashunit::runner::print_verbose_test_summary() {
+  local test_file=$1
+  local fn_name=$2
+  local duration=$3
+  local test_execution_result=$4
+
+  if bashunit::env::is_simple_output_enabled; then
+    echo ""
+  fi
+
+  printf '%*s\n' "$TERMINAL_WIDTH" '' | tr ' ' '='
+  printf "%s\n" "File:     $test_file"
+  printf "%s\n" "Function: $fn_name"
+  printf "%s\n" "Duration: $duration ms"
+  local raw_text=${test_execution_result%%##ASSERTIONS_*}
+  [ -n "$raw_text" ] && printf "%s" "Raw text: $raw_text"
+  printf "%s\n" "##ASSERTIONS_${test_execution_result#*##ASSERTIONS_}"
+  printf '%*s\n' "$TERMINAL_WIDTH" '' | tr ' ' '-'
+}
+
 function bashunit::runner::wait_for_job_slot() {
   local max_jobs="${BASHUNIT_PARALLEL_JOBS:-0}"
   if [ "$max_jobs" -le 0 ]; then
@@ -627,16 +658,8 @@ function bashunit::runner::run_test() {
     trap "exit_code=\$?; bashunit::runner::cleanup_on_exit \"$test_file\" \"\$exit_code\"" EXIT
     bashunit::state::initialize_assertions_count
 
-    # Source login shell profiles if enabled
     if bashunit::env::is_login_shell_enabled; then
-      # shellcheck disable=SC1091
-      [ -f /etc/profile ] && source /etc/profile 2>/dev/null || true
-      # shellcheck disable=SC1090
-      [ -f ~/.bash_profile ] && source ~/.bash_profile 2>/dev/null || true
-      # shellcheck disable=SC1090
-      [ -f ~/.bash_login ] && source ~/.bash_login 2>/dev/null || true
-      # shellcheck disable=SC1090
-      [ -f ~/.profile ] && source ~/.profile 2>/dev/null || true
+      bashunit::runner::source_login_shell_profiles
     fi
 
     # Enable coverage tracking early to include set_up/tear_down hooks
@@ -676,18 +699,8 @@ function bashunit::runner::run_test() {
   local duration=$((duration_ns / 1000000))
 
   if bashunit::env::is_verbose_enabled; then
-    if bashunit::env::is_simple_output_enabled; then
-      echo ""
-    fi
-
-    printf '%*s\n' "$TERMINAL_WIDTH" '' | tr ' ' '='
-    printf "%s\n" "File:     $test_file"
-    printf "%s\n" "Function: $fn_name"
-    printf "%s\n" "Duration: $duration ms"
-    local raw_text=${test_execution_result%%##ASSERTIONS_*}
-    [ -n "$raw_text" ] && printf "%s" "Raw text: ${test_execution_result%%##ASSERTIONS_*}"
-    printf "%s\n" "##ASSERTIONS_${test_execution_result#*##ASSERTIONS_}"
-    printf '%*s\n' "$TERMINAL_WIDTH" '' | tr ' ' '-'
+    bashunit::runner::print_verbose_test_summary \
+      "$test_file" "$fn_name" "$duration" "$test_execution_result"
   fi
 
   local subshell_output=$(bashunit::runner::decode_subshell_output "$test_execution_result")