fix(runner): stabilize --log-gha tests under parallel strict mode

- Optimize GHA message encoder: drop awk+sed pipeline, use Bash 3.0+
  parameter expansion `${var//pat/repl}` for percent-encoding.
- Acceptance tests: tolerate nonzero exit from inner bashunit run so
  `set -e` from --strict does not abort before assertions, and use a
  mktemp path to avoid filename collisions.

Author: Chemaclass

src/reports.sh

@@ -120,12 +120,15 @@ function bashunit::reports::generate_junit_xml() {
 
 function bashunit::reports::__gha_encode() {
   local text="$1"
-  # Strip ANSI escape sequences, then percent-encode reserved chars
-  # (see GitHub Actions workflow-commands docs: %25, %0A, %0D)
-  echo "$text" \
-    | sed -e 's/\x1b\[[0-9;]*[a-zA-Z]//g' \
-    | awk 'BEGIN{ORS=""} {gsub(/%/,"%25"); gsub(/\r/,"%0D"); print; if (NR>0) print "%0A"}' \
-    | sed -e 's/%0A$//'
+  # Strip ANSI escape sequences first (one sed call)
+  text=$(printf '%s' "$text" | sed -e 's/\x1b\[[0-9;]*[a-zA-Z]//g')
+  # Percent-encode reserved chars per GHA workflow-commands spec.
+  # Bash 3.0+ parameter expansion avoids extra awk/sed calls.
+  # Order matters: encode '%' first so the sequences we inject stay literal.
+  text="${text//%/%25}"
+  text="${text//$'\r'/%0D}"
+  text="${text//$'\n'/%0A}"
+  printf '%s' "$text"
 }
 
 function bashunit::reports::generate_gha_log() {

tests/acceptance/bashunit_log_gha_test.sh

@@ -7,21 +7,25 @@ function set_up_before_script() {
 
 function test_bashunit_when_log_gha_option() {
   local test_file=./tests/acceptance/fixtures/test_bashunit_when_log_junit.sh
+  local log_file
+  log_file=$(mktemp "${TMPDIR:-/tmp}/bashunit-gha-opt.XXXXXX")
 
-  ./bashunit --no-parallel --env "$TEST_ENV_FILE" --log-gha custom.log "$test_file" >/dev/null
+  # Inner suite has a failing test, so bashunit exits nonzero; tolerate it
+  # so the acceptance test keeps running under --strict (set -e).
+  ./bashunit --no-parallel --env "$TEST_ENV_FILE" --log-gha "$log_file" "$test_file" >/dev/null || true
 
-  assert_file_exists custom.log
-  assert_contains "::error file=$test_file" "$(cat custom.log)"
-  assert_contains "title=Failure" "$(cat custom.log)"
-  rm custom.log
+  assert_file_exists "$log_file"
+  assert_contains "::error file=$test_file" "$(cat "$log_file")"
+  assert_contains "title=Failure" "$(cat "$log_file")"
+  rm -f "$log_file"
 }
 
 function test_bashunit_when_log_gha_env() {
   local test_file=./tests/acceptance/fixtures/test_bashunit_when_log_junit.sh
 
-  ./bashunit --no-parallel --env "$TEST_ENV_FILE_BASHUNIT_LOG_GHA" "$test_file" >/dev/null
+  ./bashunit --no-parallel --env "$TEST_ENV_FILE_BASHUNIT_LOG_GHA" "$test_file" >/dev/null || true
 
   assert_file_exists log-gha.txt
   assert_contains "::error" "$(cat log-gha.txt)"
-  rm log-gha.txt
+  rm -f log-gha.txt
 }