refactor: unit/assert_snapshot_test

Author: Chemaclass

tests/unit/assert_snapshot_test.sh

@@ -9,18 +9,18 @@ function test_successful_assert_match_snapshot() {
 }
 
 function test_creates_a_snapshot() {
-  local snapshot_path=tests/unit/snapshots/assert_snapshot_test_sh.test_creates_a_snapshot.snapshot
+  # shellcheck disable=SC2155
+  local snapshot_path="$(temp_dir)/assert_snapshot_test_sh.test_creates_a_snapshot.snapshot"
   local expected=$((_ASSERTIONS_SNAPSHOT + 1))
 
-  assert_file_not_exists $snapshot_path
-
-  assert_match_snapshot "Expected snapshot"
+  assert_file_not_exists "$snapshot_path"
+  assert_match_snapshot "Expected snapshot" "$snapshot_path"
 
   assert_same "$expected" "$_ASSERTIONS_SNAPSHOT"
-  assert_file_exists $snapshot_path
-  assert_same "Expected snapshot" "$(cat $snapshot_path)"
+  assert_file_exists "$snapshot_path"
+  assert_same "Expected snapshot" "$(cat "$snapshot_path")"
 
-  rm $snapshot_path
+  rm -rf "$temp_dir"
 }
 
 function test_unsuccessful_assert_match_snapshot() {
@@ -47,22 +47,20 @@ function test_successful_assert_match_snapshot_ignore_colors() {
   assert_empty "$(assert_match_snapshot_ignore_colors "$colored")"
 }
 
+# shellcheck disable=SC2155
 function test_creates_a_snapshot_ignore_colors() {
-  local snapshot_path=tests/unit/snapshots/assert_snapshot_test_sh.test_creates_a_snapshot_ignore_colors.snapshot
+  local snapshot_path="$(temp_dir)/assert_snapshot_test_sh.test_creates_a_snapshot_ignore_colors.snapshot"
   local expected=$((_ASSERTIONS_SNAPSHOT + 1))
 
-  assert_file_not_exists $snapshot_path
-
-  local colored
-  colored=$(printf '\e[32mExpected\e[0m snapshot')
-
-  assert_match_snapshot_ignore_colors "$colored"
+  assert_file_not_exists "$snapshot_path"
+  local colored=$(printf '\e[32mExpected\e[0m snapshot')
+  assert_match_snapshot_ignore_colors "$colored" "$snapshot_path"
 
   assert_same "$expected" "$_ASSERTIONS_SNAPSHOT"
-  assert_file_exists $snapshot_path
-  assert_same "Expected snapshot" "$(cat $snapshot_path)"
+  assert_file_exists "$snapshot_path"
+  assert_same "Expected snapshot" "$(cat "$snapshot_path")"
 
-  rm $snapshot_path
+  rm -rf "$temp_dir"
 }
 
 function test_unsuccessful_assert_match_snapshot_ignore_colors() {
@@ -90,9 +88,8 @@ function test_assert_match_snapshot_with_placeholder() {
     skip "not supported on alpine" && return
   fi
 
-  local temp_dir
-  temp_dir=$(mktemp -d)
-  local snapshot_path="$temp_dir/assert_snapshot_test_sh.test_assert_match_snapshot_with_placeholder.snapshot"
+  # shellcheck disable=SC2155
+  local snapshot_path="$(temp_dir)/assert_snapshot_test_sh.test_assert_match_snapshot_with_placeholder.snapshot"
   echo 'Run at ::ignore::' > "$snapshot_path"
 
   assert_empty "$(assert_match_snapshot "Run at $(date)" "$snapshot_path")"
@@ -105,9 +102,8 @@ function test_assert_match_snapshot_with_custom_placeholder() {
     skip "not supported on alpine" && return
   fi
 
-  local temp_dir
-  temp_dir=$(mktemp -d)
-  local snapshot_path="$temp_dir/assert_snapshot_test_sh.test_assert_match_snapshot_with_custom_placeholder.snapshot"
+  # shellcheck disable=SC2155
+  local snapshot_path="$(temp_dir)/assert_snapshot_test_sh.test_assert_match_snapshot_with_custom_placeholder.snapshot"
   echo 'Value __ANY__' > "$snapshot_path"
 
   export BASHUNIT_SNAPSHOT_PLACEHOLDER='__ANY__'