fix: use local -a for safe Bash 3.0 array init, fix variable scoping

Author: Chemaclass

src/assert.sh

@@ -668,8 +668,7 @@ function assert_line_count() {
   bashunit::assert::should_skip && return 0
 
   local expected="$1"
-  # Bash 3.0 compatible array initialization
-  local input_arr; [[ $# -gt 1 ]] && input_arr=("${@:2}")
+  local -a input_arr=(); [[ $# -gt 1 ]] && input_arr=("${@:2}")
   local input_str
   input_str=$(printf '%s\n' ${input_arr+"${input_arr[@]}"})
 

src/assert_arrays.sh

@@ -10,8 +10,7 @@ function assert_array_contains() {
   label="$(bashunit::helper::normalize_test_function_name "$test_fn")"
   shift
 
-  # Bash 3.0 compatible array initialization
-  local actual; [[ $# -gt 0 ]] && actual=("$@")
+  local -a actual=(); [[ $# -gt 0 ]] && actual=("$@")
 
   if ! [[ "${actual[*]:-}" == *"$expected"* ]]; then
     bashunit::assert::mark_failed
@@ -31,8 +30,7 @@ function assert_array_not_contains() {
   local label
   label="$(bashunit::helper::normalize_test_function_name "$test_fn")"
   shift
-  # Bash 3.0 compatible array initialization
-  local actual; [[ $# -gt 0 ]] && actual=("$@")
+  local -a actual=(); [[ $# -gt 0 ]] && actual=("$@")
 
   if [[ "${actual[*]:-}" == *"$expected"* ]]; then
     bashunit::assert::mark_failed

src/benchmark.sh

@@ -62,8 +62,7 @@ function bashunit::benchmark::run_function() {
   local revs=$2
   local its=$3
   local max_ms=$4
-  # Declare without =() for Bash 3.0 compatibility with set -u
-  local durations
+  local -a durations=()
   local durations_count=0
 
   for ((i=1; i<=its; i++)); do

src/coverage.sh

@@ -19,8 +19,7 @@ _BASHUNIT_COVERAGE_TEST_HITS_FILE="${_BASHUNIT_COVERAGE_TEST_HITS_FILE:-}"
 function bashunit::coverage::auto_discover_paths() {
   local project_root
   project_root="$(pwd)"
-  # Bash 3.0 compatible array initialization
-  local discovered_paths
+  local -a discovered_paths=()
   local discovered_paths_count=0
 
   for test_file in "$@"; do
@@ -765,8 +764,7 @@ function bashunit::coverage::report_html() {
   # Collect file data for index
   local total_executable=0
   local total_hit=0
-  # Declare without =() for Bash 3.0 compatibility with set -u
-  local file_data
+  local -a file_data=()
   local file_data_count=0
 
   while IFS= read -r file; do
@@ -818,7 +816,7 @@ function bashunit::coverage::generate_index_html() {
   local tests_failed="$7"
   shift 7
   # Handle array passed as arguments - Bash 3.0 compatible
-  local file_data
+  local -a file_data=()
   local file_count=0
   if [[ $# -gt 0 ]]; then
     file_data=("$@")
@@ -1175,8 +1173,7 @@ function bashunit::coverage::generate_file_html() {
   local uncovered=$((executable - hit))
 
   # Pre-load all line hits into indexed array (performance optimization)
-  # Bash 3.0 compatible: declare without =()
-  local hits_by_line
+  local -a hits_by_line=()
   local _ln _cnt
   while IFS=: read -r _ln _cnt; do
     hits_by_line[_ln]=$_cnt
@@ -1185,8 +1182,7 @@ function bashunit::coverage::generate_file_html() {
   # Pre-load test hits data into indexed array (for tooltips)
   # Index: line number, Value: newline-separated list of "test_file:test_function"
   # Using indexed array for Bash 3.0 compatibility (no associative arrays)
-  # Bash 3.0 compatible: declare without =()
-  local tests_by_line
+  local -a tests_by_line=()
   local _line_and_test
   while IFS= read -r _line_and_test; do
     [[ -z "$_line_and_test" ]] && continue

src/helpers.sh

@@ -93,8 +93,7 @@ function bashunit::helper::escape_single_quotes() {
 function bashunit::helper::interpolate_function_name() {
   local function_name="$1"
   shift
-  # Bash 3.0 compatible array initialization
-  local args
+  local -a args=()
   local args_count=$#
   [[ $# -gt 0 ]] && args=("$@")
   local result="$function_name"
@@ -339,15 +338,15 @@ function bashunit::helper::find_total_tests() {
 
             local count=0
             if [[ -n "$filtered_functions" ]]; then
-                # Bash 3.0 compatible: separate declaration and assignment for arrays
-                local functions_to_run
+                local -a functions_to_run=()
                 # shellcheck disable=SC2206
                 functions_to_run=($filtered_functions)
+                # shellcheck disable=SC2034
+                local -a provider_data=()
+                local provider_data_count=0
                 for fn_name in "${functions_to_run[@]}"; do
-                    # Declare without =() for Bash 3.0 compatibility with set -u
-                    # shellcheck disable=SC2034
-                    local provider_data
-                    local provider_data_count=0
+                    provider_data=()
+                    provider_data_count=0
                     while IFS=" " read -r line; do
                         [[ -z "$line" ]] && continue
                         # shellcheck disable=SC2034

src/learn.sh

@@ -1157,8 +1157,7 @@ function test_backup_failure_when_source_missing() {
   fi
 
   # Verify the test has key components
-  # Declare without =() for Bash 3.0 compatibility with set -u
-  local missing_components
+  local -a missing_components=()
   local missing_components_count=0
 
   if ! grep -q "function set_up()" "$test_file"; then

src/main.sh

@@ -5,10 +5,9 @@
 #############################
 function bashunit::main::cmd_test() {
   local filter=""
-  # Declare without =() for Bash 3.0 compatibility with set -u
-  local raw_args
+  local -a raw_args=()
   local raw_args_count=0
-  local args
+  local -a args=()
   local args_count=0
   local assert_fn=""
   local _bashunit_coverage_opt_set=false
@@ -258,10 +257,9 @@ function bashunit::main::cmd_test() {
 #############################
 function bashunit::main::cmd_bench() {
   local filter=""
-  # Declare without =() for Bash 3.0 compatibility with set -u
-  local raw_args
+  local -a raw_args=()
   local raw_args_count=0
-  local args
+  local -a args=()
   local args_count=0
 
   export BASHUNIT_BENCH_MODE=true
@@ -621,8 +619,7 @@ function bashunit::main::handle_stop_on_failure_sync() {
 
 function bashunit::main::exec_assert() {
   local original_assert_fn=$1
-  # Bash 3.0 compatible array initialization
-  local args
+  local -a args=()
   local args_count=$(($# - 1))
   [[ $# -gt 1 ]] && args=("${@:2}")
 

src/runner.sh

@@ -15,11 +15,9 @@ function bashunit::runner::restore_workdir() {
 function bashunit::runner::load_test_files() {
   local filter=$1
   shift
-  # Bash 3.0 compatible array initialization
-  local files
+  local -a files=()
   [[ $# -gt 0 ]] && files=("$@")
-  # Declare without =() for Bash 3.0 compatibility with set -u
-  local scripts_ids
+  local -a scripts_ids=()
   local scripts_ids_count=0
 
   # Initialize coverage tracking if enabled
@@ -112,8 +110,7 @@ function bashunit::runner::load_test_files() {
 function bashunit::runner::load_bench_files() {
   local filter=$1
   shift
-  # Bash 3.0 compatible array initialization
-  local files
+  local -a files=()
   [[ $# -gt 0 ]] && files=("$@")
 
   for bench_file in ${files+"${files[@]}"}; do
@@ -207,8 +204,7 @@ function bashunit::runner::parse_data_provider_args() {
   local i
   local arg
   local encoded_arg
-  # Bash 3.0 compatible array initialization
-  local args
+  local -a args=()
   local args_count=0
 
   # Check for shell metacharacters that would break eval or cause globbing
@@ -313,8 +309,7 @@ function bashunit::runner::call_test_functions() {
   local filtered_functions
   filtered_functions=$(bashunit::helper::get_functions_to_run \
     "$prefix" "$filter" "$_BASHUNIT_CACHED_ALL_FUNCTIONS")
-  # Bash 3.0 compatible array initialization
-  local functions_to_run
+  local -a functions_to_run=()
   local functions_to_run_count=0
   local _fn
   while IFS= read -r _fn; do
@@ -329,15 +324,18 @@ function bashunit::runner::call_test_functions() {
 
   bashunit::helper::check_duplicate_functions "$script" || true
 
+  local -a provider_data=()
+  local provider_data_count=0
+  local -a parsed_data=()
+  local parsed_data_count=0
+
   for fn_name in "${functions_to_run[@]}"; do
     if bashunit::parallel::is_enabled && bashunit::parallel::must_stop_on_failure; then
       break
     fi
 
-    # Bash 3.0 compatible: unset before redeclaring to clear previous iteration's data
-    unset provider_data
-    local provider_data
-    local provider_data_count=0
+    provider_data=()
+    provider_data_count=0
     while IFS=" " read -r line; do
       [[ -z "$line" ]] && continue
       provider_data[provider_data_count]="$line"
@@ -347,24 +345,22 @@ function bashunit::runner::call_test_functions() {
     # No data provider found
     if [[ "$provider_data_count" -eq 0 ]]; then
       bashunit::runner::run_test "$script" "$fn_name"
-      unset fn_name
+      unset -v fn_name
       continue
     fi
 
     # Execute the test function for each line of data
     for data in "${provider_data[@]}"; do
-      # Bash 3.0 compatible: unset before redeclaring to clear previous iteration's data
-      unset parsed_data
-      local parsed_data
-      local parsed_data_count=0
+      parsed_data=()
+      parsed_data_count=0
       while IFS= read -r line; do
         [[ -z "$line" ]] && continue
         parsed_data[parsed_data_count]="$(bashunit::helper::decode_base64 "${line}")"
         parsed_data_count=$((parsed_data_count + 1))
       done <<< "$(bashunit::runner::parse_data_provider_args "$data")"
       bashunit::runner::run_test "$script" "$fn_name" ${parsed_data+"${parsed_data[@]}"}
     done
-    unset fn_name
+    unset -v fn_name
   done
 }
 
@@ -377,8 +373,7 @@ function bashunit::runner::call_bench_functions() {
   local filtered_functions
   filtered_functions=$(bashunit::helper::get_functions_to_run \
     "$prefix" "$filter" "$_BASHUNIT_CACHED_ALL_FUNCTIONS")
-  # Bash 3.0 compatible array initialization
-  local functions_to_run
+  local -a functions_to_run=()
   local functions_to_run_count=0
   local _fn
   while IFS= read -r _fn; do
@@ -398,7 +393,7 @@ function bashunit::runner::call_bench_functions() {
   for fn_name in "${functions_to_run[@]}"; do
     read -r revs its max_ms <<< "$(bashunit::benchmark::parse_annotations "$fn_name" "$script")"
     bashunit::benchmark::run_function "$fn_name" "$revs" "$its" "$max_ms"
-    unset fn_name
+    unset -v fn_name
   done
 
   if ! bashunit::env::is_simple_output_enabled; then
@@ -726,8 +721,7 @@ function bashunit::runner::parse_result() {
   shift
   local execution_result=$1
   shift
-  # Bash 3.0 compatible array initialization
-  local args
+  local -a args=()
   [[ $# -gt 0 ]] && args=("$@")
 
   if bashunit::parallel::is_enabled; then
@@ -742,8 +736,7 @@ function bashunit::runner::parse_result_parallel() {
   shift
   local execution_result=$1
   shift
-  # Bash 3.0 compatible array initialization
-  local args
+  local -a args=()
   [[ $# -gt 0 ]] && args=("$@")
 
   local test_suite_dir="${TEMP_DIR_PARALLEL_TEST_SUITE}/$(basename "$test_file" .sh)"

src/state.sh

@@ -252,6 +252,7 @@ function bashunit::state::calculate_total_assertions() {
   local numbers
   numbers=$(echo "$input" | grep -oE '##ASSERTIONS_\w+=[0-9]+' | grep -oE '[0-9]+')
 
+  local number
   for number in $numbers; do
     total=$((total + number))
   done