Skip to content

Commit bb58b7b

Browse files
committed
fix(ci): rename syntax-error fixture to .bash so shellcheck skips it
ShellCheck's find-based scanner matched the fixture even with ignore_paths, so rename to .bash to keep it out of both the CI scanner and `make sa`.
1 parent e451059 commit bb58b7b

3 files changed

Lines changed: 1 addition & 3 deletions

File tree

.github/workflows/static_analysis.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,4 @@ jobs:
2525
uses: ludeeus/action-shellcheck@master
2626
env:
2727
SHELLCHECK_OPTS: -e SC1091 -e SC2155 -e SC2016
28-
with:
29-
ignore_paths: tests/acceptance/fixtures/test_bashunit_when_syntax_error.sh
3028

tests/acceptance/bashunit_syntax_error_test.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ function strip_ansi() {
1010
}
1111

1212
function test_bashunit_when_test_file_has_syntax_error() {
13-
local test_file=./tests/acceptance/fixtures/test_bashunit_when_syntax_error.sh
13+
local test_file=./tests/acceptance/fixtures/test_bashunit_when_syntax_error.bash
1414

1515
local actual_raw
1616
set +e

tests/acceptance/fixtures/test_bashunit_when_syntax_error.sh renamed to tests/acceptance/fixtures/test_bashunit_when_syntax_error.bash

File renamed without changes.

0 commit comments

Comments
 (0)