Skip to content

Commit cd6d53d

Browse files
committed
fix(parallel): use command substitution for arithmetic in strict mode
The (( var += val )) syntax returns exit code 1 when result is 0, causing script to exit in strict mode with -e flag. Use var=$((var + val)) instead which never fails.
1 parent f2ab724 commit cd6d53d

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

src/parallel.sh

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,11 +56,11 @@ function bashunit::parallel::aggregate_test_results() {
5656
exit_code=${exit_code:-0}
5757

5858
# Add to the total counts
59-
(( total_failed += failed ))
60-
(( total_passed += passed ))
61-
(( total_skipped += skipped ))
62-
(( total_incomplete += incomplete ))
63-
(( total_snapshot += snapshot ))
59+
total_failed=$((total_failed + failed))
60+
total_passed=$((total_passed + passed))
61+
total_skipped=$((total_skipped + skipped))
62+
total_incomplete=$((total_incomplete + incomplete))
63+
total_snapshot=$((total_snapshot + snapshot))
6464

6565
if [ "${failed:-0}" -gt 0 ]; then
6666
bashunit::state::add_tests_failed

0 commit comments

Comments
 (0)