fix: satisfy shellcheck for array assertion

Author: SauronBot

src/assert_arrays.sh

@@ -6,8 +6,8 @@ function assert_arrays_equal() {
   local label
   label="$(bashunit::assert::label)"
 
-  local -a expected
-  local -a actual
+  local -a expected_values
+  local -a actual_values
   local found_separator=false
   local argument
 
@@ -18,9 +18,9 @@ function assert_arrays_equal() {
     fi
 
     if [ "$found_separator" = true ]; then
-      actual[${#actual[@]}]="$argument"
+      actual_values[${#actual_values[@]}]="$argument"
     else
-      expected[${#expected[@]}]="$argument"
+      expected_values[${#expected_values[@]}]="$argument"
     fi
   done
 
@@ -30,20 +30,20 @@ function assert_arrays_equal() {
     return
   fi
 
-  if [ "${#expected[@]}" -ne "${#actual[@]}" ]; then
+  if [ "${#expected_values[@]}" -ne "${#actual_values[@]}" ]; then
     bashunit::assert::mark_failed
     bashunit::console_results::print_failed_test \
-      "$label" "${expected[*]}" "but got " "${actual[*]}" \
-      "Expected length" "${#expected[@]}, actual length ${#actual[@]}"
+      "$label" "${expected_values[*]}" "but got " "${actual_values[*]}" \
+      "Expected length" "${#expected_values[@]}, actual length ${#actual_values[@]}"
     return
   fi
 
   local index
-  for ((index = 0; index < ${#expected[@]}; index++)); do
-    if [ "${expected[$index]}" != "${actual[$index]}" ]; then
+  for ((index = 0; index < ${#expected_values[@]}; index++)); do
+    if [ "${expected_values[$index]}" != "${actual_values[$index]}" ]; then
       bashunit::assert::mark_failed
       bashunit::console_results::print_failed_test \
-        "$label" "${expected[*]}" "but got " "${actual[*]}" \
+        "$label" "${expected_values[*]}" "but got " "${actual_values[*]}" \
         "Different index" "$index"
       return
     fi

tests/unit/assert_advanced_test.sh

@@ -119,38 +119,38 @@ function test_unsuccessful_assert_array_not_contains() {
 }
 
 function test_successful_assert_arrays_equal() {
-  local expected
-  expected=(Ubuntu 123 Linux\ Mint)
-  local actual
-  actual=(Ubuntu 123 Linux\ Mint)
+  local expected_values
+  expected_values=(Ubuntu 123 Linux\ Mint)
+  local actual_values
+  actual_values=(Ubuntu 123 Linux\ Mint)
 
-  assert_empty "$(assert_arrays_equal "${expected[@]}" -- "${actual[@]}")"
+  assert_empty "$(assert_arrays_equal "${expected_values[@]}" -- "${actual_values[@]}")"
 }
 
 function test_unsuccessful_assert_arrays_equal_with_different_lengths() {
-  local expected
-  expected=(Ubuntu 123 Linux\ Mint)
-  local actual
-  actual=(Ubuntu 123)
+  local expected_values
+  expected_values=(Ubuntu 123 Linux\ Mint)
+  local actual_values
+  actual_values=(Ubuntu 123)
 
   assert_same \
     "$(bashunit::console_results::print_failed_test \
     "Unsuccessful assert arrays equal with different lengths" \
     "Ubuntu 123 Linux Mint" "but got " "Ubuntu 123" "Expected length" "3, actual length 2")" \
-    "$(assert_arrays_equal "${expected[@]}" -- "${actual[@]}")"
+    "$(assert_arrays_equal "${expected_values[@]}" -- "${actual_values[@]}")"
 }
 
 function test_unsuccessful_assert_arrays_equal_with_different_elements() {
-  local expected
-  expected=(Ubuntu 123 Linux\ Mint)
-  local actual
-  actual=(Ubuntu 321 Linux\ Mint)
+  local expected_values
+  expected_values=(Ubuntu 123 Linux\ Mint)
+  local actual_values
+  actual_values=(Ubuntu 321 Linux\ Mint)
 
   assert_same \
     "$(bashunit::console_results::print_failed_test \
     "Unsuccessful assert arrays equal with different elements" \
     "Ubuntu 123 Linux Mint" "but got " "Ubuntu 321 Linux Mint" "Different index" "1")" \
-    "$(assert_arrays_equal "${expected[@]}" -- "${actual[@]}")"
+    "$(assert_arrays_equal "${expected_values[@]}" -- "${actual_values[@]}")"
 }
 
 function test_successful_assert_line_count_empty_str() {