Skip to content

Improve parse_result_parallel performance #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chemaclass merged 1 commit into from
May 31, 2025
Merged

Improve parse_result_parallel performance #412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions src/runner.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,20 +325,17 @@ function runner::parse_result_parallel() {
local test_suite_dir="${TEMP_DIR_PARALLEL_TEST_SUITE}/$(basename "$test_file" .sh)"
mkdir -p "$test_suite_dir"

local test_result_file=$(echo "${args[@]}" | tr '[:upper:]' '[:lower:]' | sed -E 's/[^a-z0-9]+/-/g; s/^-|-$//')
if [[ -z "$test_result_file" ]]; then
test_result_file="${fn_name}.$$.result"
local sanitized_args
sanitized_args=$(echo "${args[*]}" | tr '[:upper:]' '[:lower:]' | sed -E 's/[^a-z0-9]+/-/g; s/^-|-$//')
local template
if [[ -z "$sanitized_args" ]]; then
template="${fn_name}.XXXXXX.result"
else
test_result_file="${fn_name}-${test_result_file}.$$.result"
template="${fn_name}-${sanitized_args}.XXXXXX.result"
fi

local unique_test_result_file="${test_suite_dir}/${test_result_file}"
local count=1

while [ -e "$unique_test_result_file" ]; do
unique_test_result_file="${test_suite_dir}/${test_result_file%.result}-$count.result"
count=$((count + 1))
done
local unique_test_result_file
unique_test_result_file=$(mktemp -p "$test_suite_dir" "$template")

log "debug" "[PARA]" "fn_name:$fn_name" "execution_result:$execution_result"

Expand Down
Loading