Add progress bar#429
Closed
Chemaclass wants to merge 16 commits intomainfrom
Closed
Conversation
Conflicts: CHANGELOG.md
Chemaclass
force-pushed
the
chore/progress-bar
branch
from
e058b56 to
4868689
Compare
Chemaclass
force-pushed
the
chore/progress-bar
branch
from
0a47a6f to
b4db09f
Compare
CosmeValera
suggested changes
Jun 9, 2025
Contributor
There was a problem hiding this comment.
💡 Idea:
Remove the need of writing --progres-bar (or -pb) when running the bashunit script.
Instead, integrate this functionality into the core behaviour of the default system.
For example:
- <15 tests, don't show the progress bar
- =>15 tests, show the progress bar
JesusValeraDev
approved these changes
Jun 9, 2025
Member
Author
|
I am not 100% convince if I like to have this feature entirely. I am not sure if the value added worth the code complexity in it... I will rather wait a little bit and sleep on it. Maybe I can come up with a simpler approach. |
Member
Author
|
close due to high complexity and low added-value so far |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔖 Changes
-pb|--progress-bar🧪 Demo
Screen.Recording.2025-06-09.at.17.38.41.mov