fix(test): skip version assertions on broken binary after download#620
Merged
Chemaclass merged 1 commit intomainfrom Apr 9, 2026
Merged
fix(test): skip version assertions on broken binary after download#620Chemaclass merged 1 commit intomainfrom
Chemaclass merged 1 commit intomainfrom
Conversation
When GitHub downloads fail silently in CI (rate limiting, network flake), the resulting binary is non-functional and --version returns empty. Skip the version check with a descriptive message instead of failing the entire test suite.
Contributor
✅ Contributor ReportUser: @Chemaclass This user is on the trusted contributors list and was automatically approved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--versionassertions in upgrade/install acceptance tests when the downloaded binary is non-functional (returns empty output)Context
The locale CI jobs (Brazilian, Spanish) intermittently fail because GitHub downloads silently return empty/broken binaries (likely rate limiting). This blocks unrelated PRs with failures in
bashunit_upgrade_test.shandinstall_test.sh.The download output assertions still run — only the final
--versioncheck on the binary is guarded.Test plan