fix(runner): honour --stop-on-failure on runtime errors#622
Merged
Chemaclass merged 2 commits intomainfrom Apr 18, 2026
Merged
Conversation
Runtime errors (e.g. `command not found`, `illegal option`) now honour `--stop-on-failure` / `BASHUNIT_STOP_ON_FAILURE=true`, matching the behaviour for assertion failures. Closes #383
Contributor
✅ Contributor ReportUser: @Chemaclass This user is on the trusted contributors list and was automatically approved. |
…r test Under `--strict` (`set -euo pipefail`), `output=$(./bashunit …)` would abort the test body on the inner non-zero exit. Capture the exit code via `|| exit_code=$?` and compare with `assert_same`, since `assert_general_error` reads `$?` (or arg3), not arg1.
JesusValeraDev
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
command not found,illegal option,unbound variable) were not stopping the runner when--stop-on-failure/BASHUNIT_STOP_ON_FAILURE=truewas enabled. Only assertion failures triggered the stop.bashunit::runner::process_test_resultnow checksbashunit::env::is_stop_on_failure_enabledand exits (or marks the parallel runner) the same way the assertion-failure branch does.Closes #383