test(assert): drop jq from flaky custom-assertion test#794
Merged
Conversation
The 'custom assertion with fail shows correct test name' test was the only one of its three siblings to shell out to jq, and the only one that flaked on the macOS CI runner (empty/mismatched captured output) while the two pure-bash siblings never did. Route the failure through bashunit::fail with a pure-bash json check so the test no longer depends on an external binary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
The macOS CI job has been intermittently red on
main(e.g. a docs-only commit failed while the preceding code commit passed) on a single test: "Custom assertion with fail shows correct test name". It is the only one of its three sibling tests that shells out tojq, and the only one that flakes; the two pure-bash siblings never do. Not reproducible locally (0 failures across 65+ isolated and full-suite runs).💡 Changes
_assert_valid_jsonscaffolding jq-free — route the failure throughbashunit::failwith a pure-bash JSON check, removing the external-binary dependency that distinguished the flaky test from its stable siblings