Skip to content

Fix concurrent HtmlParser corruption by removing static singleton #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tyrrrz merged 3 commits into from
May 28, 2026
Merged

Fix concurrent HtmlParser corruption by removing static singleton #956

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6bb9d9a
Initial plan
Copilot May 28, 2026
a29c638
Fix thread safety: create new HtmlParser instance per call instead of…
Copilot May 28, 2026
ab941d8
Update Html.cs
Tyrrrz May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions YoutubeExplode/Utils/Html.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@ namespace YoutubeExplode.Utils;

internal static class Html
{
private static readonly HtmlParser HtmlParser = new();

public static IHtmlDocument Parse(string source) => HtmlParser.ParseDocument(source);
// A new HtmlParser instance must be created for each call to avoid thread safety issues
// when multiple YoutubeClient instances are used concurrently. HtmlParser is not thread-safe
// and sharing a single static instance causes corruption errors (InvalidOperationException)
// in AngleSharp's internal collections.
// https://github.com/Tyrrrz/YoutubeExplode/issues/955
public static IHtmlDocument Parse(string source) => new HtmlParser().ParseDocument(source);
}
Loading